Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shayan/74390/Fix TS Config for P2P #6285

Merged

Conversation

shayan-deriv
Copy link
Member

@shayan-deriv shayan-deriv commented Aug 25, 2022

Changes:

Please include a summary of the change and which issue is fixed below:

  • ...

When you need to add unit test

  • If this change disrupt current flow
  • If this change is adding new flow

When you need to add integration test

  • If components from external libraries are being used to define the flow, e.g. @deriv/components
  • If it relies on a very specific set of props with no default behavior for the current component.

Test coverage checklist (for reviewer)

  • Ensure utility / function has a test case
  • Ensure all the tests are passing

Type of change

  • Bug fix
  • New feature
  • Update feature
  • Refactor code
  • Translation to code
  • Translation to crowdin
  • Script configuration
  • Improve performance
  • Style only
  • Dependency update
  • Documentation update
  • Release

shayan khaleghparast and others added 30 commits July 11, 2022 11:35
@vercel
Copy link

vercel bot commented Aug 25, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
deriv-app ✅ Ready (Inspect) Visit Preview Aug 25, 2022 at 7:40PM (UTC)

@shayan-deriv shayan-deriv changed the title Shyaan/74390/Fix TS Config for P2P Shyayan/74390/Fix TS Config for P2P Aug 25, 2022
@shayan-deriv shayan-deriv changed the title Shyayan/74390/Fix TS Config for P2P Shayan/74390/Fix TS Config for P2P Aug 25, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Aug 25, 2022

A production App ID was automatically generated for this PR. (log)

Click here to copy & paste above information.
- **PR**: [https://github.com/binary-com/deriv-app/pull/6285](https://github.com/binary-com/deriv-app/pull/6285)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-iman-fs-shyaan-74390fix-ts-config-on-p2p.binary.sx?qa_server=frontend.binaryws.com&app_id=32691
    - **Original**: https://deriv-app-git-fork-iman-fs-shyaan-74390fix-ts-config-on-p2p.binary.sx
- **App ID**: `32691`

@codecov-commenter
Copy link

Codecov Report

Merging #6285 (9e38008) into master (03040c9) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #6285   +/-   ##
=======================================
  Coverage   20.95%   20.95%           
=======================================
  Files        1403     1403           
  Lines       32032    32032           
  Branches     5427     5427           
=======================================
  Hits         6712     6712           
  Misses      24937    24937           
  Partials      383      383           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@sonarcloud
Copy link

sonarcloud bot commented Aug 25, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@farrah-deriv farrah-deriv merged commit a6fad14 into binary-com:master Aug 29, 2022
@shayan-deriv shayan-deriv deleted the shyaan/74390/fix-ts-config-on-p2p branch January 12, 2024 04:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants