Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

farrah/74829/fixed errors on change of payment method fields #6328

Merged
merged 2 commits into from
Aug 30, 2022

Conversation

farrah-deriv
Copy link
Contributor

Changes:

Please include a summary of the change and which issue is fixed below:

  • Fixed errors on change of payment method fields when adding/updating a payment method

When you need to add unit test

  • If this change disrupt current flow
  • If this change is adding new flow

When you need to add integration test

  • If components from external libraries are being used to define the flow, e.g. @deriv/components
  • If it relies on a very specific set of props with no default behavior for the current component.

Test coverage checklist (for reviewer)

  • Ensure utility / function has a test case
  • Ensure all the tests are passing

Type of change

  • Bug fix
  • New feature
  • Update feature
  • Refactor code
  • Translation to code
  • Translation to crowdin
  • Script configuration
  • Improve performance
  • Style only
  • Dependency update
  • Documentation update
  • Release

@boring-cyborg boring-cyborg bot added the P2P label Aug 29, 2022
@vercel
Copy link

vercel bot commented Aug 29, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
deriv-app ✅ Ready (Inspect) Visit Preview Aug 30, 2022 at 3:45AM (UTC)

@farrah-deriv farrah-deriv changed the title farrah/ fixed errors on change of payment method fields farrah/74829/fixed errors on change of payment method fields Aug 29, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Aug 29, 2022

A production App ID was automatically generated for this PR. (log)

Click here to copy & paste above information.
- **PR**: [https://github.com/binary-com/deriv-app/pull/6328](https://github.com/binary-com/deriv-app/pull/6328)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-farrah-deriv-fix-pm-validation.binary.sx?qa_server=frontend.binaryws.com&app_id=24063
    - **Original**: https://deriv-app-git-fork-farrah-deriv-fix-pm-validation.binary.sx
- **App ID**: `24063`

@codecov-commenter
Copy link

Codecov Report

Merging #6328 (1a31c82) into master (d1762d4) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master    #6328      +/-   ##
==========================================
- Coverage   20.72%   20.72%   -0.01%     
==========================================
  Files        1402     1402              
  Lines       32075    32076       +1     
  Branches     5420     5420              
==========================================
  Hits         6648     6648              
- Misses      25016    25017       +1     
  Partials      411      411              
Impacted Files Coverage Δ
packages/p2p/src/stores/my-profile-store.js 0.00% <0.00%> (ø)
packages/cashier/src/containers/routes/routes.jsx 83.33% <0.00%> (ø)
...nt/payment-agent-deposit/payment-agent-deposit.jsx 13.33% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@farrah-deriv farrah-deriv marked this pull request as ready for review August 29, 2022 12:30
@matin-deriv matin-deriv merged commit a1f8ed0 into binary-com:master Aug 30, 2022
@sonarcloud
Copy link

sonarcloud bot commented Aug 30, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
3.5% 3.5% Duplication

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants