carol/P2P: Error codes cleanup #6550
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 25 commits
April 14, 2022 16:31
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
A production App ID was automatically generated for this PR. (log)
Click here to copy & paste above information. |
nijil-deriv
approved these changes
Sep 22, 2022
farrah-deriv
approved these changes
Sep 26, 2022
|
Kudos, SonarCloud Quality Gate passed!
|
adrienne-deriv
pushed a commit
to adrienne-deriv/deriv-app
that referenced
this pull request
Oct 20, 2022
adrienne-deriv
pushed a commit
to adrienne-deriv/deriv-app
that referenced
this pull request
Oct 25, 2022
prince-deriv
pushed a commit
that referenced
this pull request
Nov 10, 2022
* Jim/74386/bot-web-ui-ts-config-fix (#6354) * refactor: update tsconfigurations for bot-web-ui * fix: resolve typescript error by disabling ts-check * Farzin/78410/Replace `connect` method with `useStore` hook for components related to `Deposit` (#6746) * refactor(cashier): 🔥 replace `connect` method with `useStore` hook in `deposit` * fix(cashier): ✅ fix failing test due to `StoreProvider` not being provided * Trigger Build * fix(components): 💄 fix `Timeline` item alignment issue (#6682) * refactor: ⬆️ upgraded depenedency that caused build failure (#6656) * thisyahlen/create new account text align in button (#6684) * create new account text align in button * removed classname * fix(account): ✏️ change `DMT5` to `Deriv MT5` in setting (#6668) * Amina/cfd_personal_details_component (#6639) * personal_deatils * fix * form validation * pr review Co-authored-by: Farrah Mae Ochoa <82315152+farrah-deriv@users.noreply.github.com> Co-authored-by: Matin shafiei <matin@deriv.com> * Farzin/77435/add `useSubscription` hook (#6621) * fix(cashier): 🐛 fix `tsconfig` * feat(shared): ✨ expose `WS` object from `shared` package via `useWS` * feat(cashier): ✨ add `useCountdown` hook * feat(cashier): ✨ add `useWS` hook * feat(cashier): ✨ add `useStore` hook and `StoreContext` * feat(cashier): ✨ add `useVerifyEmail` hook * test(cashier): ✅ add test for `useCountdown` hook * test(cashier): ✅ add test for `useWS` hook * fix(cashier): 📝 resolve PR comments * fix(cashier): 📝 resolve PR comments * fix(cashier): 📝 resolve PR comments * fix(cashier): 📝 resolve PR comments * refactor(cashier): ♻️ improve types for `useWS` hook * feat(cashier): ✨ add `useSubscription` hook * test(cashier): ✅ add test for `useSubscription` hook * feat(cashier): ✨ add `useNeedAuthentication` hook * feat(cashier): ✨ add `useNeedFinancialAssessment` hook * feat(cashier): ✨ add `useRealSTPAccount` hook * feat(cashier): ✨ add `useNeedTNC` hook * feat(cashier): ✨ add `useDepositLocked` hook * fix(cashier): 📝 resolve PR comments * fix(cashier): 📝 resolve PR comments * Ameerul /Bug 77290 Dialogue box looks small in responsive view (#6633) * added width to error-modal and removed small prop * added ic-blocked-advertisers-barred icon * chore: remove unnecessary appcard, virtualwalletcard and realwalletcard components (#6546) * error codes cleanup (#6550) * Ameerul /Bug 76675 Deriv P2P notification disappears when we refresh the page (#6603) * fixed notifications on refresh in cashier page * removed old function for getting unseen notifications * added jsdoc for p2p_unseen_notifications * Update packages/cashier/src/stores/general-store.js Co-authored-by: Farrah Mae Ochoa <82315152+farrah-deriv@users.noreply.github.com> Co-authored-by: Farrah Mae Ochoa <82315152+farrah-deriv@users.noreply.github.com> * likhith/ preventing over throttling of onfido token fetch API (#6495) * feat: incorporated Exponential_backoff logic * perf: ⚡ invokes API and on failure triggers retry Co-authored-by: System Administrator <root@Likhith-Kolayaris-MacBook-Pro-C02G8AT9MD6M.local> * remove_horizontal_scroll_of_onmapp_in_firefox (#6715) * Ameerul /Bug 74362 Give feedback button does nothing when user in existing order page (#6456) * added new function in notifications store to get order id and show rating modal from p2p side * fixed spelling * renamed order_props to p2p_order_props and added toggleNotificationsModal to onClick for give feedback * fixed give action onClick for give feedback button in general store * added new function to redirect to order details page, changed logic for handling completed order notifications * removed text from Give Feedback * fixed notifications count bell bug when rating order, and refactored logic * removed setP2POrderConfig from order-details, moved to app.jsx in useEffect * called setP2POrderProps in order-details when unmounted so the id is set to null * renamed notification_action to notification_redirect_action * removed commented out console log * Added margin spacing between advertiser page header and description (#6420) * Added margin spacing between advertiser page header and description * Aligned avatar icon to flex-start * time to fix merge conflicts * Ameerul /Bug 69674 Improve floating rate field to handle large rate values (#6286) * changed the margin-top for mobile view for buy-sell * merging upstream master * changed the payment methods list modal and wrapped the text for long bank names * reverted changes * changed floating rate field and ad type styling * removed code from other PR * changed input field value text * removed local currency from market rate * changed floating rate spec file * changed floating rate msg font size to small * fixed font size * fixed decimal point in buy/sell amount (#6645) * Ameerul /Bug 64212 Order limit is not reflected correctly in the buy sell pop up modal (#6649) * fixed order limit issue for available amount user can spend * implemented comments * fixed sell order limit * forced opacity for full page modal quick add (#6681) * translations: 📚 sync translations with crowdin (#6797) Co-authored-by: DerivFE <80095553+DerivFE@users.noreply.github.com> * translations: 📚 sync translations with crowdin (#6799) Co-authored-by: DerivFE <80095553+DerivFE@users.noreply.github.com> * translations: 📚 sync translations with crowdin (#6800) Co-authored-by: DerivFE <80095553+DerivFE@users.noreply.github.com> * fixed advertiser buy and sell balance (#6803) * Niloofar | Mobx 6 (#6371) * update MobX libraries * bot migration * trader migration * core migration * cfd migration * p2p migration * cashier migration * regenerate package-lock.json * fix verification store issue on cashier * temperately commented failed tests to find a solution * fix console errors related to mobx * regenerate package-lock.json * fix general store issue on p2p * bug: fix p2p stores bugs * fix console errors * fix: Open position blinking while there is active contract going on * fix: blinking issue * fix: nitpik * fix bot issue * chores: change @deriv/deriv-charts versions * fix: flags issue * fix: fixed chart not showing flags when contract begins * fix: save to local storage issues * fix: conflicts * fix: cashier link's blinking issue * fix: personal-details undefined * fix: personal details submit button issue Co-authored-by: iman <iman@firstsource.tech> * translations: 📚 sync translations with crowdin (#6805) Co-authored-by: DerivFE <80095553+DerivFE@users.noreply.github.com> * Fixed issues with newlines not detecting in order details (#6381) * add test coverage for BuySellFormReceiveAmount component (#6675) * translations: 📚 sync translations with crowdin (#6797) Co-authored-by: DerivFE <80095553+DerivFE@users.noreply.github.com> * translations: 📚 sync translations with crowdin (#6799) Co-authored-by: DerivFE <80095553+DerivFE@users.noreply.github.com> * translations: 📚 sync translations with crowdin (#6800) Co-authored-by: DerivFE <80095553+DerivFE@users.noreply.github.com> * fixed advertiser buy and sell balance (#6803) * translations: 📚 sync translations with crowdin (#6805) Co-authored-by: DerivFE <80095553+DerivFE@users.noreply.github.com> * P2p cross border ad feature (#6564) * farrah/76186/currency selector component (#6512) * currency dropdown component * refactor * fixed bugs * farrah/76187/Ad filter flow (#6627) * ad filtering flow * refactor code * fixed buy/sell ads in advertiser page * fixed currency not selected in responsive * fixed currency selector height in responsive * fixed currency list update * fixed styles * fixed highlighted currency issue * fixed style issues * fixed supported payment methods * fixed supported payment methods * fixed advertiser payment methods * fixd advertiser payment method * fixed loading of payment methods * fixed floating rate issues * fixed exchange rate issues * fixed failing tests * translations: 📚 sync translations with crowdin (#6812) Co-authored-by: DerivFE <80095553+DerivFE@users.noreply.github.com> * bahar|bala/handle_redirection_on_withdrawal_links_for_deriv_go (#6760) * handle_redirection_on_withdrawal_links_for_deriv_go * fix_app_id_issue * fix_login_issue * add_fix * revert_last_changes * Merge branch 'handle_redirection_on_withdrawal_links_for_deriv_go' of https://github.com/Bahar-FS/deriv-app into handle_redirection_on_withdrawal_links_for_deriv_go * fix_redirect_issue * fix_issue * fixed ads exchange rate (#6818) * translations: 📚 sync translations with crowdin (#6819) Co-authored-by: DerivFE <80095553+DerivFE@users.noreply.github.com> * Amina/real_mt5_dashboard_in demo_account_banner fix (#6736) * demo_accoumt * demo_accoumt * demo_accoumt * switch account message from compare_accounts_modal * text size and align Co-authored-by: Matin shafiei <matin@deriv.com> * Ameerul /Bug 66642 Display the Ewallet name on PaymentMethod tiles (#6671) * showed payment method type for each pm card instead of the value and moved edit delete functionality into store * took size out of text as default is s * fixed method name for delete payment method modal * wrapped payment-method-card in react.memo to stop flickering * refactored icon * added setIsLoading in payment-methods to render loader first * added prop for sending icon name to payment method card, checking if it works on testlink for my_profile * reverted pull from master and added changes to icon for payment methods card * Jim/78604/remove-unused-appsetings-component-and-tempappsettings (#6750) * chore: remove app-settings component and temp-app-settings * fix: fix failing tests * thisyahlen/fix popover bug (#6781) * fix popover bug * remove space * Content changes for market restructures (#6816) * Akmal / Update mt5 content for eu clients (#6815) * Update mt5 content for eu clients * Revert the change since requirements changed * Change label * observable (#6825) * translations: 📚 sync translations with crowdin (#6826) Co-authored-by: DerivFE <80095553+DerivFE@users.noreply.github.com> * chore: fix validation setup flow (#6830) * fix: validation-error undefined (#6835) * translations: 📚 sync translations with crowdin (#6837) Co-authored-by: DerivFE <80095553+DerivFE@users.noreply.github.com> * translations: 📚 sync translations with crowdin (#6839) Co-authored-by: DerivFE <80095553+DerivFE@users.noreply.github.com> * Suisin/not able to create account when click on account switcher in cashier (#6831) * change currency-selector scss * Update Scss to include buy-sell class * Update currency-selector.jsx * rigion-should-not-be-shown-in-the-account-selection-dropdown-of-account-transfer (#6828) * yauheni/74190/ ts migration for account unlink modal (#6374) * yauheni/74190/ ts migration for account unlink modal * props listing alphabetically Co-authored-by: “yauheni-kryzhyk-deriv” <“yauheni@deriv.me”> * yauheni/79513/no language redirection from derivapp (#6824) * yauheni/79513/no language redirection from derivapp * functions call refactor Co-authored-by: “yauheni-kryzhyk-deriv” <“yauheni@deriv.me”> * Mahdiyeh/Feature: add social unlinking (#4854) * add wrong typo part to the sent-email-modal and add live chat * change Password to Emails and passwords * add change email component to Emails and passwors * add email reset modal * add reset email modal * add success email modal * add redirection of social_email_change modal * fix responsive mode * fix sendEmailModal * add verification_code for social_emil_change * get email from url * add condition for change email part for social and non-social account * fix change_email modal when get invalidToken error * add change_email_actions to ignore list of invalidToken error handling * add email success modal * automate email change for non social accounts * remove unnecessary changes * fix invalidToken error for change_email * fix typos and naming and minify the svg * fix typo * remove successEmailModal and clean the code * fix logging out the user, email_modal size on mobile and remove success icon when request fails * fix redirecting to the trade page * fix success modal content * remove email part from personalDetails page * fix email and passwords name when it is social account * show email box in personalDetails for social accounts * sync changes with automation email * change px to rem * add <br/> to the success message to the email update modal * fix typo * chnage the behaviour for apple id when click on the unlink button * fix verification_code error * fix email and passord name for all social and non social emails * remove UnlinkModal from deriv-password * update with master * update branch * fix apple icon * translations: 📚 sync translations with crowdin (#6842) Co-authored-by: DerivFE <80095553+DerivFE@users.noreply.github.com> * Akmal / Change highlighted market to subgroup (#6810) * Change highlighted market to subgroup * Replace icons Co-authored-by: Matin shafiei <matin@deriv.com> * chore: update deriv-charts (#6850) * translations: 📚 sync translations with crowdin (#6853) Co-authored-by: DerivFE <80095553+DerivFE@users.noreply.github.com> * Fix: derived and forex account limits structure (#6856) * Fix: synthetic to derived on welcome modal (#6857) * translations: 📚 sync translations with crowdin (#6859) Co-authored-by: DerivFE <80095553+DerivFE@users.noreply.github.com> * fixed cross border ad style (#6844) * bahar/extract_copy_to_clipboard_to_hook (#6753) * extract_copy_to_clipboard_to_hook * add_error_handling * yauheni/9321/self exclusion validation max balance max open positions for cr clients (#6677) * yauheni/9321/self exclusion validation max balance max open positions for cr clients * changed to true/false handling instead of number greater then 0 * added explanation comment for account balance value Co-authored-by: “yauheni-kryzhyk-deriv” <“yauheni@deriv.me”> * Matin/Aizad: Acuity Social Trading (#6798) * Acuity social trading notification implementation * Chore: Close notification on download * task: implement components in mt5 dashboard * Chore: Make notification disposable and display it only in DTrader * task: create acuity download modal and update ui store * fix: remove unnecessary files and update png * fix: added props to acuity banner * add dark close button for notification acuity * task: create notification for acuity on mt5 * Chore: Fix nitpicks * Chore: Moved Acuity download modal to core and lazyload it * fix: remove extra padding on demo account * fix: fix cfd card height * Chore: Added Acuity for Demo accounts * Fix: Display Acuity on MT5 dashboard * Fix: Display notifications on a specific platform * Fix: small bug * Chore: updated a test file * fix: updated download link in modal * Chore: address code reviews * Chore: address code reviews * Fix: typo * Chore: Display notifications for both Demo and Real accounts * Chore: small fix * Chore: Display Acuity banners for all clients including EU * Chore: To display notification only on MT5 page * Chore: Added a new link for EU users Co-authored-by: Aizad Ridzo <aizad@deriv.com> Co-authored-by: aizad-deriv <103104395+aizad-deriv@users.noreply.github.com> * farrah/80516/fixed currency dropdown style (#6865) * fixed currency style * refactor code * farrah/80646/fixed buy/sell ad rate (#6867) * fixed observables * fixed rate in advertiser page * updated save modal store * fixed mobx issue in quickstrategy store Co-authored-by: Jim Daniels Wasswa <104334373+jim-deriv@users.noreply.github.com> Co-authored-by: Farzin Mirzaie <72082844+farzin-fs@users.noreply.github.com> Co-authored-by: Likhith Kolayari <98398322+likhith-deriv@users.noreply.github.com> Co-authored-by: thisyahlen <104053934+thisyahlen-deriv@users.noreply.github.com> Co-authored-by: amina-deriv <84661147+amina-deriv@users.noreply.github.com> Co-authored-by: Farrah Mae Ochoa <82315152+farrah-deriv@users.noreply.github.com> Co-authored-by: Matin shafiei <matin@deriv.com> Co-authored-by: ameerul-deriv <103412909+ameerul-deriv@users.noreply.github.com> Co-authored-by: Carol Sachdeva <58209918+carol-binary@users.noreply.github.com> Co-authored-by: System Administrator <root@Likhith-Kolayaris-MacBook-Pro-C02G8AT9MD6M.local> Co-authored-by: Bahar <bahar@regentmarkets.com> Co-authored-by: adrienne-deriv <103016120+adrienne-deriv@users.noreply.github.com> Co-authored-by: Farrah Mae Ochoa <farrah@deriv.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: DerivFE <80095553+DerivFE@users.noreply.github.com> Co-authored-by: Niloofar Sadeghi <93518187+niloo-fs@users.noreply.github.com> Co-authored-by: iman <iman@firstsource.tech> Co-authored-by: Akmal Djumakhodjaev <akmal@binary.com> Co-authored-by: balakrishna-binary <56330681+balakrishna-binary@users.noreply.github.com> Co-authored-by: Sui Sin <103026762+suisin-deriv@users.noreply.github.com> Co-authored-by: yauheni-kryzhyk-deriv <103182683+yauheni-kryzhyk-deriv@users.noreply.github.com> Co-authored-by: “yauheni-kryzhyk-deriv” <“yauheni@deriv.me”> Co-authored-by: mahdiyeh-fs <82078941+mahdiyeh-fs@users.noreply.github.com> Co-authored-by: Aizad Ridzo <aizad@deriv.com> Co-authored-by: aizad-deriv <103104395+aizad-deriv@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
Please include a summary of the change and which issue is fixed below:
When you need to add unit test
When you need to add integration test
Test coverage checklist (for reviewer)
Type of change