farrah/78916/refactor InvalidVerificationLinkModal #7017
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…iv-app into invalid-verification-link-modal
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
A production App ID was automatically generated for this PR. (log)
Click here to copy & paste above information. |
farrah-deriv
requested review from
carolsachdeva and
nijil-deriv
as code owners
farrah-deriv
changed the title
farrah-deriv
changed the title
| invalid_verification_link_error_message={order_store.verification_link_error_message} | ||
| is_invalid_verification_link_modal_open={order_store.is_invalid_verification_link_modal_open} | ||
| setIsInvalidVerificationLinkModalOpen={order_store.setIsInvalidVerificationLinkModalOpen} | ||
| onClickGetNewLinkButton={() => order_store.confirmOrderRequest(id)} |
There was a problem hiding this comment.
Same as this, should we refactor out modal props that receive handlers? Since it might affect reusability if other pages has different ways to handle the onClick events
There was a problem hiding this comment.
Good point. But i think for now we can since this modal is specific to orders only.
| const wait = setTimeout(() => this.setIsInvalidVerificationLinkModalOpen(true), 230); | ||
| this.root_store.general_store.showModal({ | ||
| key: 'InvalidVerificationLinkModal', | ||
| props: { error_message: response.error.message, order_id: id }, |
There was a problem hiding this comment.
Suggested change
| props: { error_message: response.error.message, order_id: id }, | |
| props: { error_message: response?.error.message, order_id: id }, |
There was a problem hiding this comment.
we are already checking response on line 138
| } else if (response.error.code === api_error_codes.EXCESSIVE_VERIFICATION_FAILURES) { | ||
| if (this.is_invalid_verification_link_modal_open) { | ||
| this.setIsInvalidVerificationLinkModalOpen(false); | ||
| } |
There was a problem hiding this comment.
Is it possible to handle this by getting the modal key from modal manager, checking against it and only hiding the modal if it is the InvalidVerificationLinkModal?
There was a problem hiding this comment.
I believe there's no need to pass the modal key when hiding since we are showing and hiding modals one at a time.
Codecov Report
@@ Coverage Diff @@
## p2p-modal-manager #7017 +/- ##
=====================================================
+ Coverage 19.45% 20.20% +0.74%
=====================================================
Files 1485 1475 -10
Lines 34610 34256 -354
Branches 6394 6329 -65
=====================================================
+ Hits 6732 6920 +188
+ Misses 27366 26852 -514
+ Partials 512 484 -28
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
|
Kudos, SonarCloud Quality Gate passed!
|
nijil-deriv
approved these changes
Jan 4, 2023
farrah-deriv
added a commit
that referenced
this pull request
Feb 21, 2023
* added modal manager component (#6768) * farrah/81373/lazy loading in p2p (#6907) * perf: configured webpack for lazy loading * added css lazy loading * fix: fixed missing css * refactor: myAdsFloatingRateSwitchModal (#7173) * refactor: emailLinkVerifiedModal (#7118) * refactor: myAdsDeleteModal (#7024) * refactor: adExceedsDailyLimitModal (#7027) * farrah/78909/refactor FilterModal (#6906) * refactor filter modal * perf: added lazy loading * fix: added publicPath * farrah/78919/refactor OrderDetailsCancelModal (#7018) * refactor: order details cancel modal * fix: tests * Adrienne / BuySellModal and CancelAddPaymentMethodModal component with saved form state component (#7077) * saved draft * Refactored out cleanupFn argument in hideModal * fix: added modal form and saving state * fixed issues with mobile stacking modal * refactored out comments * refactor: remove cancel add payment method modal from my profile * removed add payment method modal in my profile * removed icons.js * removed icons.js * refactor: fix import path for modal form * refactor: fix import path for modal form * refactor: fix import path for modal form * chore: reverted change on cancel add payment method modal in my profile folder * chore: refactored code * chore: revert * Fix merge conflicts * Adrienne / Refactored Create Ad Add Payment Method Modal and Add Payment Method Error Modal (#7210) * chore: fixed issues with dropdown detecting as clicking outside modal * chore: updated branch with drafted branch * chore: added sycned branch changes * farrah/78918/refactor EmailVerificationModal (#7056) * refactor: emailVerificationModal * Refactored out EmailLinkVerifiedModal since that related modal card is merged to p2p-modal-manager * Refactored out EmailLinkVerifiedModal observables Co-authored-by: adrienne-deriv <103016120+adrienne-deriv@users.noreply.github.com> * farrah/78920/refactor OrderDetailsConfirmModal (#7038) * refactor: orderDetailsConfirmModal * refactor: onClick handler * chore: fix issues with build after merge conflicts Co-authored-by: adrienne-deriv <103016120+adrienne-deriv@users.noreply.github.com> * farrah/78927/refactor EditAdCancelModal (#7122) * refactor: editAdCancelModal * Refactored out CreateAdAddPaymentMethodModal since its already merged to p2p-modal-manager Co-authored-by: adrienne-deriv <103016120+adrienne-deriv@users.noreply.github.com> * farrah/78925/refactor CreateAdErrorModal (#7052) * refactor: createAdErrorModal * chore: fixed merge conflict issues Co-authored-by: adrienne-deriv <103016120+adrienne-deriv@users.noreply.github.com> * Adrienne / Rating modal and Recommended modal (#7132) * saved draft * refactor: added rating modal * added recommended modal * refactored code * refactored code * refactor: fixed issues with test * fix: added mock function for useModalManagerContext in app content test * refactored out comment for should_show_rating_modal * refactor: refactored out props for rating modal * chore: removed modal props on cleanup * chore: fixed issues with test * chore: refactor based on reviews * chore: refactor * Adrienne / Refactored Delete Payment Method Error modal and Cancel Edit Payment method modal (#7222) * saved draft * refactor: added delete payment method error modal * chore: fixed an issue where payment methods are not listed for sell ads * chore: fixed issue where back button does not trigger cancel edit pm modal * farrah/78916/refactor InvalidVerificationLinkModal (#7017) * refactor: invalid verification link modal * refactor: error message * chore: fixed merge conflicts Co-authored-by: adrienne-deriv <103016120+adrienne-deriv@users.noreply.github.com> * Adrienne / Error modal (#7283) * saved draft * refactor: added error modal * chore: reverted old changes modals folder * Adrienne / Currency Selector modal (#7279) * saved draft * refactor: added currency selector modal * chore: revert old changes modals folder * Adrienne / Block User Modal (#7276) * saved draft * refactor: added block user modal * chore: fix issues with test build * chore: removed comments * chore: updated comment * chore: fixed issues with running build * chore: fixed issues with running test * refactor: loading modal (#7006) Co-authored-by: adrienne-deriv <103016120+adrienne-deriv@users.noreply.github.com> * Adrienne / Rate Change Modal (#7266) * saved draft * refactor: added rate change modal * chore: changed isRateChanged function * chore: refactored hideModal with options * chore: reverted comments * chore: refactored naming options for hidemodal * Adrienne / Quick Add Modal and integrating new payment method dropdown component for buy ads in the modal (#7308) * saved draft * refactor: added quick add modal and new dropdown component * chore: refactored out unusesd files * chore: reverted merge conflict issues * chore: removed old merge conflicts * chore: fixed merge conflicts and added 2 new modals * chore: reverted refactor and used error modal instead * farrah/78906/refactor MarketRateChangeErrorModal (#7357) * refactor: market rate change error modal * refactor: code * refactor: unnecessary code * refactor: fixed issues with buy ad payment methods list Co-authored-by: adrienne-rio <adrienne@deriv.com> * fix: conflicts * fix: conflicts * Adrienne / Wrong popup message counterparty block user modal (#7459) * saved draft * fix: fixed an issue where incorrect block user modal message is shown in block user list * chore: removed old commits * Adrienne / Fix issue verification link modal showing twice (#7545) * saved draft * fix: verification modal now shows once * Adrienne / Add payment method not dismissed create ad (#7505) * saved draft * fix: create ad add payment method modal now closes when user adds a pm * chore: removed old commits * chore: added multiple arguments for iscurrentmodal * Adrienne / Market rate change popup not displayed (#7478) * saved draft * fix: fixed an issue where rate change modal is not shown when user changes to different currency * chore: removed old commits * Adrienne / Fixed issue with block user error modal (#7539) * saved draft * fix: reset error status * chore: removed old commits * fix: fixed an issue where the error modal is displayed twice * Adrienne / Fix bug in buy sell header and refactored code (#7624) * saved draft * refactor: refactored buy sell modal header * chore: removed comments * chore: applied code review refactors --------- Co-authored-by: adrienne-deriv <103016120+adrienne-deriv@users.noreply.github.com> Co-authored-by: adrienne-rio <adrienne@deriv.com>
sanjam-deriv
pushed a commit
to sanjam-deriv/deriv-app
that referenced
this pull request
Mar 13, 2023
* added modal manager component (binary-com#6768) * farrah/81373/lazy loading in p2p (binary-com#6907) * perf: configured webpack for lazy loading * added css lazy loading * fix: fixed missing css * refactor: myAdsFloatingRateSwitchModal (binary-com#7173) * refactor: emailLinkVerifiedModal (binary-com#7118) * refactor: myAdsDeleteModal (binary-com#7024) * refactor: adExceedsDailyLimitModal (binary-com#7027) * farrah/78909/refactor FilterModal (binary-com#6906) * refactor filter modal * perf: added lazy loading * fix: added publicPath * farrah/78919/refactor OrderDetailsCancelModal (binary-com#7018) * refactor: order details cancel modal * fix: tests * Adrienne / BuySellModal and CancelAddPaymentMethodModal component with saved form state component (binary-com#7077) * saved draft * Refactored out cleanupFn argument in hideModal * fix: added modal form and saving state * fixed issues with mobile stacking modal * refactored out comments * refactor: remove cancel add payment method modal from my profile * removed add payment method modal in my profile * removed icons.js * removed icons.js * refactor: fix import path for modal form * refactor: fix import path for modal form * refactor: fix import path for modal form * chore: reverted change on cancel add payment method modal in my profile folder * chore: refactored code * chore: revert * Fix merge conflicts * Adrienne / Refactored Create Ad Add Payment Method Modal and Add Payment Method Error Modal (binary-com#7210) * chore: fixed issues with dropdown detecting as clicking outside modal * chore: updated branch with drafted branch * chore: added sycned branch changes * farrah/78918/refactor EmailVerificationModal (binary-com#7056) * refactor: emailVerificationModal * Refactored out EmailLinkVerifiedModal since that related modal card is merged to p2p-modal-manager * Refactored out EmailLinkVerifiedModal observables Co-authored-by: adrienne-deriv <103016120+adrienne-deriv@users.noreply.github.com> * farrah/78920/refactor OrderDetailsConfirmModal (binary-com#7038) * refactor: orderDetailsConfirmModal * refactor: onClick handler * chore: fix issues with build after merge conflicts Co-authored-by: adrienne-deriv <103016120+adrienne-deriv@users.noreply.github.com> * farrah/78927/refactor EditAdCancelModal (binary-com#7122) * refactor: editAdCancelModal * Refactored out CreateAdAddPaymentMethodModal since its already merged to p2p-modal-manager Co-authored-by: adrienne-deriv <103016120+adrienne-deriv@users.noreply.github.com> * farrah/78925/refactor CreateAdErrorModal (binary-com#7052) * refactor: createAdErrorModal * chore: fixed merge conflict issues Co-authored-by: adrienne-deriv <103016120+adrienne-deriv@users.noreply.github.com> * Adrienne / Rating modal and Recommended modal (binary-com#7132) * saved draft * refactor: added rating modal * added recommended modal * refactored code * refactored code * refactor: fixed issues with test * fix: added mock function for useModalManagerContext in app content test * refactored out comment for should_show_rating_modal * refactor: refactored out props for rating modal * chore: removed modal props on cleanup * chore: fixed issues with test * chore: refactor based on reviews * chore: refactor * Adrienne / Refactored Delete Payment Method Error modal and Cancel Edit Payment method modal (binary-com#7222) * saved draft * refactor: added delete payment method error modal * chore: fixed an issue where payment methods are not listed for sell ads * chore: fixed issue where back button does not trigger cancel edit pm modal * farrah/78916/refactor InvalidVerificationLinkModal (binary-com#7017) * refactor: invalid verification link modal * refactor: error message * chore: fixed merge conflicts Co-authored-by: adrienne-deriv <103016120+adrienne-deriv@users.noreply.github.com> * Adrienne / Error modal (binary-com#7283) * saved draft * refactor: added error modal * chore: reverted old changes modals folder * Adrienne / Currency Selector modal (binary-com#7279) * saved draft * refactor: added currency selector modal * chore: revert old changes modals folder * Adrienne / Block User Modal (binary-com#7276) * saved draft * refactor: added block user modal * chore: fix issues with test build * chore: removed comments * chore: updated comment * chore: fixed issues with running build * chore: fixed issues with running test * refactor: loading modal (binary-com#7006) Co-authored-by: adrienne-deriv <103016120+adrienne-deriv@users.noreply.github.com> * Adrienne / Rate Change Modal (binary-com#7266) * saved draft * refactor: added rate change modal * chore: changed isRateChanged function * chore: refactored hideModal with options * chore: reverted comments * chore: refactored naming options for hidemodal * Adrienne / Quick Add Modal and integrating new payment method dropdown component for buy ads in the modal (binary-com#7308) * saved draft * refactor: added quick add modal and new dropdown component * chore: refactored out unusesd files * chore: reverted merge conflict issues * chore: removed old merge conflicts * chore: fixed merge conflicts and added 2 new modals * chore: reverted refactor and used error modal instead * farrah/78906/refactor MarketRateChangeErrorModal (binary-com#7357) * refactor: market rate change error modal * refactor: code * refactor: unnecessary code * refactor: fixed issues with buy ad payment methods list Co-authored-by: adrienne-rio <adrienne@deriv.com> * fix: conflicts * fix: conflicts * Adrienne / Wrong popup message counterparty block user modal (binary-com#7459) * saved draft * fix: fixed an issue where incorrect block user modal message is shown in block user list * chore: removed old commits * Adrienne / Fix issue verification link modal showing twice (binary-com#7545) * saved draft * fix: verification modal now shows once * Adrienne / Add payment method not dismissed create ad (binary-com#7505) * saved draft * fix: create ad add payment method modal now closes when user adds a pm * chore: removed old commits * chore: added multiple arguments for iscurrentmodal * Adrienne / Market rate change popup not displayed (binary-com#7478) * saved draft * fix: fixed an issue where rate change modal is not shown when user changes to different currency * chore: removed old commits * Adrienne / Fixed issue with block user error modal (binary-com#7539) * saved draft * fix: reset error status * chore: removed old commits * fix: fixed an issue where the error modal is displayed twice * Adrienne / Fix bug in buy sell header and refactored code (binary-com#7624) * saved draft * refactor: refactored buy sell modal header * chore: removed comments * chore: applied code review refactors --------- Co-authored-by: adrienne-deriv <103016120+adrienne-deriv@users.noreply.github.com> Co-authored-by: adrienne-rio <adrienne@deriv.com>
ali-hosseini-deriv
pushed a commit
that referenced
this pull request
Jun 30, 2023
…t-card] (#7683) * Amina/fix: 89022_personal_details_section_on_signup (#7668) * fix: personal details broke * chore: trigger circleci_build * fix: account switcher * fix: 🐛 fix contact us link (#7653) Co-authored-by: Carol Sachdeva <58209918+carol-deriv@users.noreply.github.com> * fix: 🐛 safely pulls lang from query params, defaults to english (#7662) Co-authored-by: Carol Sachdeva <58209918+carol-deriv@users.noreply.github.com> * chore: add characters for regex in address line 1 and 2 in account signup (#7568) * Refactor shaheer/87591/app modals (#7626) * refactor: 🎨 minimize if checks, refactored individual if checks to if-else-if checks * refactor: 🎨 Refactored and seperated modal * refactor: packages shared utils array ts migration * refactor: array check remove * refactor: function returned to arrow * refactor: function returned to arrow * farrah/ modal refactoring (#6769) * added modal manager component (#6768) * farrah/81373/lazy loading in p2p (#6907) * perf: configured webpack for lazy loading * added css lazy loading * fix: fixed missing css * refactor: myAdsFloatingRateSwitchModal (#7173) * refactor: emailLinkVerifiedModal (#7118) * refactor: myAdsDeleteModal (#7024) * refactor: adExceedsDailyLimitModal (#7027) * farrah/78909/refactor FilterModal (#6906) * refactor filter modal * perf: added lazy loading * fix: added publicPath * farrah/78919/refactor OrderDetailsCancelModal (#7018) * refactor: order details cancel modal * fix: tests * Adrienne / BuySellModal and CancelAddPaymentMethodModal component with saved form state component (#7077) * saved draft * Refactored out cleanupFn argument in hideModal * fix: added modal form and saving state * fixed issues with mobile stacking modal * refactored out comments * refactor: remove cancel add payment method modal from my profile * removed add payment method modal in my profile * removed icons.js * removed icons.js * refactor: fix import path for modal form * refactor: fix import path for modal form * refactor: fix import path for modal form * chore: reverted change on cancel add payment method modal in my profile folder * chore: refactored code * chore: revert * Fix merge conflicts * Adrienne / Refactored Create Ad Add Payment Method Modal and Add Payment Method Error Modal (#7210) * chore: fixed issues with dropdown detecting as clicking outside modal * chore: updated branch with drafted branch * chore: added sycned branch changes * farrah/78918/refactor EmailVerificationModal (#7056) * refactor: emailVerificationModal * Refactored out EmailLinkVerifiedModal since that related modal card is merged to p2p-modal-manager * Refactored out EmailLinkVerifiedModal observables Co-authored-by: adrienne-deriv <103016120+adrienne-deriv@users.noreply.github.com> * farrah/78920/refactor OrderDetailsConfirmModal (#7038) * refactor: orderDetailsConfirmModal * refactor: onClick handler * chore: fix issues with build after merge conflicts Co-authored-by: adrienne-deriv <103016120+adrienne-deriv@users.noreply.github.com> * farrah/78927/refactor EditAdCancelModal (#7122) * refactor: editAdCancelModal * Refactored out CreateAdAddPaymentMethodModal since its already merged to p2p-modal-manager Co-authored-by: adrienne-deriv <103016120+adrienne-deriv@users.noreply.github.com> * farrah/78925/refactor CreateAdErrorModal (#7052) * refactor: createAdErrorModal * chore: fixed merge conflict issues Co-authored-by: adrienne-deriv <103016120+adrienne-deriv@users.noreply.github.com> * Adrienne / Rating modal and Recommended modal (#7132) * saved draft * refactor: added rating modal * added recommended modal * refactored code * refactored code * refactor: fixed issues with test * fix: added mock function for useModalManagerContext in app content test * refactored out comment for should_show_rating_modal * refactor: refactored out props for rating modal * chore: removed modal props on cleanup * chore: fixed issues with test * chore: refactor based on reviews * chore: refactor * Adrienne / Refactored Delete Payment Method Error modal and Cancel Edit Payment method modal (#7222) * saved draft * refactor: added delete payment method error modal * chore: fixed an issue where payment methods are not listed for sell ads * chore: fixed issue where back button does not trigger cancel edit pm modal * farrah/78916/refactor InvalidVerificationLinkModal (#7017) * refactor: invalid verification link modal * refactor: error message * chore: fixed merge conflicts Co-authored-by: adrienne-deriv <103016120+adrienne-deriv@users.noreply.github.com> * Adrienne / Error modal (#7283) * saved draft * refactor: added error modal * chore: reverted old changes modals folder * Adrienne / Currency Selector modal (#7279) * saved draft * refactor: added currency selector modal * chore: revert old changes modals folder * Adrienne / Block User Modal (#7276) * saved draft * refactor: added block user modal * chore: fix issues with test build * chore: removed comments * chore: updated comment * chore: fixed issues with running build * chore: fixed issues with running test * refactor: loading modal (#7006) Co-authored-by: adrienne-deriv <103016120+adrienne-deriv@users.noreply.github.com> * Adrienne / Rate Change Modal (#7266) * saved draft * refactor: added rate change modal * chore: changed isRateChanged function * chore: refactored hideModal with options * chore: reverted comments * chore: refactored naming options for hidemodal * Adrienne / Quick Add Modal and integrating new payment method dropdown component for buy ads in the modal (#7308) * saved draft * refactor: added quick add modal and new dropdown component * chore: refactored out unusesd files * chore: reverted merge conflict issues * chore: removed old merge conflicts * chore: fixed merge conflicts and added 2 new modals * chore: reverted refactor and used error modal instead * farrah/78906/refactor MarketRateChangeErrorModal (#7357) * refactor: market rate change error modal * refactor: code * refactor: unnecessary code * refactor: fixed issues with buy ad payment methods list Co-authored-by: adrienne-rio <adrienne@deriv.com> * fix: conflicts * fix: conflicts * Adrienne / Wrong popup message counterparty block user modal (#7459) * saved draft * fix: fixed an issue where incorrect block user modal message is shown in block user list * chore: removed old commits * Adrienne / Fix issue verification link modal showing twice (#7545) * saved draft * fix: verification modal now shows once * Adrienne / Add payment method not dismissed create ad (#7505) * saved draft * fix: create ad add payment method modal now closes when user adds a pm * chore: removed old commits * chore: added multiple arguments for iscurrentmodal * Adrienne / Market rate change popup not displayed (#7478) * saved draft * fix: fixed an issue where rate change modal is not shown when user changes to different currency * chore: removed old commits * Adrienne / Fixed issue with block user error modal (#7539) * saved draft * fix: reset error status * chore: removed old commits * fix: fixed an issue where the error modal is displayed twice * Adrienne / Fix bug in buy sell header and refactored code (#7624) * saved draft * refactor: refactored buy sell modal header * chore: removed comments * chore: applied code review refactors --------- Co-authored-by: adrienne-deriv <103016120+adrienne-deriv@users.noreply.github.com> Co-authored-by: adrienne-rio <adrienne@deriv.com> * Sergei / 86749 / delete some console errors when user watches onboarding (#7431) * fix: delete some console errors * fix: move spanButton to components package * fix: export TButtonProps * fix: put div putside p and use SpanButton instead of Button * fix: remove React.FC from SpanButton * fix: add optional operators '?' (#7481) * Thisyahlen/87700/no option to change currency for mf (#7520) * fix: exit traders hub * fix: remove is_currency_switcher_disabled_for_mf from the currency switcher dropdown * Thisyahlen/87555/switching to mf account upon login if no cr account for low risk (#7519) * fix: exit traders hub * fix: When login back to the account with has EU only the data for MF is showing * fix: exit from non-eu from traders hub, multipliers is still the active account * Aizad/87648/scroll-issue-onboarding-tradershub (#7615) * chore: change stylings add more padding below to how content in different screen size 📱 * fix: scroll issue on smaller screens * feat: testing sikit * fix: change onboarding sizing to fit mobile * fix: remove max-height on footer * fix: added more height to the body * fix: readjust body height (again😀) * thisyahlen/fix: Unable to add CR fiat account (#7680) * fix: Unable to add CR fiat account * fix: Unable to add CR fiat account * Sergei / 88771 / Australian VRTC accounts are not able to create real account (#7633) * fix: add button for adding account * fix: convert total assets for demo in account currency * fix: add check for restricted_countries for is_high function in client-store * Update packages/core/src/Stores/client-store.js Co-authored-by: Matin shafiei <matin@binary.com> * Update packages/core/src/Stores/client-store.js Co-authored-by: mahdiyeh-deriv <82078941+mahdiyeh-deriv@users.noreply.github.com> * chore: empty * fix: delete unnecessary '`' * refactor: change restricted_countries * chore: empty * fix: demo account total assets is always USD * fix: delete 'add or manage account' by checking 'filtered_remaining_real_accounts' length --------- Co-authored-by: Matin shafiei <matin@deriv.com> Co-authored-by: Matin shafiei <matin@binary.com> Co-authored-by: mahdiyeh-deriv <82078941+mahdiyeh-deriv@users.noreply.github.com> Co-authored-by: Jim Daniels Wasswa <104334373+jim-deriv@users.noreply.github.com> * Sergei / 88801 / Add button does not allow to add crypto accounts under Non EU Deriv Account when inside of Traders Hub (#7648) * fix: add crypto for EU * fix: change modal height and define crypto array --------- Co-authored-by: amina-deriv <84661147+amina-deriv@users.noreply.github.com> * Amina/fix: 89134_real_account_signup_fields_not_editable (#7688) * fix: 89134_real_account_signup_fields_not_editable * fix: real account editable fields * fix: security-issues: Client-side URL redirect (#7600) * fix: Incomplete URL substring sanitization (#7597) * thisyahlen/fix: add and manage account button logic in account switcher (#7657) * fix: add and manage account button logic in account switcher * fix: account switcher for low risk * fix: mockstore * fix: account switcher for the final time hopefully * redeploy: a * fix: deriv api versioning * fix: account switcher outside traders hub * fix: manage accounts text change * george / 89176 / transfer between cryptocurrency to other currencies is not possible (#7709) * fix: transfer form crypto to fiat * fix: display transferred amount in thousands * fix: display values with scientific notation --------- Co-authored-by: Jim Daniels Wasswa <104334373+jim-deriv@users.noreply.github.com> * yashim/fix: enable strings extraction (#7717) * fix: translation files * fix: extract translations * chore: alphabetical order * chore: sync translation * fix: convert demo CFD currency to vrtc currency (#7719) * fix: min and max dispaly value (#7714) Co-authored-by: Nijil Nirmal <62882794+nijil-deriv@users.noreply.github.com> * translations: 📚 sync translations with crowdin (#7722) Co-authored-by: DerivFE <80095553+DerivFE@users.noreply.github.com> * thisyahlen/fix: account switcher for mf (#7723) * fix: account switcher for mf * fix: undefined loginid * fix: add real account modal height * chore: removed unused props * chore: remove unused v2 * translations: 📚 sync translations with crowdin (#7725) Co-authored-by: DerivFE <80095553+DerivFE@users.noreply.github.com> * translations: 📚 sync translations with crowdin (#7730) Co-authored-by: DerivFE <80095553+DerivFE@users.noreply.github.com> * fix: trade type highlight changed to All + Rise Fall not highlighted fix (#7700) Co-authored-by: Jim Daniels Wasswa <104334373+jim-deriv@users.noreply.github.com> * fix: barrel rolls on loader (#7672) Co-authored-by: Jim Daniels Wasswa <104334373+jim-deriv@users.noreply.github.com> * fix: 🐛 fixes the truncated cookie banner for non-en languages (#7669) * fix: 🐛 fixes the truncateed cookie banner for non-en langs * fix: 🐛 fixes the text out of button bug in cookie banner --------- Co-authored-by: Jim Daniels Wasswa <104334373+jim-deriv@users.noreply.github.com> * fix: localize (#7720) Co-authored-by: Jim Daniels Wasswa <104334373+jim-deriv@users.noreply.github.com> * Sergei / 89437 / Traders Hub: Total assets showing wrong amount when clients having multiple currency (#7728) * fix: ad exchange rate for total assets in traders hub * refactor: change types for setExchangeRate --------- Co-authored-by: Jim Daniels Wasswa <104334373+jim-deriv@users.noreply.github.com> * fix: evgeniy/ 88007/ enable paste in idv information (#7647) * fix: evgeniy/ 88007/ enable paste in idv information * refactor: prevent event while empty data pasting * refactor: using default validation error message * refactor: reusing prevent func * refactor: typo name fix, function passing shortage * refactor: useToggleValidation fix --------- Co-authored-by: “yauheni-kryzhyk-deriv” <“yauheni@deriv.me”> Co-authored-by: Jim Daniels Wasswa <104334373+jim-deriv@users.noreply.github.com> * translations: 📚 sync translations with crowdin (#7738) Co-authored-by: DerivFE <80095553+DerivFE@users.noreply.github.com> * translations: 📚 sync translations with crowdin (#7739) Co-authored-by: DerivFE <80095553+DerivFE@users.noreply.github.com> * translations: 📚 sync translations with crowdin (#7747) Co-authored-by: DerivFE <80095553+DerivFE@users.noreply.github.com> * translations: 📚 sync translations with crowdin (#7748) Co-authored-by: DerivFE <80095553+DerivFE@users.noreply.github.com> * translations: 📚 sync translations with crowdin (#7749) Co-authored-by: yashim-deriv <yashim@deriv.com> * fix: missing localise/improper use of localise (#7750) * Merge branch 'develop' of github.com:binary-com/deriv-app into niloo/88920/ts-migration-parent * Farzin/85955/Extract `replaceCashierMenuOnclick` method from cashier `GeneralStore` to reusable hook in `@deriv/hooks` (#7434) * Shayan/52349/react17 migration (#6908) * refactor: react version is upgraded to version 17 * fix: fixed typo * fix: changed declaration file location * fix: temporarily commented our two test cases that are failing * fix: fixed react-content-loader props * fix: fixed some bugs * fix: fixed z-index issue for popover in DBot page * fix: fixed popover position issue in DBot page * chore: an small change on how to turn string to array * fix: merge upstream develop into my branch and resolved conflicts * fix: resolved pr comments * fix: removed rc-drawer and refactored mobile drawer * fix: fixed test cases * fix: resolved pr comments * fix: resolved pr comment * fix: fixed typo * fix: resolved pr comments * fix: fixed slide-in component bug * fix: resolved pr comments * fix: resolved pr comments * fix: removed unnecessary lines * fix: resolved pr comments * Update packages/account/src/Components/personal-details/__tests__/personal-details.spec.js Co-authored-by: Niloofar Sadeghi <93518187+niloo-fs@users.noreply.github.com> * Update packages/account/src/Components/personal-details/__tests__/personal-details.spec.js Co-authored-by: Niloofar Sadeghi <93518187+niloo-fs@users.noreply.github.com> * Update packages/account/src/Components/personal-details/personal-details.jsx Co-authored-by: Niloofar Sadeghi <93518187+niloo-fs@users.noreply.github.com> * fix: fixed mt5 modal not appear on screen when clicking on trade button * fix: fixed Bug #84787 Co-authored-by: Shayan Khaleghparast <100833613+iman-fs@users.noreply.github.com> Co-authored-by: Niloofar Sadeghi <93518187+niloo-fs@users.noreply.github.com> * fix: add optional chaining in getMinDuration function (#7344) * fix: 🐛 resolved issue with trade. odal (#7291) * Revert "fix: 🐛 resolved issue with trade. odal (#7291)" (#7364) This reverts commit b6f7e4c. * feat(core): ✨ add `@deriv/hooks` and `@deriv/stores` to `@deriv/core` * refactor(core): 🔥 remove `ToggleMenuDrawer` prop drilling and use `useStore` hook * refactor(core): 🔥 remove dead props * refactor(core): 🔥 remove unnecessary ref in `ToggleMenuDrawer` * refactor(core): 🔥 remove `react-import-loader` from `@deriv/core` * refactor(core): 🔥 remove `platform_switcher` prop from `ToggleMenuDrawer` * Farzin/85054/Call `resetWithrawForm` on `CryptoWithdrawForm` component `onunmount` (#7331) * fix(cashier): 🐛 call `resetWithrawForm` on `CryptoWithdrawForm` component `onunmount` * test(cashier): ✅ fix failing test Co-authored-by: Farzin Mirzaie <farzin@deriv.com> * Niloofar Sadeghi / Task - Refactor tests in the language.spec.js file (#7325) * refactor: language tests * fix: typo Co-authored-by: Niloofar Sadeghi <niloofar.sadeghi@firstsource.tech> * refactor: proposal tests (#7327) Co-authored-by: Niloofar Sadeghi <niloofar.sadeghi@firstsource.tech> * Niloofar Sadeghi / Task - Refactor tests in the error.spec.js file (#7324) * refactor: errors validator tests * fix: typo Co-authored-by: Niloofar Sadeghi <niloofar.sadeghi@firstsource.tech> * Niloofar Sadeghi / Task - Refactor tests in the binary-link.spec.tsx file (#7288) * refactor: binary-link tests * refactor: improve testids namings Co-authored-by: Niloofar Sadeghi <niloofar.sadeghi@firstsource.tech> * refactor: money tests (#7353) * refactor: toggle-positions tests (#7287) Co-authored-by: Niloofar Sadeghi <niloofar.sadeghi@firstsource.tech> * refactor: toggle-button tests (#7328) Co-authored-by: Niloofar Sadeghi <niloofar.sadeghi@firstsource.tech> * Niloofar Sadeghi / Task - Refactor tests in the toggle-button-group.spec.tsx file (#7330) * refactor: toggle-button-group tests * fix: test issue Co-authored-by: Niloofar Sadeghi <niloofar.sadeghi@firstsource.tech> * refactor: open-positions-table tests (#7374) * Niloofar Sadeghi / Task - Refactor tests in the marker-spot-label.spec.tsx file (#7355) * refactor: remove extra files from reports * refactor: marker-spot-label tests * Niloofar Sadeghi / Task - Refactor tests in the binary-link.spec.tsx file (#7286) * refactor: binary-link tests * test: added more tests Co-authored-by: Niloofar Sadeghi <niloofar.sadeghi@firstsource.tech> * Niloofar Sadeghi / Task - Refactor tests in the contract-type-dialog.spec.tsx file (#7285) * refactor: contract-type-dialog tests * test: added more tests * fix: circle/ci issue Co-authored-by: Niloofar Sadeghi <niloofar.sadeghi@firstsource.tech> * Niloofar Sadeghi / Task - Refactor tests in the platform-dropdown.spec.tsx file (#7282) * refactor: platform-dropdown tests * refactor: improve testids namings Co-authored-by: Niloofar Sadeghi <niloofar.sadeghi@firstsource.tech> * fix(core): 📝 resolve conflicts * fix(core): 📝 resolve conflicts * feat(hooks): ✨ add `useP2PNotificationCount` hook * feat(hooks): ✨ add `useHasSetCurrency` and `useHasActiveRealAccount` hooks * refactor(core): ♻️ refactor `MenuLinks` component * refactor(cashier): 🔥 remove `CashierNotifications` component * refactor(core): 🔥 remove `MenuStore` store * refactor(cashier): 🔥 remove `attachCashierToMenu` and `replaceCashierMenuOnclick` methods * fix(stores): 💚 add missing default value to `mockStore` --------- Co-authored-by: Shayan Khaleghparast <100833613+shayan-deriv@users.noreply.github.com> Co-authored-by: Shayan Khaleghparast <100833613+iman-fs@users.noreply.github.com> Co-authored-by: Niloofar Sadeghi <93518187+niloo-fs@users.noreply.github.com> Co-authored-by: kate-deriv <121025168+kate-deriv@users.noreply.github.com> Co-authored-by: Likhith Kolayari <98398322+likhith-deriv@users.noreply.github.com> Co-authored-by: Farrah Mae Ochoa <farrah@deriv.com> Co-authored-by: Matin shafiei <matin@deriv.com> Co-authored-by: Farzin Mirzaie <farzin@deriv.com> Co-authored-by: Niloofar Sadeghi <93518187+niloofar-deriv@users.noreply.github.com> Co-authored-by: Niloofar Sadeghi <niloofar.sadeghi@firstsource.tech> * translations: 📚 sync translations with crowdin (#7751) Co-authored-by: yashim-deriv <yashim@deriv.com> * yashim/fix: translations (#7754) * translations: 📚 sync translations with crowdin (#7755) Co-authored-by: yashim-deriv <yashim@deriv.com> * fix: onboarding translations (#7757) * yashim/fix: onboarding carousel translations (#7758) * yashim/fix: translation in tour-steps-config (#7761) * translations: 📚 sync translations with crowdin (#7762) Co-authored-by: yashimwong <yashimwong@gmail.com> * translations: 📚 sync translations with crowdin (#7763) Co-authored-by: yashim-deriv <yashim@deriv.com> * carol/fix: translation issue (#7764) * translations: 📚 sync translations with crowdin (#7766) Co-authored-by: DerivFE <80095553+DerivFE@users.noreply.github.com> * translations: 📚 sync translations with crowdin (#7767) Co-authored-by: yashim-deriv <yashim@deriv.com> * yashim/fix: update extraction regex (#7765) * fix: update extraction regex * fix: update test for new extraction * yashim/fix: improper formatted strings (#7769) * fix: improper formatted strings * translations: 📚 sync translations with crowdin (#7770) Co-authored-by: yashim-deriv <yashim@deriv.com> * translations: 📚 sync translations with crowdin (#7771) Co-authored-by: DerivFE <80095553+DerivFE@users.noreply.github.com> * Farzin/87070/Extract `is_account_transfer_visible` method from cashier `AccountTransferStore` to reusable hook (#7445) * feat(hooks): ✨ add `useAccountTransferVisible` and `useHasMaltaInvestAccount` hooks * refactor(core): ♻️ replace `is_account_transfer_visible` with `useAccountTransferVisible` * refactor(cashier): ♻️ replace `is_account_transfer_visible` with `useAccountTransferVisible` * refactor(cashier): 🔥 remove `is_account_transfer_visible` method * test(cashier): ✅ fix failing test * fix(stores): 💚 add missing default value to `mockStore` --------- Co-authored-by: Farzin Mirzaie <farzin@deriv.com> * Farzin/88636/Debounce `p2p_order_list` call (#7613) * perf(p2p): ⚡ debounce `p2p_order_list` call and check if p2p is available before making the call * fix(core): 🐛 use `WS` from services * fix(core): 🐛 add timeout before fetching `p2p_order_list` * fix(core): 🐛 fix cannot read properties of undefined `authorized` * fix(core): 🐛 fix cannot read properties of undefined `authorized` * fix(core): 🐛 fix cannot read properties of undefined `authorized` * fix(core): 🐛 fix cannot read properties of undefined `authorized` --------- Co-authored-by: Farzin Mirzaie <farzin@deriv.com> * fix: shows cancel dialog on selecting payment method (#7429) * refactor: move search box to components package (#7664) * henry/89211/fix: pass is_eu_country flag to SmartChart (#7712) * fix: pass is_eu_country flag to SmartChart * fix: bala change deploy command * fix: add server maintenance notice (#7498) Co-authored-by: Carol Sachdeva <58209918+carol-deriv@users.noreply.github.com> * likhith/feat:incorporated string normalization to match non english characters (#7649) * feat: ⚡ incorporated string normalization to match non english character * fix: ensuring non english character match * feat: resolved import issue * feat: incorporated helper function * feat: added testcases for helper function * feat: incorporated helper function to all case * feat: 🎨 refactored code * feat: code refactor --------- Co-authored-by: Matin shafiei <matin@deriv.com> Co-authored-by: Carol Sachdeva <58209918+carol-deriv@users.noreply.github.com> * Aizad/89056/deriv go text change (#7701) * chore: update packages * chore: change deriv go name * fix: open new tab when click trade * fix: fix codecov * fix: updated packages one more * fix: circleci failing * fix: change DerivGO branding on onboarding page aswell * fix: small changes --------- Co-authored-by: Carol Sachdeva <58209918+carol-deriv@users.noreply.github.com> * Likhith/88162/sub section navigation for trading assessment (#7685) * feat: 💄 added subsection indicator for FormStepper * feat: 💄 incorporated form-progress for mobile and Desktop * feat: ✨ integrated changes to exisiting user TA questions * feat: 🎨 update type of uistore * feat: added changes to mock store * feat: ♻️ incorporated review comments * feat: ♻️ incorporated review comments * feat: ♻️ incorporated review comments * feat: ✨ incorporated form wobbling * feat: 🐛 incorporated designs as specified in Figma * fix: 🐛 content not translated to selected languages * feat: reverted text changes * feat: modified content as per figma * feat: 🎨 content change * feat: added missing fullstop * feat: content mismatch fix --------- Co-authored-by: Matin shafiei <matin@deriv.com> Co-authored-by: Carol Sachdeva <58209918+carol-deriv@users.noreply.github.com> * fix: policy page reload issue (#7679) Co-authored-by: Carol Sachdeva <58209918+carol-deriv@users.noreply.github.com> * fix: ✏️ fixes text content & size in Account Limits settings (#7708) * fix: ✏️ fixes text content & size in Account Limits settings * fix: ✏️ code review changes - fixes text content & size in Account Limits settings --------- Co-authored-by: Carol Sachdeva <58209918+carol-deriv@users.noreply.github.com> * Kate/88725/No quick access to trade type description (#7667) * refactor: make info icon always visible * refactor: add info icon for mobile * fix: add arrow and trade type to the trade type info in mobile * fix: add scss for mobile scrollbar * refactor: remove important from css * refactor: change to positive condition * feat: add style for button responsive in trade type info * chore: empty commit to trigger codcov --------- Co-authored-by: Carol Sachdeva <58209918+carol-deriv@users.noreply.github.com> * translations: 📚 sync translations with crowdin (#7787) Co-authored-by: DerivFE <80095553+DerivFE@users.noreply.github.com> Co-authored-by: Carol Sachdeva <58209918+carol-deriv@users.noreply.github.com> * fix: add styles in cfd-dashboard (#7791) * translations: 📚 sync translations with crowdin (#7795) Co-authored-by: DerivFE <80095553+DerivFE@users.noreply.github.com> * Jim/85458/allow poo submission on valid data (#7592) * feat: enable button when valid information is provided * chore: add check for status * refactor: combine conditionals * chore: seperate conditionals * chore: replace nullish coalescing with or operator * chore: update based on reviews * chore: refactor based on code reviews * fix: dependabot alerts (#7608) * Ameerul /Bug 87254 Scrolling is not working when reduce the screen size (#7457) * chore: fixed scrolling issue on smaller screens * chore: fixed height of table to show 5 users at a time * refactor: ♻️ migrated code to TSX * feat: ♻️ incorporated review comments * fix: build fix * fix: react_virtualized_types * fix: build fix * chore: make prop types optional * fix: sonarcloud issue fix, test add * fix: test failing fix * fix: remove comments * fix: sonar bug * chore: remove noClick check in the component * fix: review changes * fix: build fix * refactor: accountclosed ts migration * refactor: evgeniy/88400/ accountlimit ts migration * fix: import error * refactor: review changes * refactor: types replaced * refactor: pushState replaced with history.push * refactor: security section api token ts migration * refactor: routes root usage added * refactor: evgeniy/88388/modules page404 ts migration * fix: types * feat: 🎨 migrated to TS * fix: 🐛 resolved TS type bugs * fix: sonar error * feat: incorporated changes to Trading assessment * feat: merging TS changes * fix: circle/ci errors * fix: circle/ci errors * build: trigger build * feat: migrated connect to observe * feat: 🎨 migrated component to TS * feat: migrated index files * chore: date picker file migration from to * feat: 🐛 resolved failing TS issues * fix: ♻️ incorporated review comments * feat: incorporated review comments * fix: sonar issue * chore: date-picker-native ts migration * chore: date-picker-input ts migration * chore: `date-picker-calender` ts migration * chore: `date-picker-native` ts migration * chore: convert `index.js` to `index.ts` of `date-picker` module * refactor: migrate date picker component to ts * fix: remove console error related to input props * fix: naming convention for parameters * refactor: migrate date-of-birth-picker to typescript * fix: typo in param of `onSelect` function Co-authored-by: Maryia <103177211+maryia-deriv@users.noreply.github.com> * refactor: use date picker type in `date-of-birth` picker * refactor: resolve review comments * fix: undo the script change * chore: change target element type to `HTMLDivElement` Co-authored-by: Maryia <103177211+maryia-deriv@users.noreply.github.com> * refactor: move expression directly to prop * fix: pass `readOnly` prop to date of birth picker * refactor: put props spread down inside date of birth component * refactor: address `as` changes and null checks on date-picker module * fix: check native date picker null value properly * refactor: change position of prop spreading in `date-picker` component * refactor: omit placement and style from props * refactor: omit refs from date picker props * refactor: TS migration of connected apps folder * fix: circleCI errors * fix: vercel errors * refactor: infinite datalist component ts migration * fix: circle/ci issue * refactor: to fix circle ci issues * fix: circle/ci issues * fix: circle/ci issue * fix: review comments * fix: review comments * fix: review comments * fix: sonarcloud issue * fix: sonarcloud issue * fix: review comments * fix: review comments * fix: build issue * fix: trading assessment issue * build: trigger build * fix: 🐛 removed useStore * fix: 🐛 file dropzone migration fix * fix: 🐛 ts lint issues * fix: number pad to set take profit for accumulator doesn't work as expected in responsive * fix: build errors * fix: build errors * fix: circle/ci issue --------- Co-authored-by: amina-deriv <84661147+amina-deriv@users.noreply.github.com> Co-authored-by: mitra-deriv <64970259+mitra-deriv@users.noreply.github.com> Co-authored-by: Carol Sachdeva <58209918+carol-deriv@users.noreply.github.com> Co-authored-by: Shaheer <122449658+shaheer-deriv@users.noreply.github.com> Co-authored-by: Aizad Ridzo <103104395+aizad-deriv@users.noreply.github.com> Co-authored-by: “yauheni-kryzhyk-deriv” <“yauheni@deriv.me”> Co-authored-by: Farrah Mae Ochoa <82315152+farrah-deriv@users.noreply.github.com> Co-authored-by: adrienne-deriv <103016120+adrienne-deriv@users.noreply.github.com> Co-authored-by: adrienne-rio <adrienne@deriv.com> Co-authored-by: Sergei Baranovski <120570511+sergei-deriv@users.noreply.github.com> Co-authored-by: thisyahlen <104053934+thisyahlen-deriv@users.noreply.github.com> Co-authored-by: Matin shafiei <matin@deriv.com> Co-authored-by: Matin shafiei <matin@binary.com> Co-authored-by: mahdiyeh-deriv <82078941+mahdiyeh-deriv@users.noreply.github.com> Co-authored-by: Jim Daniels Wasswa <104334373+jim-deriv@users.noreply.github.com> Co-authored-by: George Usynin <103181646+heorhi-deriv@users.noreply.github.com> Co-authored-by: Yashim Wong <yashim@regentmarkets.com> Co-authored-by: Nijil Nirmal <62882794+nijil-deriv@users.noreply.github.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: DerivFE <80095553+DerivFE@users.noreply.github.com> Co-authored-by: Muhammad Hamza <120543468+hamza-deriv@users.noreply.github.com> Co-authored-by: yauheni-deriv <103182683+yauheni-deriv@users.noreply.github.com> Co-authored-by: yashim-deriv <yashim@deriv.com> Co-authored-by: Niloofar Sadeghi <niloofar.sadeghi@re-work.dev> Co-authored-by: Farzin Mirzaie <72082844+farzin-deriv@users.noreply.github.com> Co-authored-by: Shayan Khaleghparast <100833613+shayan-deriv@users.noreply.github.com> Co-authored-by: Shayan Khaleghparast <100833613+iman-fs@users.noreply.github.com> Co-authored-by: Niloofar Sadeghi <93518187+niloo-fs@users.noreply.github.com> Co-authored-by: kate-deriv <121025168+kate-deriv@users.noreply.github.com> Co-authored-by: Likhith Kolayari <98398322+likhith-deriv@users.noreply.github.com> Co-authored-by: Farrah Mae Ochoa <farrah@deriv.com> Co-authored-by: Farzin Mirzaie <farzin@deriv.com> Co-authored-by: Niloofar Sadeghi <niloofar.sadeghi@firstsource.tech> Co-authored-by: yashimwong <yashimwong@gmail.com> Co-authored-by: nada-deriv <122768621+nada-deriv@users.noreply.github.com> Co-authored-by: henry-deriv <118344354+henry-deriv@users.noreply.github.com> Co-authored-by: ameerul-deriv <103412909+ameerul-deriv@users.noreply.github.com> Co-authored-by: Likhith Kolayari <likhith@regentmarkets.com> Co-authored-by: sanjam chhatwal <sanjam@deriv.com> Co-authored-by: Jim Daniels Wasswa <jim@deriv.com> Co-authored-by: Taysuisin <suisin@regentmarkets.com> Co-authored-by: sanjam-deriv <99465624+sanjam-deriv@users.noreply.github.com> Co-authored-by: amir ali <amir.ali@regentmarkets.com> Co-authored-by: amir-deriv <129206554+amir-deriv@users.noreply.github.com> Co-authored-by: Maryia <103177211+maryia-deriv@users.noreply.github.com> Co-authored-by: Henry Hein <henry@regentmarkets.com> Co-authored-by: yaswanth-deriv <121096908+yaswanth-deriv@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
Please include a summary of the change and which issue is fixed below:
When you need to add unit test
When you need to add integration test
Test coverage checklist (for reviewer)
Type of change