Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Niloofar Sadeghi | components and shared ts migration [parent branch] #7307

Merged

Conversation

niloofar-deriv
Copy link
Contributor

@niloofar-deriv niloofar-deriv commented Jan 5, 2023

Changes:

Please include a summary of the change and which issue is fixed below:

  • ...

When you need to add unit test

  • If this change disrupt current flow
  • If this change is adding new flow

When you need to add integration test

  • If components from external libraries are being used to define the flow, e.g. @deriv/components
  • If it relies on a very specific set of props with no default behavior for the current component.

Test coverage checklist (for reviewer)

  • Ensure utility / function has a test case
  • Ensure all the tests are passing

Type of change

  • Bug fix
  • New feature
  • Update feature
  • Refactor code
  • Translation to code
  • Translation to crowdin
  • Script configuration
  • Improve performance
  • Style only
  • Dependency update
  • Documentation update
  • Release

@vercel
Copy link

vercel bot commented Jan 5, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
deriv-app ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 2, 2023 5:49am

@niloofar-deriv niloofar-deriv changed the title Niloofar Sadeghi | components and shared ts migration parent card | FE Core Sprint (19 Dec - 08 Jan) Niloofar Sadeghi | components and shared ts migration [parent branch] Jan 5, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Jan 5, 2023

A production App ID was automatically generated for this PR. (log)

Click here to copy & paste above information.
- **PR**: [https://github.com/binary-com/deriv-app/pull/7307](https://github.com/binary-com/deriv-app/pull/7307)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-niloofar-deriv-niloo-84471ts-migratio-17dc8c.binary.sx?qa_server=red.binaryws.com&app_id=23811
    - **Original**: https://deriv-app-git-fork-niloofar-deriv-niloo-84471ts-migratio-17dc8c.binary.sx
- **App ID**: `23811`

@codecov-commenter
Copy link

codecov-commenter commented Jan 5, 2023

Codecov Report

Merging #7307 (0995b74) into master (cb4288a) will increase coverage by 0.00%.
The diff coverage is 23.97%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@           Coverage Diff           @@
##           master    #7307   +/-   ##
=======================================
  Coverage   20.89%   20.89%           
=======================================
  Files        1555     1552    -3     
  Lines       36067    36052   -15     
  Branches     7059     7078   +19     
=======================================
- Hits         7536     7534    -2     
+ Misses      27790    27775   -15     
- Partials      741      743    +2     
Impacted Files Coverage Δ
...mponents/account-limits/account-limits-overlay.tsx 100.00% <ø> (ø)
...count-limits/account-limits-turnover-limit-row.tsx 100.00% <ø> (ø)
...omponents/currency-selector/radio-button-group.tsx 100.00% <ø> (ø)
...-doc-submit-on-signup/idv-doc-submit-on-signup.tsx 0.00% <0.00%> (ø)
...ents/poi/poi-form-on-signup/poi-form-on-signup.tsx 0.00% <0.00%> (ø)
...mponents/self-exclusion/self-exclusion-article.tsx 100.00% <ø> (ø)
...Components/self-exclusion/self-exclusion-modal.tsx 100.00% <ø> (ø)
packages/account/src/Containers/account.jsx 0.00% <ø> (ø)
...Sections/Security/AccountLimits/account-limits.jsx 0.00% <ø> (ø)
...src/Sections/Security/Passwords/deriv-password.jsx 0.00% <ø> (ø)
... and 117 more

suisin-deriv and others added 5 commits January 11, 2023 15:10
…-deriv/deriv-app into suisin/74166/ts_migration_reset_trading_password_modal
…-deriv/deriv-app into suisin/74174/ts_migration_self_exclusion_article_content
…lf_exclusion_article_content

Suisin/74174/ts migration self exclusion article content
@niloofar-deriv niloofar-deriv force-pushed the niloo/84471/ts-migration-parent branch from 3918023 to 5fc7da0 Compare April 20, 2023 06:44
@boring-cyborg boring-cyborg bot added the Docs label Apr 20, 2023
@niloofar-deriv niloofar-deriv force-pushed the niloo/84471/ts-migration-parent branch 2 times, most recently from 3918023 to a1f789b Compare April 20, 2023 06:51
Copy link
Member

@ali-hosseini-deriv ali-hosseini-deriv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sonarcloud
Copy link

sonarcloud bot commented May 2, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 41 Code Smells

No Coverage information No Coverage information
2.3% 2.3% Duplication

@github-actions
Copy link
Contributor

github-actions bot commented May 2, 2023

Generating Lighthouse report...

@sandeep-deriv sandeep-deriv merged commit 84f2afa into binary-com:master May 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.