Maryia/Kate/DTRA-19/task-add-turbos #7514

maryia-deriv · 2023-02-03T09:13:50Z

Changes:

Please include a summary of the change and which issue is fixed below:

To add Turbos trade type to Options

When you need to add unit test

If this change disrupt current flow
If this change is adding new flow

When you need to add integration test

If components from external libraries are being used to define the flow, e.g. @deriv/components
If it relies on a very specific set of props with no default behavior for the current component.

Test coverage checklist (for reviewer)

Ensure utility / function has a test case
Ensure all the tests are passing

Type of change

vercel · 2023-02-03T09:13:54Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
deriv-app	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Aug 7, 2023 1:16pm

github-actions · 2023-02-03T09:25:58Z

A production App ID was automatically generated for this PR. (log)

PR: Maryia/Kate/DTRA-19/task-add-turbos #7514
URLs:
- w/ App ID + Server: https://deriv-app-git-fork-maryia-deriv-maryia-87354task-add-turbos.binary.sx?qa_server=red.binaryws.com&app_id=32112
- Original: https://deriv-app-git-fork-maryia-deriv-maryia-87354task-add-turbos.binary.sx
App ID: 32112

Click here to copy & paste above information.

- **PR**: [https://github.com/binary-com/deriv-app/pull/7514](https://github.com/binary-com/deriv-app/pull/7514)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-maryia-deriv-maryia-87354task-add-turbos.binary.sx?qa_server=red.binaryws.com&app_id=32112
    - **Original**: https://deriv-app-git-fork-maryia-deriv-maryia-87354task-add-turbos.binary.sx
- **App ID**: `32112`

github-actions · 2023-02-03T09:26:21Z

🚨 Lighthouse report for the changes in this PR:

Category	Score
🔺 Performance	20
🟧 Accessibility	75
🟢 Best practices	92
🟧 SEO	85
🟢 PWA	90

Lighthouse ran with https://deriv-app-git-fork-maryia-deriv-maryia-87354task-add-turbos.binary.sx/

… button (#75)

codecov-commenter · 2023-02-05T15:11:43Z

Codecov Report

Merging #7514 (9ba9b25) into master (d5c38a0) will increase coverage by 0.00%.
Report is 170 commits behind head on master.
The diff coverage is n/a.

❗ Current head 9ba9b25 differs from pull request most recent head 9185ac7. Consider uploading reports for the commit 9185ac7 to get more accurate results

@@          Coverage Diff           @@
##           master   #7514   +/-   ##
======================================
  Coverage    0.05%   0.05%           
======================================
  Files         117     117           
  Lines        3425    3422    -3     
  Branches      893     891    -2     
======================================
  Hits            2       2           
+ Misses       3423    3420    -3

see 1 file with indirect coverage changes

* feat: add turbos to trade types * feat: add icon for description * refactor: separate trade types description, change svg and make info icons being visible for mob * fix: replace icons name to proper define * fix: correct spelling for turbos icon

…77) * refactor: add existing take profit component for turbos * refactor: unite condition for riskmanagmentinfo component for multiplier and turbos

* feat: Barrier Line Colors depend upon the contract type * chore: Reafctor Barrier Line Colors depend upon the contract type v1.2 * chore: Reafctor Barrier Line Colors depend upon the contract type v1.3

* feat: Dynamics Buttons Desktop + Responsive * chore: refactor the code * chore: refactor chnages v1.2 * chore: refactor css * chore: refactor css v1.3 * chore: removed the function and moved to helpers * chore: removed the function and moved to helpers v1.1 * chore: removed the function and moved to helpers renamed v1.2

… Trade params (#78) * feat: create turbos info componenet, based on existing multiplier component * refactor: add duration and stake for turbos mobile based on existing component * refactor: unite two similar text components in one function, correct spelling in store * refactor: remove fuction from component and make it pure, change px to rem in styles * refactor: turn function into component and clean up props values * refactor: add todo comment

…354/task-add-turbos

…83) * chore: style changes v1.0 * fix: styling animation * fix: button styling responsive * fix: button styling responsive v1.3

…er and Contract Details (#82) * feat: add proper type name for turbos in recent positions * refactor: extend getcontracttypedisplay function, do decomposing * refactor: config files for recent positions card * feat: add recent position card for desktop and plug in min and max stake * feat: add card for recent positions for mobile * fix: delete extra properties * refactor: add react fragment and shrink arrow function * fix: spelling in trade type * feat: add turbos contract card for contract details page for desktop * feat: add turbos card for details page mobile * refactor: replace wrong contracts type to turbos * refactor: add nested styles, rename variables * refactor: shrink styles for contract card * fix: status timer style * refactor: cleared classname * fix: change px to rem

henry-deriv · 2023-07-31T01:33:41Z

packages/reports/src/Constants/data-table-constants.tsx

-import { ITransformer } from 'mobx-utils';
+import type { TRootStore } from 'Stores/index';
+
+type TPortfolioStore = TRootStore['portfolio'];


can we update these to Returntype<typeof useStore>['portfolio'] for consistency?

…354/task-add-turbos

sonarcloud · 2023-08-07T13:06:30Z

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
8 Code Smells

No Coverage information
0.1% Duplication

feat: connect turbos contracts_for & take barrier_choices

ef24949

boring-cyborg bot added Components Shared Trader labels Feb 3, 2023

Merge branch 'master' into maryia/87354/task-add-turbos

5e5dbfe

chore: add barrier count to turbos config

fe7a0e4

vercel bot deployed to Preview February 3, 2023 09:48 View deployment

chore: connected proposal API + added Stake header + updated purchase…

bf3d299

… button (#75)

boring-cyborg bot added the Core label Feb 5, 2023

vercel bot deployed to Preview February 5, 2023 15:01 View deployment

vercel bot deployed to Preview February 6, 2023 12:28 View deployment

Kate/87510/add existing Take Profit component to Turbos Trade params (#…

28104c1

…77) * refactor: add existing take profit component for turbos * refactor: unite condition for riskmanagmentinfo component for multiplier and turbos

vercel bot deployed to Preview February 6, 2023 16:00 View deployment

fix: maryia/hide info from purchase button correctly

55995ce

vercel bot deployed to Preview February 6, 2023 17:08 View deployment

hamza/ feat: Barrier Line Colors depend upon the contract type (#80)

4d5402c

* feat: Barrier Line Colors depend upon the contract type * chore: Reafctor Barrier Line Colors depend upon the contract type v1.2 * chore: Reafctor Barrier Line Colors depend upon the contract type v1.3

vercel bot deployed to Preview February 8, 2023 07:55 View deployment

vercel bot deployed to Preview February 8, 2023 09:13 View deployment

vercel bot deployed to Preview February 8, 2023 09:29 View deployment

maryia-deriv and others added 2 commits February 14, 2023 07:39

Merge branch master of github.com:binary-com/deriv-app into maryia/87…

e8fa9b5

…354/task-add-turbos

hamza/88083/To Adjust the purchase button styles including animation (#…

935c243

…83) * chore: style changes v1.0 * fix: styling animation * fix: button styling responsive * fix: button styling responsive v1.3

vercel bot deployed to Preview February 14, 2023 05:03 View deployment

Merge branch 'master' into maryia/87354/task-add-turbos

acfa962

vercel bot deployed to Preview July 25, 2023 07:20 View deployment

henry-deriv reviewed Jul 31, 2023

View reviewed changes

Merge branch master of github.com:binary-com/deriv-app into maryia/87…

0e7727b

…354/task-add-turbos

maryia-deriv dismissed stale reviews from jim-deriv, matin-deriv, and balakrishna-deriv via 0e7727b August 1, 2023 07:34

vercel bot deployed to Preview August 1, 2023 07:57 View deployment

maryia-deriv added 2 commits August 1, 2023 14:18

refactor: type

baaf7c3

build: empty commit

7e58616

vercel bot deployed to Preview August 1, 2023 12:18 View deployment

kate-deriv approved these changes Aug 1, 2023

View reviewed changes

jim-deriv previously approved these changes Aug 2, 2023

View reviewed changes

Merge branch master of github.com:binary-com/deriv-app into maryia/87…

4d5b6f3

…354/task-add-turbos

maryia-deriv dismissed jim-deriv’s stale review via 4d5b6f3 August 7, 2023 09:23

maryia-deriv requested review from mahdiyeh-deriv and ali-hosseini-deriv as code owners August 7, 2023 09:23

kate-deriv approved these changes Aug 7, 2023

View reviewed changes

vercel bot deployed to Preview August 7, 2023 09:43 View deployment

Merge branch master of github.com:binary-com/deriv-app into maryia/87…

26ca75e

…354/task-add-turbos

kate-deriv approved these changes Aug 7, 2023

View reviewed changes

vercel bot deployed to Preview August 7, 2023 10:27 View deployment

Merge branch master of github.com:binary-com/deriv-app into maryia/87…

356f891

…354/task-add-turbos

vercel bot deployed to Preview August 7, 2023 11:57 View deployment

Merge branch master of github.com:binary-com/deriv-app into maryia/87…

9185ac7

…354/task-add-turbos

vercel bot deployed to Preview August 7, 2023 13:16 View deployment

jim-deriv approved these changes Aug 8, 2023

View reviewed changes

matin-deriv approved these changes Aug 8, 2023

View reviewed changes

sandeep-deriv merged commit 7c36cd5 into binary-com:master Aug 9, 2023
2 of 3 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Maryia/Kate/DTRA-19/task-add-turbos #7514

Maryia/Kate/DTRA-19/task-add-turbos #7514

maryia-deriv commented Feb 3, 2023 •

edited

Loading

vercel bot commented Feb 3, 2023 •

edited

Loading

github-actions bot commented Feb 3, 2023 •

edited

Loading

github-actions bot commented Feb 3, 2023 •

edited

Loading

codecov-commenter commented Feb 5, 2023 •

edited by codecov bot

Loading

henry-deriv Jul 31, 2023 •

edited

Loading

sonarcloud bot commented Aug 7, 2023

Maryia/Kate/DTRA-19/task-add-turbos #7514

Maryia/Kate/DTRA-19/task-add-turbos #7514

Conversation

maryia-deriv commented Feb 3, 2023 • edited Loading

Changes:

When you need to add unit test

When you need to add integration test

Test coverage checklist (for reviewer)

Type of change

vercel bot commented Feb 3, 2023 • edited Loading

github-actions bot commented Feb 3, 2023 • edited Loading

github-actions bot commented Feb 3, 2023 • edited Loading

codecov-commenter commented Feb 5, 2023 • edited by codecov bot Loading

Codecov Report

henry-deriv Jul 31, 2023 • edited Loading

Choose a reason for hiding this comment

sonarcloud bot commented Aug 7, 2023

maryia-deriv commented Feb 3, 2023 •

edited

Loading

vercel bot commented Feb 3, 2023 •

edited

Loading

github-actions bot commented Feb 3, 2023 •

edited

Loading

github-actions bot commented Feb 3, 2023 •

edited

Loading

codecov-commenter commented Feb 5, 2023 •

edited by codecov bot

Loading

henry-deriv Jul 31, 2023 •

edited

Loading