Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Aizad/87648/scroll-issue-onboarding-tradershub #7615

Merged
merged 15 commits into from
Feb 22, 2023
Merged

Aizad/87648/scroll-issue-onboarding-tradershub #7615

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
7ea8e5a
Merge branch 'master' of github.com:binary-com/deriv-app
aizad-deriv Dec 7, 2022
8176397
Merge branch 'master' of github.com:binary-com/deriv-app
aizad-deriv Dec 8, 2022
9c77dc1
Merge branch 'master' of github.com:binary-com/deriv-app
aizad-deriv Dec 8, 2022
a3cbdcd
Merge branch 'master' of github.com:binary-com/deriv-app
aizad-deriv Dec 9, 2022
f5d33bc
Merge branch 'master' of github.com:binary-com/deriv-app
aizad-deriv Dec 12, 2022
f7e14b4
Merge branch 'master' of github.com:binary-com/deriv-app
aizad-deriv Dec 14, 2022
9081d30
Merge branch 'binary-com:master' into master
aizad-deriv Feb 10, 2023
3752268
Merge branch 'develop' of github.com:binary-com/deriv-app
aizad-deriv Feb 16, 2023
8bb98c1
chore: change stylings add more padding below to how content in diffe…
aizad-deriv Feb 7, 2023
4ddfb8f
fix: scroll issue on smaller screens
aizad-deriv Feb 14, 2023
3e98048
feat: testing sikit
aizad-deriv Feb 16, 2023
a51693c
fix: change onboarding sizing to fit mobile
aizad-deriv Feb 16, 2023
a369e08
fix: remove max-height on footer
aizad-deriv Feb 16, 2023
8794c4f
fix: added more height to the body
aizad-deriv Feb 16, 2023
37e59ee
fix: readjust body height (again😀)
aizad-deriv Feb 16, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 11 additions & 5 deletions packages/appstore/src/components/onboarding-new/static-dashboard.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,10 @@
@include desktop {
min-width: 132rem;
}
@include mobile {
position: relative;
bottom: 2rem;
}

&--deposit-button-blurry {
opacity: 0.2;
Expand Down Expand Up @@ -44,21 +48,23 @@
border: 1px solid var(--general-hover);
padding: 2rem;
border-radius: 2.4rem;

@include mobile {
padding: 3rem;
border: none;
}
}

&__bordered--with-margin {
border: 1px solid var(--general-hover);
padding: 2.4rem;
border-radius: 2.4rem;
margin-bottom: 2rem;
}

&__bordered,
&__bordered--with-margin {
@include mobile {
padding: 3rem 3rem 15rem;
height: 36.5rem;
border: none;
overflow-y: scroll;
overflow-x: hidden;
}
}

Expand Down
1 change: 0 additions & 1 deletion packages/appstore/src/modules/onboarding/onboarding.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,6 @@
height: 100%;

@include mobile {
overflow-y: scroll;
height: 60%;
}
}
Expand Down