Ameerul /Task 77336 Error model content required when user tries to block an advertiser who is banned from P2P #7673
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
A production App ID was automatically generated for this PR. (log)
Click here to copy & paste above information. |
|
🚨 Lighthouse report for the changes in this PR:
Lighthouse ran with https://deriv-app-git-fork-ameerul-deriv-task-77336-error-model-ba8a78.binary.sx/ |
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## master #7673 +/- ##
==========================================
- Coverage 20.81% 20.80% -0.02%
==========================================
Files 1561 1561
Lines 36117 36143 +26
Branches 7090 7101 +11
==========================================
Hits 7518 7518
- Misses 27857 27883 +26
Partials 742 742
|
farrah-deriv
previously approved these changes
Feb 21, 2023
ameerul-deriv
force-pushed
the
task-77336-error-model-content-required
branch
from
011e868
to
dd96d61
Compare
ameerul-deriv
force-pushed
the
task-77336-error-model-content-required
branch
from
dd96d61
to
8d0d0a2
Compare
…7336-error-model-content-required
ameerul-deriv
dismissed stale reviews from farrah-deriv and adrienne-deriv
The base branch was changed.
…336-error-model-content-required
|
Kudos, SonarCloud Quality Gate passed!
|
niloofar-deriv
previously approved these changes
Mar 12, 2023
ameerul-deriv
dismissed stale reviews from niloofar-deriv and adrienne-deriv
via
2bdf17b
|
Kudos, SonarCloud Quality Gate passed!
|
|
⏳ Generating Lighthouse report... |
suisin-deriv
approved these changes
May 12, 2023
farhan-nurzi-deriv
approved these changes
May 12, 2023
nijil-deriv
pushed a commit
to nijil-deriv/deriv-app
that referenced
this pull request
May 24, 2023
…lock an advertiser who is banned from P2P (binary-com#7673) * chore: refactored code based off modal manager and fixed string * chore: fixed logic to display modals * chore: fixed cashier locked issue * chore: refactored error message
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
Please include a summary of the change and which issue is fixed below:
When you need to add unit test
When you need to add integration test
Test coverage checklist (for reviewer)
Type of change