Ameerul /remove p2p from cashier

[ameerul-deriv]

Changes:

Please include a summary of the change and which issue is fixed below:

• ...

When you need to add unit test

• If this change disrupt current flow
• If this change is adding new flow

When you need to add integration test

• If components from external libraries are being used to define the flow, e.g. @deriv/components
• If it relies on a very specific set of props with no default behavior for the current component.

Test coverage checklist (for reviewer)

• Ensure utility / function has a test case
• Ensure all the tests are passing

Type of change

• Bug fix
• New feature
• Update feature
• Refactor code
• Translation to code
• Translation to crowdin
• Script configuration
• Improve performance
• Style only
• Dependency update
• Documentation update
• Release

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
deriv-app	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Apr 12, 2023 5:56am

[github-actions]

A production App ID was automatically generated for this PR. (log)

• PR: Ameerul /remove p2p from cashier #7777
• URLs:
  • w/ App ID + Server: https://deriv-app-git-fork-ameerul-deriv-remove-p2p-cashier.binary.sx?qa_server=red.binaryws.com&app_id=32882
  • Original: https://deriv-app-git-fork-ameerul-deriv-remove-p2p-cashier.binary.sx
• App ID: 32882

Click here to copy & paste above information.

- **PR**: [https://github.com/binary-com/deriv-app/pull/7777](https://github.com/binary-com/deriv-app/pull/7777)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-ameerul-deriv-remove-p2p-cashier.binary.sx?qa_server=red.binaryws.com&app_id=32882
    - **Original**: https://deriv-app-git-fork-ameerul-deriv-remove-p2p-cashier.binary.sx
- **App ID**: `32882`

[github-actions]

🚨 Lighthouse report for the changes in this PR:

Category	Score
🔺 Performance	20
🟧 Accessibility	75
🟢 Best practices	92
🟧 SEO	85
🟢 PWA	90

Lighthouse ran with https://deriv-app-git-fork-ameerul-deriv-remove-p2p-cashier.binary.sx/

[codecov-commenter]

Codecov Report

Merging #7777 (cd3b7ec) into master (ba1aef5) will decrease coverage by 0.13%.
The diff coverage is 3.87%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##           master    #7777      +/-   ##
==========================================
- Coverage   20.86%   20.74%   -0.13%     
==========================================
  Files        1539     1538       -1     
  Lines       35942    35940       -2     
  Branches     7031     7030       -1     
==========================================
- Hits         7500     7454      -46     
- Misses      27688    27739      +51     
+ Partials      754      747       -7     

Impacted Files	Coverage Δ
packages/cashier/src/constants/routes-config.ts	88.23% <ø> (ø)
packages/core/src/Stores/notification-store.js	0.00% <0.00%> (ø)
...onents/advertiser-page/advertiser-page-adverts.jsx	10.00% <0.00%> (-1.12%)	⬇️
...components/advertiser-page/advertiser-page-row.jsx	12.50% <0.00%> (ø)
...mponents/advertiser-page/advertiser-page-stats.jsx	4.34% <0.00%> (-0.20%)	⬇️
packages/p2p/src/components/app.jsx	0.00% <0.00%> (ø)
...kages/p2p/src/components/buy-sell/buy-sell-row.jsx	0.00% <0.00%> (ø)
...ges/p2p/src/components/buy-sell/buy-sell-table.jsx	0.00% <0.00%> (ø)
...components/daily-limit-modal/daily-limit-modal.jsx	0.00% <0.00%> (ø)
...l-manager/modals/buy-sell-modal/buy-sell-modal.jsx	0.00% <ø> (ø)
... and 25 more

... and 2 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

[farzin-deriv]

Nice work pal 🚀

[adrienne-deriv]

LGTM

[sonarcloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
1.8% Duplication

[github-actions]

⏳ Generating Lighthouse report...