-
Notifications
You must be signed in to change notification settings - Fork 298
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: ✨ allows users to enter accented name characters #7832
Merged
vinu-deriv
merged 16 commits into
binary-com:master
from
shaheer-deriv:shaheer/90186/last-name-input-validation
Mar 21, 2023
Merged
Changes from 2 commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
67d531f
fix: :sparkles: allows users to enter accented name characters
shaheer-deriv 4bbe640
chore: :wastebasket: removes unused 'letter_symbol' variable
shaheer-deriv 9ce7b7a
Merge branch 'binary-com:master' into shaheer/90186/last-name-input-v…
shaheer-deriv 94c7ea8
fix: :bug: allows accented characters in name for existing users
shaheer-deriv 0d1bf15
Merge branch 'binary-com:master' into shaheer/90186/last-name-input-v…
shaheer-deriv bc44028
Merge branch 'binary-com:master' into shaheer/90186/last-name-input-v…
shaheer-deriv 8ff10d7
Merge branch 'binary-com:master' into shaheer/90186/last-name-input-v…
shaheer-deriv d78d579
Merge branch 'binary-com:master' into shaheer/90186/last-name-input-v…
shaheer-deriv 7b571bf
Merge branch 'master' into shaheer/90186/last-name-input-validation
shaheer-deriv fd27880
docs: :pencil2: comment on the regex used for name validation
shaheer-deriv 20e0d2a
resused regex function
shaheer-deriv 449e5bf
Merge branch 'master' into shaheer/90186/last-name-input-validation
shaheer-deriv c5afae2
fix: :memo: imported reused regex function
shaheer-deriv de4037d
Merge branch 'master' into shaheer/90186/last-name-input-validation
shaheer-deriv b2d392c
fix: :memo: comment on regex function used
shaheer-deriv ef6e34d
Merge branch 'master' into shaheer/90186/last-name-input-validation
shaheer-deriv File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the same regex as the above. reuse the validName function in
personal-details.jsx
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks @yashim-deriv. your change is committed to the code.