Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sync vanilla feat branch with master #8149

Merged
merged 81 commits into from
Apr 5, 2023

Conversation

likhith-deriv
Copy link
Contributor

Changes:

Please include a summary of the change and which issue is fixed below:

  • ...

When you need to add unit test

  • If this change disrupt current flow
  • If this change is adding new flow

When you need to add integration test

  • If components from external libraries are being used to define the flow, e.g. @deriv/components
  • If it relies on a very specific set of props with no default behavior for the current component.

Test coverage checklist (for reviewer)

  • Ensure utility / function has a test case
  • Ensure all the tests are passing

Type of change

  • Bug fix
  • New feature
  • Update feature
  • Refactor code
  • Translation to code
  • Translation to crowdin
  • Script configuration
  • Improve performance
  • Style only
  • Dependency update
  • Documentation update
  • Release

thisyahlen-deriv and others added 30 commits March 21, 2023 09:23
…ication (#7936)

* chore: new account verification modal for purchase authentication

* fix: height and width

* fix: modal footer css

* fix: css mobile title
* fix: remove financial mt5 for norway and japan

* fix: resolved comments

* fix: rename restricetd countries

* fix: compare accounts table

* fix: fix compare accounts table for norway/japan

* fix: remove synthetic bvi for norway and japan
…unt button in the account creation popup (#7926)

* chore: remove duplicate get_settings api request

* chore: set account_settings in client-store if undefined

* chore: remove unnecessary else block

* refactor: convert if expression to ternary

* chore: set account_settings in client store instead of creating a local variable
* fix: ✨ allows users to enter accented name characters

* chore: 🗑️ removes unused 'letter_symbol' variable

* fix: 🐛 allows accented characters in name for existing users

* docs: ✏️ comment on the regex used for name validation

* resused regex function

Co-authored-by: Yashim Wong <yashim@regentmarkets.com>

* fix: 📝 imported reused regex function

* fix: 📝 comment on regex function used

---------

Co-authored-by: Yashim Wong <yashim@regentmarkets.com>
#7743)

* fix: no error message for idv duplicated document numbers

* feat: idv testing document whitelist

* refactor: function rename, code and test fix

* refactor: code style change, review fixes

---------

Co-authored-by: “yauheni-kryzhyk-deriv” <“yauheni@deriv.me”>
…deposit via bank wire (#7933)

* chore: icon changes after build

* fix: redirect user to non-eu account instead eu after cashier deposit switch account
…d when creating or updating a sell ad and making a sell order (#7824)

* chore: added checkbox to payment method card

* fix: added logic to disable checkbox and show checkbox in certain tabs only
…ding verification email in Withdrawal (#7218)

* fix: instantiating useVerifyEmail object once for each email verification case to avoid settimeout leak in useCountdown

* chore: store verify_email_sent_count in store instead of locally

* test: fix test for email-verification-empty-state.tsx

* fix: avoid counter reset by storing and using the time an email was last sent

* chore: a workaround for VerifyEmailRequest type declared with an extra required field in api-types

* chore: remove api-types workaround

* build: update @deriv/api-types to 1.0.85

* revert: api-types version upgrade

* revert: package-lock

* revert: modal-manager.jsx

* revert: modal-manager.jsx
* fix: error when switch to mf

* fix: addressed comments

* fix: addressed comments v2
* chore: fix tooltip language not updating on change language

* fix: added checks for currency in trade store

* fix: added delete amount validation rules in reaction

* fix: remove delete rule in reaction

* fix: remove mistake

* fix: typo
* chore: fix mobile sidebar platform for eu

* fix: codecov error

* fix: codecov error

* chore: update packages
* fix: get chat url from p2p_order_create instead of p2p_chat_create

* fix: fixed issue with order details page

* fix: chat channel url empty issue fixed for p2p_order_create response

* fix: function added to store

* fix: added timeout for setting chat_channel in order details

* fix: pr comments fixed

* fix: increased time out

* fix: removed delay for going to details page from list
* fix: top up demo

* fix: deriv x as well

* redeploy: a
* chore: disable cursor on account switcher button onboarding

* fix: Add the same behavior for Options and Multipliers section Trade Button

* fix: added default class and refactor scss
* fix: removed error validation for amount greater than user's balance

* fix: added popup for creating ad greater than balance

* fix: pr comments fixed

* fix: reuse common modal for visibility errors
* chore: fix mt5 redirection modal closing on trade

* fix: modal and dialog close seperately after clicking outside

* fix: re-add dialog_status condition back to redirect-notice-modal

* fix: reverted the previous changes

* fix: remove useclickoutside for page overlay

* fix: update deriv/api package to latest version

* fix: updated package version to match with master

* Merge branch 'develop' of github.com:binary-com/deriv-app into aizad/88786/mt5-redirection-modal-fix

* fix: codecov and circleci

* fix: upgrade package
Co-authored-by: DerivFE <80095553+DerivFE@users.noreply.github.com>
* chore: remove trading experience incomplete

* fix: remove is cfd score available
* hotfix: wrong restriction message for austria

* fix: Empty-Commit
…add account button in the account creation popup (#7926)" (#8016)

This reverts commit 8bb1351.
#8020)

* Revert "Maryia/80948/fix: avoid rate limit error by storing counter after sending verification email in Withdrawal (#7218)"

This reverts commit cc0065d.

* revert: reverted setIsCFDScoreAvailable from client.store
* chore: prefetched email verification modal

* chore: added settimoeut

* chore: used eager mode

* chore: import model directly

* chore: reverted direct imports

* chore: added settimeout
likhith-deriv and others added 24 commits March 31, 2023 17:20
* fix: set citizen on account

* chore: trigger circleci

* fix: set citizen on account
Co-authored-by: DerivFE <80095553+DerivFE@users.noreply.github.com>
Co-authored-by: DerivFE <80095553+DerivFE@users.noreply.github.com>
Co-authored-by: DerivFE <80095553+DerivFE@users.noreply.github.com>
…contracts (#8046)

* fix: make trade types clickable in responsive for digits contracts

* fix: keep trade params collapsed initially

* fix: merge issues

* fix: merge issue solved

* fix: Empty-Commit

---------

Co-authored-by: Henry Hein <henryhein@Henry-Heins-MacBook-Pro-T90XTJ00Q4.local>
* chore: real account needed for cashier popup

* fix: add new mobx to mockstore

* fix: move dem all to stores

* fix: switch region

* fix: add in mockstore

* fix: add tests and resolve comments

* fix: use mockstore in tests

* fix: add for responsive
…unt in the account creation popup (#8064)

* refactor: conditionally fetch account_settings

* chore: fix failing tests
* fix: isEuropeCountry returns true if you have european residence or if ip address is in europe

* fix: remote console log

* fix: pass eu resident and eu by location flags

* fix: reduce amount of flags sent to smartchart

* fix: Empty-Commit

* fix: Empty-Commit

* fix: codecov issue

* fix: codecov issue 2

---------

Co-authored-by: Henry Hein <henryhein@Henry-Heins-MacBook-Pro-T90XTJ00Q4.local>
#7938)

* fix: Add redirect action that opens multipliers account modal for external platforms

* fix: removed manage, uses other action for manage. This action is strictly for add only

---------

Co-authored-by: Henry Hein <henryhein@Henry-Heins-MacBook-Pro-T90XTJ00Q4.local>
Co-authored-by: Jim Daniels Wasswa <104334373+jim-deriv@users.noreply.github.com>
* fix: login change language error

* fix: console error and loading

---------

Co-authored-by: Jim Daniels Wasswa <104334373+jim-deriv@users.noreply.github.com>
Co-authored-by: yashim-deriv <yashim@deriv.com>
Co-authored-by: “yauheni-kryzhyk-deriv” <“yauheni@deriv.me”>
Co-authored-by: Jim Daniels Wasswa <104334373+jim-deriv@users.noreply.github.com>
* feat: responsive user awareness v1.0

* feat: responsive user awareness v1.1

* feat: responsive user awareness v1.2

* feat: responsive user awareness v1.3

* feat: responsive user awareness v1.3

* feat: responsive user awareness v1.4

* feat: responsive user awareness v1.5

* feat: responsive user awareness v1.6

* refactor: review code + tsmigration

* refactor: removed the unused props

* refactor: removed the unused props v1.2

* refactor: alias added v1.3

* fix: successfully added in the text

* fix: successfully added in the text + Standardization V1.2

* fix: successfully added in the text + Standardization V1.3

* fix: successfully added in the text + Standardization V1.3.1

* fix: language switcher css (#8084)

Co-authored-by: yashim-deriv <yashim@deriv.com>

* fix: placeholder signup modal typo (#8095)

* thisyahlen/fix: disable language button till language is fully loaded (#8089)

* fix: disable language button till language is fully loaded

* fix: add mockstore

* fix: responsive

* fix: remove unused css

* fix: css

* fix: 🐛 button not disabled for account signup (#8103)

* Amina/fix: set citizen on account (#8102)

* fix: set citizen on account

* chore: trigger circleci

* fix: set citizen on account

---------

Co-authored-by: Matin shafiei <matin@deriv.com>
Co-authored-by: thisyahlen <104053934+thisyahlen-deriv@users.noreply.github.com>
Co-authored-by: yashim-deriv <yashim@deriv.com>
Co-authored-by: Aizad Ridzo <103104395+aizad-deriv@users.noreply.github.com>
Co-authored-by: Likhith Kolayari <98398322+likhith-deriv@users.noreply.github.com>
Co-authored-by: amina-deriv <84661147+amina-deriv@users.noreply.github.com>
…Deriv Account with no siblings and CFDs account (#7894)

* refactor: init pr

* refactor: edited transfer page content

* refactor: changed button behavior

* refactor: removed unused variables/consts

* refactor: removed unused function param and type

* refactor: tests fixed

* refactor: fixed a test with navigating to traders hub

* refactor: renamed a test with navigation + more changes

* refactor: removed openAccountSwitcherModal

* refactor: removed backticks

* refactor: typo fixed

* refactor: fixed cringe mistake on my part

* refactor: tests improved

* refactor: periods added for messages

* refactor: a few more changes to tests

* refactor: mockRootStore type changed to TStores

* refactor: a change to spec + merge conflicts fixes
…7845)

* feat: ⬆️ update `@deriv/api-types` to `1.0.85`

* feat(api): ✨ update api types with all the requests from `@deriv/api-types`

* feat(api): ✨ add `useAPI` hook

* feat(api): ✨ add `useAPISubscription` hook

* feat(api): ✨ add `useAPISubscription` hook

* feat(api): ✨ improve types

* feat(api): ✨ rename hooks

* feat(api): ✨ rename hooks

* refactor(api): 🔥 remove `QueryClient` config

* refactor(api): 🔥 remove unnecessary utils file

* refactor(api): 🔥 remove unnecessary export types

* test(api): ✅ add test for `useFetch` hook

* refactor(api): 🔥 improve `useSubscription` hook

* feat(api): ✨ use `useMutation` hook inside `useRequest` hook

* test(cashier): ✅ fix the failing test

* refactor(api): ♻️ move request props to `payload` object

* refactor(api): 📝 resolve PR comments

* feat(api): ⬆️ migrating to React Query 4

* fix(cashier): 🐛 fix type errors

* feat(api): ✨ add `useInvalidateQuery` hook

* refactor(api): 📝 resolve PR comments

* ci: 💚 trigger build

* ci: 💚 trigger build

---------

Co-authored-by: Farzin Mirzaie <farzin@deriv.com>
Co-authored-by: DerivFE <80095553+DerivFE@users.noreply.github.com>
* fix: sets the contract language whenever there is a change

* fix: issue with popup disappearing

* fix: translate amount tooltip

---------

Co-authored-by: Jim Daniels Wasswa <104334373+jim-deriv@users.noreply.github.com>
* fix: add_removed_deposit_test

* fix: review comments

* fix: Rename error component

* fix_showing_crypto_deposit_condition
Co-authored-by: DerivFE <80095553+DerivFE@users.noreply.github.com>
Co-authored-by: yashim-deriv <yashim@deriv.com>
Co-authored-by: DerivFE <80095553+DerivFE@users.noreply.github.com>
@github-advanced-security
Copy link

You have successfully added a new CodeQL configuration /language:javascript. As part of the setup process, we have scanned this repository and found no existing alerts. In the future, you will see all code scanning alerts on the repository Security tab.

@boring-cyborg boring-cyborg bot added the Account label Apr 5, 2023
@vercel
Copy link

vercel bot commented Apr 5, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
deriv-app ✅ Ready (Inspect) Visit Preview Apr 5, 2023 7:14am

@sonarcloud
Copy link

sonarcloud bot commented Apr 5, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
2.7% 2.7% Duplication

@matin-deriv matin-deriv merged commit d85228f into feat-88950-akmal/vanilla-financial Apr 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.