Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Amina/fix: investor password #8153

Closed
wants to merge 6 commits into from
Closed

Amina/fix: investor password #8153

wants to merge 6 commits into from

Conversation

amina-deriv
Copy link
Contributor

Changes:

Please include a summary of the change and which issue is fixed below:

  • ...

When you need to add unit test

  • If this change disrupt current flow
  • If this change is adding new flow

When you need to add integration test

  • If components from external libraries are being used to define the flow, e.g. @deriv/components
  • If it relies on a very specific set of props with no default behavior for the current component.

Test coverage checklist (for reviewer)

  • Ensure utility / function has a test case
  • Ensure all the tests are passing

Type of change

  • Bug fix
  • New feature
  • Update feature
  • Refactor code
  • Translation to code
  • Translation to crowdin
  • Script configuration
  • Improve performance
  • Style only
  • Dependency update
  • Documentation update
  • Release

@boring-cyborg boring-cyborg bot added the Account label Apr 5, 2023
@vercel
Copy link

vercel bot commented Apr 5, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
deriv-app ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 5, 2023 9:11am

@github-actions
Copy link
Contributor

github-actions bot commented Apr 5, 2023 •
edited
Loading

A production App ID was automatically generated for this PR. (log)

Click here to copy & paste above information. 
- **PR**: [https://github.com/binary-com/deriv-app/pull/8153](https://github.com/binary-com/deriv-app/pull/8153)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-amina-deriv-92613-aminachangemt5passw-766e82.binary.sx?qa_server=frontend.binaryws.com&app_id=32206
    - **Original**: https://deriv-app-git-fork-amina-deriv-92613-aminachangemt5passw-766e82.binary.sx
- **App ID**: `32206`

@github-actions
Copy link
Contributor

github-actions bot commented Apr 5, 2023 •
edited
Loading

🚨 Lighthouse report for the changes in this PR:

Category Score
🔺 Performance 23
🟧 Accessibility 75
🟧 Best practices 83
🟧 SEO 85
🟢 PWA 90

Lighthouse ran with https://deriv-app-git-fork-amina-deriv-92613-aminachangemt5passw-766e82.binary.sx/

@codecov-commenter
Copy link

Codecov Report

Merging #8153 (bb8d74a) into master (826faf5) will increase coverage by 0.18%.
The diff coverage is n/a.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##           master    #8153      +/-   ##
==========================================
+ Coverage   20.54%   20.73%   +0.18%     
==========================================
  Files        1531     1539       +8     
  Lines       35826    35916      +90     
  Branches     6991     7012      +21     
==========================================
+ Hits         7362     7447      +85     
+ Misses      27762    27749      -13     
- Partials      702      720      +18
Impacted Files Coverage Δ
...ng-password-modal/reset-trading-password-modal.jsx 91.48% <ø> (ø)
...es/cfd/src/Containers/cfd-reset-password-modal.tsx 0.00% <ø> (ø)

... and 39 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

amina-deriv
amina-deriv commented Apr 5, 2023
View reviewed changes
packages/cfd/src/Containers/cfd-reset-password-modal.tsx
@@ -89,9 +80,6 @@ const CFDResetPasswordModal = ({
localStorage.removeItem('cfd_reset_password_intent');
localStorage.removeItem('cfd_reset_password_type');
localStorage.removeItem('cfd_reset_password_code');
if (history.location.pathname !== routes.mt5) {
history.push(`${routes.mt5}`);
}
Copy link
Contributor Author

@amina-deriv amina-deriv Apr 5, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

since we dont have mt5 dashboard now, this redirection is not required.

@sonarcloud
Copy link

sonarcloud bot commented Apr 5, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@amina-deriv
Copy link
Contributor Author

Incorporated the fix along with #8186

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mahdiyeh-deriv mahdiyeh-deriv mahdiyeh-deriv approved these changes

@thisyahlen-deriv thisyahlen-deriv thisyahlen-deriv approved these changes

@hamza-deriv hamza-deriv hamza-deriv approved these changes

@yashim-deriv yashim-deriv Awaiting requested review from yashim-deriv

Assignees
No one assigned
Labels
Account
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@amina-deriv @codecov-commenter @mahdiyeh-deriv @thisyahlen-deriv @hamza-deriv