refactor: evgeniy/92724/language settings improvements #8176

yauheni-deriv · 2023-04-06T09:25:31Z

Changes:

Please include a summary of the change and which issue is fixed below:

...

When you need to add unit test

If this change disrupt current flow
If this change is adding new flow

When you need to add integration test

If components from external libraries are being used to define the flow, e.g. @deriv/components
If it relies on a very specific set of props with no default behavior for the current component.

Test coverage checklist (for reviewer)

Ensure utility / function has a test case
Ensure all the tests are passing

Type of change

vercel · 2023-04-06T09:25:35Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
deriv-app	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Oct 3, 2023 7:34am

github-actions · 2023-04-06T09:34:54Z

🚨 Lighthouse report for the changes in this PR:

Category	Score
🔺 Performance	21
🟧 Accessibility	75
🟢 Best practices	92
🟧 SEO	85
🟢 PWA	90

Lighthouse ran with https://deriv-app-git-fork-yauheni-deriv-evgeniy-92724languagese-2ebeca.binary.sx/

niloofar-deriv

LGTM 👍

packages/account/src/Sections/Profile/LanguageSettings/language-settings.tsx

github-actions · 2023-04-07T05:46:01Z

A production App ID was automatically generated for this PR. (log)

PR: refactor: evgeniy/92724/language settings improvements #8176
URLs:
- w/ App ID + Server: https://deriv-app-git-fork-yauheni-deriv-evgeniy-92724languagese-2ebeca.binary.sx?qa_server=red.binaryws.com&app_id=32215
- Original: https://deriv-app-git-fork-yauheni-deriv-evgeniy-92724languagese-2ebeca.binary.sx
App ID: 32215

Click here to copy & paste above information.

- **PR**: [https://github.com/binary-com/deriv-app/pull/8176](https://github.com/binary-com/deriv-app/pull/8176)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-yauheni-deriv-evgeniy-92724languagese-2ebeca.binary.sx?qa_server=red.binaryws.com&app_id=32215
    - **Original**: https://deriv-app-git-fork-yauheni-deriv-evgeniy-92724languagese-2ebeca.binary.sx
- **App ID**: `32215`

codecov-commenter · 2023-04-07T06:06:55Z

Codecov Report

Merging #8176 (af89cf9) into master (d5c38a0) will not change coverage.
Report is 571 commits behind head on master.
The diff coverage is n/a.

❗ Current head af89cf9 differs from pull request most recent head 127a787. Consider uploading reports for the commit 127a787 to get more accurate results

@@          Coverage Diff           @@
##           master   #8176   +/-   ##
======================================
  Coverage    0.05%   0.05%           
======================================
  Files         117     117           
  Lines        3425    3425           
  Branches      893     893           
======================================
  Hits            2       2           
  Misses       3423    3423

…/92724/language_settings_improvements

packages/core/src/App/Components/Layout/Header/toggle-menu-drawer.jsx

packages/account/src/Sections/Profile/LanguageSettings/language-settings.tsx

matin-deriv · 2023-09-29T09:28:32Z

packages/utils/src/parse-url.ts

+/**
+ * Checks is the url passed as prop routes to external URL resource by checking if it starts with http, https or mailto
+ * @param link string
+ * @returns boolean
+ */
+export const isExternalLink = (link: string) => /^(http|https|mailto):/i.test(link);


I don't understand the use of isExternalLink, or the variable name needs to be improved.

can we just use isNavigationFromExternalPlatform instead.

seems like there is a typo in the comment section as well.

the goal and functionality of these functions are different.
with isExternalLink we are checking additionally if the route is to external link and not to the some of the app's page. Basically it i used to resolve our current production issue, when you try to navigate through account settings for responsive version, you see reloading the app. It is due to wrong usage of and .
so this issue has been fixed in this PR.
will fix the typo 👍

…/92724/language_settings_improvements

sonarcloud · 2023-10-03T07:27:44Z

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
2 Code Smells

No Coverage information
1.1% Duplication

* refactor: evgeniy/92724/language settings improvements * fix: cursor button fix * feat: same language menu usage for responsive * fix: hide language icon while opening language menu * refactor: review change, adding types and dependencies * fix: changes from master missed * fix: reading undefined error * fix: duplicated properties * fix: types duplicate * chore: language-settings test * refactor: menu-link store separately * chore: menu-link test coverage * refactor: test code structure * refactor: link code * refactor: remove unused code * refactor: code readability * refactor: variable usage * refactor: variable usage * refactor: review comments incorporating * fix: test refactor with mockstore * fix: missing mock * fix: 🎨 incorporated deriv/util package * fix: ⚡ refactored code * feat: resolved code smells * feat: resolved review comments * feat: resolved review comments * feat: resolved review comments * fix: failing testcase * fix: 🐛 missing import * Trigger build * chore: trigger build * Merge branch 'master' into evgeniy/92724/language_settings_improvements * chore: review comments incorporate * refactor: types store alphabetically order * refactor: types store alphabetically order * refactor: menulink export fix * chore: remove unused variable * refactor: remove unused variable * chore: trigger build * fix: resolve conflicts * fix: repeated fields * chore: isExternalLink description * chore: bootstrap --------- Co-authored-by: “yauheni-kryzhyk-deriv” <“yauheni@deriv.me”> Co-authored-by: Likhith Kolayari <98398322+likhith-deriv@users.noreply.github.com> Co-authored-by: Matin shafiei <matin@deriv.com> Co-authored-by: Likhith Kolayari <likhith@regentmarkets.com>

refactor: evgeniy/92724/language settings improvements

5242db6

yauheni-deriv requested a review from yashim-deriv as a code owner April 6, 2023 09:25

boring-cyborg bot added Account Core labels Apr 6, 2023

fix: cursor button fix

ffeeb19

vercel bot deployed to Preview April 6, 2023 09:43 View deployment

niloofar-deriv previously approved these changes Apr 6, 2023

View reviewed changes

amina-deriv reviewed Apr 6, 2023

View reviewed changes

packages/account/src/Sections/Profile/LanguageSettings/language-settings.tsx Show resolved Hide resolved

amina-deriv previously approved these changes Apr 6, 2023

View reviewed changes

henry-deriv previously approved these changes Apr 7, 2023

View reviewed changes

vercel bot deployed to Preview April 7, 2023 05:57 View deployment

“yauheni-kryzhyk-deriv” added 2 commits April 11, 2023 14:25

Merge branch 'master' of github.com:binary-com/deriv-app into evgeniy…

ff4b10c

…/92724/language_settings_improvements

feat: same language menu usage for responsive

4ae4d10

yauheni-deriv dismissed stale reviews from amina-deriv, henry-deriv, and niloofar-deriv via 4ae4d10 April 13, 2023 11:10

yauheni-deriv force-pushed the evgeniy/92724/language_settings_improvements branch from b19746b to 4ae4d10 Compare April 13, 2023 11:10

Merge branch 'master' of github.com:binary-com/deriv-app into evgeniy…

df0c7fc

…/92724/language_settings_improvements

yauheni-deriv commented Apr 13, 2023

View reviewed changes

packages/core/src/App/Components/Layout/Header/toggle-menu-drawer.jsx Outdated Show resolved Hide resolved

yauheni-deriv commented Apr 13, 2023

View reviewed changes

packages/account/src/Sections/Profile/LanguageSettings/language-settings.tsx Show resolved Hide resolved

vercel bot deployed to Preview April 13, 2023 11:34 View deployment

niloofar-deriv previously approved these changes Apr 13, 2023

View reviewed changes

henry-deriv previously approved these changes Apr 13, 2023

View reviewed changes

fix: hide language icon while opening language menu

228311e

yauheni-deriv dismissed stale reviews from henry-deriv and niloofar-deriv via 228311e April 13, 2023 13:11

vercel bot deployed to Preview September 26, 2023 15:02 View deployment

yauheni-deriv requested a review from amina-deriv September 26, 2023 15:26

fix: resolve conflict

266361a

vercel bot deployed to Preview September 29, 2023 06:58 View deployment

matin-deriv reviewed Sep 29, 2023

View reviewed changes

chore: isExternalLink description

d498ee1

vercel bot deployed to Preview September 29, 2023 10:21 View deployment

matin-deriv previously approved these changes Oct 2, 2023

View reviewed changes

yauheni-deriv dismissed matin-deriv’s stale review via e092498 October 2, 2023 08:48

yauheni-deriv requested a review from matin-deriv October 2, 2023 08:48

yauheni-deriv deployed to Preview October 2, 2023 08:49 — with GitHub Actions View deployment

yauheni-deriv deployed to Preview October 2, 2023 09:35 — with GitHub Actions View deployment

fix: resolve conflict

32188d5

yauheni-deriv force-pushed the evgeniy/92724/language_settings_improvements branch from 9a8d7e3 to 32188d5 Compare October 2, 2023 11:08

yauheni-deriv deployed to Preview October 2, 2023 11:08 — with GitHub Actions View deployment

Merge branch 'master' of github.com:binary-com/deriv-app into evgeniy…

02b56be

…/92724/language_settings_improvements

yauheni-deriv deployed to Preview October 2, 2023 11:31 — with GitHub Actions View deployment

Merge branch 'master' of github.com:binary-com/deriv-app into evgeniy…

aa7bf7f

…/92724/language_settings_improvements

yauheni-deriv deployed to Preview October 2, 2023 12:09 — with GitHub Actions View deployment

Merge branch 'master' of github.com:binary-com/deriv-app into evgeniy…

02b1e32

…/92724/language_settings_improvements

yauheni-deriv deployed to Preview October 2, 2023 12:28 — with GitHub Actions View deployment

Merge branch 'master' of github.com:binary-com/deriv-app into evgeniy…

b247774

…/92724/language_settings_improvements

yauheni-deriv deployed to Preview October 3, 2023 06:58 — with GitHub Actions View deployment

chore: bootstrap

127a787

yauheni-deriv requested a review from balakrishna-deriv as a code owner October 3, 2023 07:21

yauheni-deriv deployed to Preview October 3, 2023 07:21 — with GitHub Actions View deployment

sandeep-deriv merged commit 2c82757 into binary-com:master Oct 4, 2023
6 of 7 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

refactor: evgeniy/92724/language settings improvements #8176

refactor: evgeniy/92724/language settings improvements #8176

yauheni-deriv commented Apr 6, 2023

vercel bot commented Apr 6, 2023 •

edited

Loading

github-actions bot commented Apr 6, 2023 •

edited

Loading

niloofar-deriv left a comment

github-actions bot commented Apr 7, 2023 •

edited

Loading

codecov-commenter commented Apr 7, 2023 •

edited by codecov bot

Loading

matin-deriv Sep 29, 2023

yauheni-deriv Sep 29, 2023

sonarcloud bot commented Oct 3, 2023

refactor: evgeniy/92724/language settings improvements #8176

refactor: evgeniy/92724/language settings improvements #8176

Conversation

yauheni-deriv commented Apr 6, 2023

Changes:

When you need to add unit test

When you need to add integration test

Test coverage checklist (for reviewer)

Type of change

vercel bot commented Apr 6, 2023 • edited Loading

github-actions bot commented Apr 6, 2023 • edited Loading

niloofar-deriv left a comment

Choose a reason for hiding this comment

github-actions bot commented Apr 7, 2023 • edited Loading

codecov-commenter commented Apr 7, 2023 • edited by codecov bot Loading

Codecov Report

matin-deriv Sep 29, 2023

Choose a reason for hiding this comment

yauheni-deriv Sep 29, 2023

Choose a reason for hiding this comment

sonarcloud bot commented Oct 3, 2023

vercel bot commented Apr 6, 2023 •

edited

Loading

github-actions bot commented Apr 6, 2023 •

edited

Loading

github-actions bot commented Apr 7, 2023 •

edited

Loading

codecov-commenter commented Apr 7, 2023 •

edited by codecov bot

Loading