Farzin/WALL-291/Refactor cashier onboarding into a module #8338
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n_@deriv/api_package
…e_in_onboarding woth hooks
…usePaymentAgentList hook usage
…n_@deriv/api_package
…n_@deriv/api_package
…n_@deriv/api_package
…n_@deriv/api_package
…n_@deriv/api_package
…n_@deriv/api_package
…n_@deriv/api_package
added 5 commits
May 25, 2023 23:57
…ashier_onboarding_to_a_new_route
There was a problem hiding this comment.
can we modify this hook to accept account_list as the input ?
because in packages/hooks/src/useTotalAssetCurrency.ts line 12 we have the same thing and I was thinking maybe we can use this hook for that. what do you think? 🤔
There was a problem hiding this comment.
@shayan-deriv Hmmm, Yeah that sounds good 🤔
Let's have a call on this later, I can make the change in the next PR I have which is dependent on this one 🙇🏻
heorhi-deriv
approved these changes
Jun 1, 2023
|
Kudos, SonarCloud Quality Gate passed!
|
|
⏳ Generating Lighthouse report... |
farzin-deriv
deleted the
farzin/wall-434/separate_cashier_onboarding_to_a_new_route
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
Please include a summary of the change and which issue is fixed below:
When you need to add unit test
When you need to add integration test
Test coverage checklist (for reviewer)
Type of change