Aum/wall 228/crypto cashier changes for third party processor coinspaid #8343

aum-deriv · 2023-04-25T07:38:20Z

Changes:

Please include a summary of the change and which issue is fixed below:

...

When you need to add unit test

If this change disrupt current flow
If this change is adding new flow

When you need to add integration test

If components from external libraries are being used to define the flow, e.g. @deriv/components
If it relies on a very specific set of props with no default behavior for the current component.

Test coverage checklist (for reviewer)

Ensure utility / function has a test case
Ensure all the tests are passing

Type of change

…nt processors

vercel · 2023-04-25T07:38:23Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
deriv-app	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	May 8, 2023 9:04am

github-actions · 2023-04-25T07:51:02Z

A production App ID was automatically generated for this PR. (log)

PR: Aum/wall 228/crypto cashier changes for third party processor coinspaid #8343
URLs:
- w/ App ID + Server: https://deriv-app-git-fork-aum-deriv-aum-wall-228crypto-cashier-8fd026.binary.sx?qa_server=red.binaryws.com&app_id=24053
- Original: https://deriv-app-git-fork-aum-deriv-aum-wall-228crypto-cashier-8fd026.binary.sx
App ID: 24053

Click here to copy & paste above information.

- **PR**: [https://github.com/binary-com/deriv-app/pull/8343](https://github.com/binary-com/deriv-app/pull/8343)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-aum-deriv-aum-wall-228crypto-cashier-8fd026.binary.sx?qa_server=red.binaryws.com&app_id=24053
    - **Original**: https://deriv-app-git-fork-aum-deriv-aum-wall-228crypto-cashier-8fd026.binary.sx
- **App ID**: `24053`

github-actions · 2023-04-25T07:51:24Z

🚨 Lighthouse report for the changes in this PR:

Category	Score
🔺 Performance	21
🟧 Accessibility	75
🟢 Best practices	92
🟧 SEO	85
🟢 PWA	90

Lighthouse ran with https://deriv-app-git-fork-aum-deriv-aum-wall-228crypto-cashier-8fd026.binary.sx/

…processor (CoinsPaid)

…L-228/crypto-cashier-changes-for-third-party-processor-coinspaid

codecov-commenter · 2023-05-01T13:45:02Z

Codecov Report

Merging #8343 (4dbc748) into master (e7df8d2) will increase coverage by 0.02%.
The diff coverage is 80.00%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##           master    #8343      +/-   ##
==========================================
+ Coverage   20.81%   20.83%   +0.02%     
==========================================
  Files        1561     1562       +1     
  Lines       36118    36129      +11     
  Branches     7091     7094       +3     
==========================================
+ Hits         7518     7528      +10     
- Misses      27858    27860       +2     
+ Partials      742      741       -1

Impacted Files	Coverage Δ
...ansactions-history/crypto-transactions-history.tsx	`72.00% <25.00%> (-5.28%)`	⬇️
...shier/src/components/alert-banner/alert-banner.tsx	`100.00% <100.00%> (ø)`
...nsactions-history/crypto-transactions-renderer.tsx	`85.36% <100.00%> (+3.78%)`	⬆️
...rc/pages/deposit/crypto-deposit/crypto-deposit.tsx	`91.78% <100.00%> (+0.35%)`	⬆️

…L-228/crypto-cashier-changes-for-third-party-processor-coinspaid

farzin-deriv

Please update your branch with the latest master 🙏🏻

packages/cashier/src/pages/deposit/crypto-deposit/crypto-deposit.tsx

packages/cashier/src/components/crypto-transactions-history/crypto-transactions-renderer.tsx

packages/cashier/src/components/alert-banner/alert-banner.tsx

...r/src/components/crypto-transactions-history/__tests__/crypto-transactions-renderer.spec.tsx

packages/cashier/src/pages/deposit/crypto-deposit/__tests__/crypto-deposit.spec.tsx

…L-228/crypto-cashier-changes-for-third-party-processor-coinspaid

packages/cashier/src/components/crypto-transactions-history/crypto-transactions-renderer.tsx

packages/cashier/src/components/alert-banner/alert-banner.scss

farzin-deriv · 2023-05-05T01:43:44Z

packages/cashier/src/components/alert-banner/alert-banner.tsx

+import React from 'react';
+import classNames from 'classnames';
+import { Icon, Text } from '@deriv/components';
+import { Localize } from '@deriv/translations';


Suggested change

import { Localize } from '@deriv/translations';

farzin-deriv · 2023-05-05T01:44:47Z

packages/cashier/src/components/alert-banner/alert-banner.tsx

+type TAlertBanner = {
+    className?: string;
+    icon: string;
+    message: JSX.Element | string;


Suggested change

message: JSX.Element | string;

message: string;

@heorhi-deriv suggested me to use <Localize /> component instead of the function as he pointed out that the function variant is used only for simple strings and not for dynamic data throughout the project.

packages/cashier/src/components/alert-banner/alert-banner.tsx

packages/cashier/src/components/alert-banner/__tests__/alert-banner.spec.tsx

packages/cashier/src/pages/deposit/crypto-deposit/crypto-deposit.scss

packages/cashier/src/pages/deposit/crypto-deposit/__tests__/crypto-deposit.spec.tsx

henry-deriv · 2023-05-05T06:07:57Z

...r/src/components/crypto-transactions-history/__tests__/crypto-transactions-renderer.spec.tsx

+        );
+
+        expect(crypto_transactions_history_table_tooltip_mobile).toBeInTheDocument();
+        fireEvent.click(crypto_transactions_history_table_tooltip_mobile);


Suggested change

fireEvent.click(crypto_transactions_history_table_tooltip_mobile);

userEvent.click(crypto_transactions_history_table_tooltip_mobile);

@henry-deriv can you please provide a reason for using userEvent instead of fireEvent?

userEvent reflects user interaction better than fireEvent. Mimics a more realistic user interaction than fireEvent. Also, by convention we have stopped using fireEvent in our repo.

henry-deriv · 2023-05-05T06:08:13Z

...r/src/components/crypto-transactions-history/__tests__/crypto-transactions-renderer.spec.tsx

@@ -1,5 +1,6 @@
 import React from 'react';
 import { fireEvent, render, screen, waitFor } from '@testing-library/react';


Suggested change

import { fireEvent, render, screen, waitFor } from '@testing-library/react';

import { render, screen, waitFor } from '@testing-library/react';

…L-228/crypto-cashier-changes-for-third-party-processor-coinspaid

packages/cashier/src/components/alert-banner/__tests__/alert-banner.spec.tsx

…anner.spec.tsx Co-authored-by: Farzin Mirzaie <72082844+farzin-deriv@users.noreply.github.com>

…ird-party-processor-coinspaid

sonarcloud · 2023-05-08T08:24:03Z

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
2.0% Duplication

@heorhi-deriv

…id (binary-com#8343) * feat: Tooltip for crypto transactions processed by third-party payement processors * feat: Added popup note for mobile view for third-party payment tooltip * feat: added alert banner component in cashier package * feat: added IcAlertWarningDark icon * chore: working on test cases 1 * chore: reseting testcase to upstream/master * chore: added test case for tooltip in desktop mode * feat: AlertBanner for cryptoc with minimum deposit using third-party processor (CoinsPaid) * feat: changed styles for crypto-deposit.tsx * chore: added data-testid for tooltip in mobile view * chore: added test cases for crypto-deposit.tsx * chore: added test cases for crypto-deposit.tsx * fix: fixed the test cases for crypto-deposit.tsx * chore: made changes based on comments in PR * chore: fixing changes suggested by @heorhi-deriv * chore: updated alert-banner.tsx * refactor: changed the way localization is handled by alert-banner.tsx * chore: minor fixes * chore: removed unused classnames * chore: add test cases and made changes suggested by @nijil-deriv * chore: made changes for the comments in PR * Update packages/cashier/src/components/alert-banner/__tests__/alert-banner.spec.tsx Co-authored-by: Farzin Mirzaie <72082844+farzin-deriv@users.noreply.github.com> --------- Co-authored-by: Farzin Mirzaie <72082844+farzin-deriv@users.noreply.github.com>

aum-deriv added 4 commits April 13, 2023 15:18

feat: Tooltip for crypto transactions processed by third-party payeme…

7fd955c

…nt processors

feat: Added popup note for mobile view for third-party payment tooltip

adb5c7d

feat: added alert banner component in cashier package

e4b47a5

feat: added IcAlertWarningDark icon

9646075

boring-cyborg bot added the Components label Apr 25, 2023

chore: working on test cases 1

4b4e7b3

vercel bot deployed to Preview April 25, 2023 07:59 View deployment

chore: reseting testcase to upstream/master

0dec7ed

vercel bot deployed to Preview April 25, 2023 08:35 View deployment

chore: added test case for tooltip in desktop mode

c5db122

vercel bot deployed to Preview April 25, 2023 09:00 View deployment

aum-deriv added 3 commits April 25, 2023 13:04

feat: AlertBanner for cryptoc with minimum deposit using third-party …

7fad31a

…processor (CoinsPaid)

feat: changed styles for crypto-deposit.tsx

7186391

chore: added data-testid for tooltip in mobile view

c02b91d

vercel bot deployed to Preview April 25, 2023 09:28 View deployment

aum-deriv added 3 commits May 1, 2023 16:52

chore: added test cases for crypto-deposit.tsx

e46f1cc

Merge branch 'master' of github.com:binary-com/deriv-app into aum/WAL…

ee572bb

…L-228/crypto-cashier-changes-for-third-party-processor-coinspaid

chore: added test cases for crypto-deposit.tsx

2f7354d

vercel bot deployed to Preview May 1, 2023 13:32 View deployment

aum-deriv added 2 commits May 2, 2023 10:57

Merge branch 'master' of github.com:binary-com/deriv-app into aum/WAL…

d2ac397

…L-228/crypto-cashier-changes-for-third-party-processor-coinspaid

fix: fixed the test cases for crypto-deposit.tsx

fc70051

vercel bot deployed to Preview May 2, 2023 10:57 View deployment

farzin-deriv suggested changes May 2, 2023

View reviewed changes

aum-deriv added 2 commits May 3, 2023 10:11

Merge branch 'master' of github.com:binary-com/deriv-app into aum/WAL…

172ca8e

…L-228/crypto-cashier-changes-for-third-party-processor-coinspaid

chore: made changes based on comments in PR

7b21fb8

vercel bot deployed to Preview May 3, 2023 07:30 View deployment

aum-deriv added 2 commits May 3, 2023 16:47

Merge branch 'master' of github.com:binary-com/deriv-app into aum/WAL…

69b2432

…L-228/crypto-cashier-changes-for-third-party-processor-coinspaid

chore: updated alert-banner.tsx

7b86af7

vercel bot deployed to Preview May 3, 2023 13:27 View deployment

refactor: changed the way localization is handled by alert-banner.tsx

e1a5070

vercel bot deployed to Preview May 3, 2023 14:06 View deployment

chore: minor fixes

16c386a

vercel bot deployed to Preview May 3, 2023 14:24 View deployment

heorhi-deriv previously approved these changes May 3, 2023

View reviewed changes

chore: removed unused classnames

b7208e4

aum-deriv dismissed heorhi-deriv’s stale review via b7208e4 May 4, 2023 09:17

vercel bot deployed to Preview May 4, 2023 09:34 View deployment

nijil-deriv reviewed May 4, 2023

View reviewed changes

packages/cashier/src/components/crypto-transactions-history/crypto-transactions-renderer.tsx Outdated Show resolved Hide resolved

nijil-deriv reviewed May 4, 2023

View reviewed changes

packages/cashier/src/components/crypto-transactions-history/crypto-transactions-renderer.tsx Outdated Show resolved Hide resolved

chore: add test cases and made changes suggested by @nijil-deriv

729626f

vercel bot deployed to Preview May 4, 2023 17:02 View deployment

farzin-deriv reviewed May 5, 2023

View reviewed changes

henry-deriv reviewed May 5, 2023

View reviewed changes

aum-deriv added 3 commits May 5, 2023 10:11

Merge branch 'master' of github.com:binary-com/deriv-app into aum/WAL…

5096677

…L-228/crypto-cashier-changes-for-third-party-processor-coinspaid

Merge branch 'master' of github.com:binary-com/deriv-app into aum/WAL…

7cf5b40

…L-228/crypto-cashier-changes-for-third-party-processor-coinspaid

chore: made changes for the comments in PR

b4ed579

vercel bot deployed to Preview May 5, 2023 12:28 View deployment

farzin-deriv previously approved these changes May 6, 2023

View reviewed changes

packages/cashier/src/components/alert-banner/__tests__/alert-banner.spec.tsx Outdated Show resolved Hide resolved

Update packages/cashier/src/components/alert-banner/__tests__/alert-b…

915a5ef

…anner.spec.tsx Co-authored-by: Farzin Mirzaie <72082844+farzin-deriv@users.noreply.github.com>

aum-deriv dismissed farzin-deriv’s stale review via 915a5ef May 8, 2023 08:17

Merge branch 'master' into aum/WALL-228/crypto-cashier-changes-for-th…

4dbc748

…ird-party-processor-coinspaid

vercel bot deployed to Preview May 8, 2023 09:04 View deployment

nijil-deriv approved these changes May 10, 2023

View reviewed changes

sandeep-deriv merged commit 28ad069 into binary-com:master May 10, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Aum/wall 228/crypto cashier changes for third party processor coinspaid #8343

Aum/wall 228/crypto cashier changes for third party processor coinspaid #8343

aum-deriv commented Apr 25, 2023

vercel bot commented Apr 25, 2023 •

edited

Loading

github-actions bot commented Apr 25, 2023 •

edited

Loading

github-actions bot commented Apr 25, 2023 •

edited

Loading

codecov-commenter commented May 1, 2023 •

edited

Loading

farzin-deriv left a comment

farzin-deriv May 5, 2023

farzin-deriv May 5, 2023

aum-deriv May 5, 2023

henry-deriv May 5, 2023

aum-deriv May 5, 2023

henry-deriv May 6, 2023

henry-deriv May 5, 2023

sonarcloud bot commented May 8, 2023

	fireEvent.click(crypto_transactions_history_table_tooltip_mobile);
	userEvent.click(crypto_transactions_history_table_tooltip_mobile);

		@@ -1,5 +1,6 @@
		import React from 'react';
		import { fireEvent, render, screen, waitFor } from '@testing-library/react';

	import { fireEvent, render, screen, waitFor } from '@testing-library/react';
	import { render, screen, waitFor } from '@testing-library/react';

Aum/wall 228/crypto cashier changes for third party processor coinspaid #8343

Aum/wall 228/crypto cashier changes for third party processor coinspaid #8343

Conversation

aum-deriv commented Apr 25, 2023

Changes:

When you need to add unit test

When you need to add integration test

Test coverage checklist (for reviewer)

Type of change

vercel bot commented Apr 25, 2023 • edited Loading

github-actions bot commented Apr 25, 2023 • edited Loading

github-actions bot commented Apr 25, 2023 • edited Loading

codecov-commenter commented May 1, 2023 • edited Loading

Codecov Report

farzin-deriv left a comment

Choose a reason for hiding this comment

farzin-deriv May 5, 2023

Choose a reason for hiding this comment

farzin-deriv May 5, 2023

Choose a reason for hiding this comment

aum-deriv May 5, 2023

Choose a reason for hiding this comment

henry-deriv May 5, 2023

Choose a reason for hiding this comment

aum-deriv May 5, 2023

Choose a reason for hiding this comment

henry-deriv May 6, 2023

Choose a reason for hiding this comment

henry-deriv May 5, 2023

Choose a reason for hiding this comment

sonarcloud bot commented May 8, 2023

vercel bot commented Apr 25, 2023 •

edited

Loading

github-actions bot commented Apr 25, 2023 •

edited

Loading

github-actions bot commented Apr 25, 2023 •

edited

Loading

codecov-commenter commented May 1, 2023 •

edited

Loading