henry/93321/fix: unable to view chart for digit contracts in mobile for non tick … #8356
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
A production App ID was automatically generated for this PR. (log)
Click here to copy & paste above information. |
|
🚨 Lighthouse report for the changes in this PR:
Lighthouse ran with https://deriv-app-git-fork-henry-deriv-henry-93321charts-empty-f-7d4a40.binary.sx/ |
…3321/charts-empty-for-1min-and-above-for-digits
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## master #8356 +/- ##
==========================================
- Coverage 20.86% 20.85% -0.02%
==========================================
Files 1553 1553
Lines 36062 36062
Branches 7065 7066 +1
==========================================
- Hits 7525 7521 -4
- Misses 27795 27799 +4
Partials 742 742
|
matin-deriv
previously approved these changes
Apr 27, 2023
…3321/charts-empty-for-1min-and-above-for-digits
balakrishna-deriv
previously approved these changes
Apr 28, 2023
akmal-deriv
previously approved these changes
Apr 28, 2023
henry-deriv
dismissed stale reviews from akmal-deriv, balakrishna-deriv, and matin-deriv
via
502a969
maryia-deriv
approved these changes
Apr 28, 2023
balakrishna-deriv
approved these changes
Apr 28, 2023
…3321/charts-empty-for-1min-and-above-for-digits
|
Kudos, SonarCloud Quality Gate passed!
|
henry-deriv
deleted the
henry/93321/charts-empty-for-1min-and-above-for-digits
branch
nijil-deriv
pushed a commit
to nijil-deriv/deriv-app
that referenced
this pull request
May 24, 2023
…or non tick … (binary-com#8356) * fix: unable to view chart for digit contracts in mobile for non tick streams * fix: include accumualtors in the change * fix: add brackets for readability * fix: bug * refactor: naming --------- Co-authored-by: Sandeep Rajput <90243468+sandeep-deriv@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…streams
Changes:
Please include a summary of the change and which issue is fixed below:
When you need to add unit test
When you need to add integration test
Test coverage checklist (for reviewer)
Type of change