Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Kate / Test coverage + TS migration: Components/Elements/Media files in Trader package #8457

Merged
merged 18 commits into from
Sep 26, 2023
Merged

Kate / Test coverage + TS migration: Components/Elements/Media files in Trader package #8457

merged 18 commits into from
Sep 26, 2023

Conversation

kate-deriv
Copy link
Contributor

Changes:

  • TS + tests for media-description.jsx, media-heading.jsx, media-icon.jsx, media-item.jsx file

When you need to add unit test

  • If this change disrupt current flow
  • If this change is adding new flow

When you need to add integration test

  • If components from external libraries are being used to define the flow, e.g. @deriv/components
  • If it relies on a very specific set of props with no default behavior for the current component.

Test coverage checklist (for reviewer)

  • Ensure utility / function has a test case
  • Ensure all the tests are passing

Type of change

  • Bug fix
  • New feature
  • Update feature
  • Refactor code
  • Translation to code
  • Translation to crowdin
  • Script configuration
  • Improve performance
  • Style only
  • Dependency update
  • Documentation update
  • Release

@boring-cyborg boring-cyborg bot added the Trader label May 3, 2023
@vercel
Copy link

vercel bot commented May 3, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
deriv-app ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 14, 2023 0:45am

@github-actions
Copy link
Contributor

github-actions bot commented May 3, 2023 •
edited
Loading

A production App ID was automatically generated for this PR. (log)

Click here to copy & paste above information. 
- **PR**: [https://github.com/binary-com/deriv-app/pull/8457](https://github.com/binary-com/deriv-app/pull/8457)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-kate-deriv-kate-861mqfn8emediateststs.binary.sx?qa_server=red.binaryws.com&app_id=23847
    - **Original**: https://deriv-app-git-fork-kate-deriv-kate-861mqfn8emediateststs.binary.sx
- **App ID**: `23847`

@github-actions
Copy link
Contributor

github-actions bot commented May 3, 2023 •
edited
Loading

🚨 Lighthouse report for the changes in this PR:

Category Score
🔺 Performance 17
🟧 Accessibility 75
🟢 Best practices 92
🟧 SEO 85
🟢 PWA 90

Lighthouse ran with https://deriv-app-git-fork-kate-deriv-kate-861mqfn8emediateststs.binary.sx/

@codecov-commenter
Copy link

codecov-commenter commented May 4, 2023 •
edited by codecov bot
Loading

Codecov Report

Merging #8457 (e72ce54) into master (d5c38a0) will increase coverage by 20.02%.
Report is 347 commits behind head on master.
The diff coverage is 100.00%.

❗ Current head e72ce54 differs from pull request most recent head 9005a05. Consider uploading reports for the commit 9005a05 to get more accurate results

@@             Coverage Diff             @@
##           master    #8457       +/-   ##
===========================================
+ Coverage    0.05%   20.08%   +20.02%     
===========================================
  Files         117     1827     +1710     
  Lines        3425    41459    +38034     
  Branches      893     8240     +7347     
===========================================
+ Hits            2     8328     +8326     
- Misses       3423    32271    +28848     
- Partials        0      860      +860
Files Changed Coverage Δ
...unt/src/Components/forms/personal-details-form.jsx 80.86% <ø> (ø)
...pp/Components/Elements/Media/media-description.tsx 100.00% <100.00%> (ø)
...rc/App/Components/Elements/Media/media-heading.tsx 100.00% <100.00%> (ø)
...r/src/App/Components/Elements/Media/media-icon.tsx 100.00% <100.00%> (ø)
...r/src/App/Components/Elements/Media/media-item.tsx 100.00% <100.00%> (ø)

... and 1815 files with indirect coverage changes

henry-deriv
henry-deriv reviewed May 5, 2023
View reviewed changes
Copy link
Contributor

@henry-deriv henry-deriv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM

packages/trader/src/App/Components/Elements/Media/__tests__/media.spec.tsx Outdated Show resolved Hide resolved
packages/trader/src/App/Components/Elements/Media/media-icon.tsx Outdated Show resolved Hide resolved
farzin-deriv
farzin-deriv previously approved these changes May 5, 2023
View reviewed changes
maryia-deriv
maryia-deriv reviewed May 10, 2023
View reviewed changes
types/svg.d.ts Outdated Show resolved Hide resolved
@gitguardian
Copy link

gitguardian bot commented Jun 15, 2023 •
edited
Loading

⚠️ GitGuardian has uncovered 2 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id Secret Commit Filename
- Generic High Entropy Secret c5b41c5 packages/account/src/Components/currency-selector/tests/currency-selector.spec.tsx View secret
- Generic High Entropy Secret c5b41c5 packages/account/src/Components/currency-selector/tests/currency-selector.spec.tsx View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secrets safely. Learn here the best practices.
  3. Revoke and rotate these secrets.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider

🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!

@sonarcloud
Copy link

sonarcloud bot commented Jun 17, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@github-actions
Copy link
Contributor

github-actions bot commented Jun 17, 2023 •
edited
Loading

⏳ Generating Lighthouse report...

@sonarcloud
Copy link

sonarcloud bot commented Jul 26, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@coveralls
Copy link

Coverage Status

coverage: 8.89% (+0.006%) from 8.884% when pulling 1977e1b on kate-deriv:kate/861mqfn8e_media_tests_ts into 0553c82 on binary-com:master.

@sonarcloud
Copy link

sonarcloud bot commented Sep 14, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@DerivFE DerivFE merged commit c2c44e7 into binary-com:master Sep 26, 2023
4 of 5 checks passed
@DerivFE
Copy link
Collaborator

DerivFE commented Sep 26, 2023

✨ PR has been merged by Paimon the Release Bot

vinu-deriv pushed a commit that referenced this pull request Oct 10, 2023
@kate-deriv @vinu-deriv
Kate / Test coverage + TS migration: Components/Elements/Media files …
d4b18a9 
…in Trader package (#8457)

* refactor: ts migration and tess for media

* fix: change path for import

* refactor: change type for svg

* chore: remove file type from imports

* refactor: replace svg in test

* refactor: implemented suggestion from review

* fix: replace old type in svg d ts

* refactor: replace react.fc

* refactor: ts of index file
vinu-deriv pushed a commit that referenced this pull request Oct 10, 2023
@kate-deriv @vinu-deriv
Kate / Test coverage + TS migration: Components/Elements/Media files …
4e4a99b 
…in Trader package (#8457)

* refactor: ts migration and tess for media

* fix: change path for import

* refactor: change type for svg

* chore: remove file type from imports

* refactor: replace svg in test

* refactor: implemented suggestion from review

* fix: replace old type in svg d ts

* refactor: replace react.fc

* refactor: ts of index file
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hamza-deriv hamza-deriv hamza-deriv left review comments

@maryia-deriv maryia-deriv maryia-deriv approved these changes

@henry-deriv henry-deriv henry-deriv approved these changes

@farzin-deriv farzin-deriv farzin-deriv left review comments

@yashim-deriv yashim-deriv Awaiting requested review from yashim-deriv

@matin-deriv matin-deriv Awaiting requested review from matin-deriv matin-deriv is a code owner

Assignees
No one assigned
Labels
Account Trader
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@kate-deriv @codecov-commenter @coveralls @DerivFE @farzin-deriv @maryia-deriv @henry-deriv @hamza-deriv