Shaheer/90982/personal details spec #8487
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
A production App ID was automatically generated for this PR. (log)
Click here to copy & paste above information. |
|
🚨 Lighthouse report for the changes in this PR:
Lighthouse ran with https://deriv-app-git-fork-shaheer-deriv-shaheer-90982personal-d-b0fc2e.binary.sx/ |
| @@ -652,6 +653,7 @@ export const PersonalDetailsForm = ({ | |||
| disabled={!isChangeableField('first_name')} | |||
| error={errors.first_name} | |||
| id={'first_name'} | |||
| data-testid='first_name' | |||
There was a problem hiding this comment.
| data-testid='first_name' | |
| data-testid='dt_first_name' |
Use dt in front of every data-testid declaration
| @@ -665,6 +667,7 @@ export const PersonalDetailsForm = ({ | |||
| required | |||
| disabled={!isChangeableField('last_name')} | |||
| error={errors.last_name} | |||
| data-testid='last_name' | |||
There was a problem hiding this comment.
| data-testid='last_name' | |
| data-testid='dt_last_name' |
| @@ -682,6 +685,7 @@ export const PersonalDetailsForm = ({ | |||
| required | |||
| disabled={!isChangeableField('first_name')} | |||
| error={errors.first_name} | |||
| data-testid='first_name' | |||
There was a problem hiding this comment.
| data-testid='first_name' | |
| data-testid='dt_first_name' |
| @@ -697,6 +701,7 @@ export const PersonalDetailsForm = ({ | |||
| required | |||
| disabled={!isChangeableField('last_name')} | |||
| error={errors.last_name} | |||
| data-testid='last_name' | |||
There was a problem hiding this comment.
| data-testid='last_name' | |
| data-testid='dt_last_name' |
| @@ -872,6 +877,7 @@ export const PersonalDetailsForm = ({ | |||
| onBlur={handleBlur} | |||
| required | |||
| error={errors.phone} | |||
| data-testid='phone' | |||
There was a problem hiding this comment.
| data-testid='phone' | |
| data-testid='dt_phone' |
| @@ -1007,6 +1013,7 @@ export const PersonalDetailsForm = ({ | |||
| error={errors.address_line_1} | |||
| required | |||
| disabled={!isChangeableField('address_line_1')} | |||
| data-testid='address_line_1' | |||
There was a problem hiding this comment.
| data-testid='address_line_1' | |
| data-testid='dt_address_line_1' |
| @@ -1040,6 +1047,7 @@ export const PersonalDetailsForm = ({ | |||
| onBlur={handleBlur} | |||
| required | |||
| disabled={!isChangeableField('address_city')} | |||
| data-testid='address_city' | |||
There was a problem hiding this comment.
| data-testid='address_city' | |
| data-testid='dt_address_city' |
Codecov Report
@@ Coverage Diff @@
## master #8487 +/- ##
===========================================
+ Coverage 0.05% 20.67% +20.61%
===========================================
Files 117 1635 +1518
Lines 3425 36990 +33565
Branches 893 7367 +6474
===========================================
+ Hits 2 7647 +7645
- Misses 3423 28585 +25162
- Partials 0 758 +758
|
|
Kudos, SonarCloud Quality Gate passed!
|
|
| GitGuardian id | Secret | Commit | Filename | |
|---|---|---|---|---|
| - | Generic High Entropy Secret | 97b4947 | packages/account/src/Components/currency-selector/tests/currency-selector.spec.tsx | View secret |
| - | Generic High Entropy Secret | 97b4947 | packages/account/src/Components/currency-selector/tests/currency-selector.spec.tsx | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secrets safely. Learn here the best practices.
- Revoke and rotate these secrets.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
Our GitHub checks need improvements? Share your feedbacks!
|
Kudos, SonarCloud Quality Gate passed!
|
Pull Request Test Coverage Report for Build 5444390313
💛 - Coveralls |
|
⏳ Generating Lighthouse report... |
|
✨ PR has been merged by Paimon the Release Bot |
Changes:
Please include a summary of the change and which issue is fixed below:
When you need to add unit test
When you need to add integration test
Test coverage checklist (for reviewer)
Type of change