Shayan/feq116/add test for exchange rates hooks #8491

shayan-deriv · 2023-05-07T08:07:24Z

Changes:

Please include a summary of the change and which issue is fixed below:

...

When you need to add unit test

If this change disrupt current flow
If this change is adding new flow

When you need to add integration test

If components from external libraries are being used to define the flow, e.g. @deriv/components
If it relies on a very specific set of props with no default behavior for the current component.

Test coverage checklist (for reviewer)

Ensure utility / function has a test case
Ensure all the tests are passing

Type of change

…rzin-deriv]

…hub.com:shayan-deriv/deriv-app; branch 'master' of github.com:binary-com/deriv-app into shayan/feq116/add_test_for_exchange_rates_hooks

…feq116/add_test_for_exchange_rates_hooks

vercel · 2023-05-07T08:07:28Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
deriv-app	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	May 10, 2023 5:16am

github-actions · 2023-05-07T08:24:04Z

A production App ID was automatically generated for this PR. (log)

PR: Shayan/feq116/add test for exchange rates hooks #8491
URLs:
- w/ App ID + Server: https://deriv-app-git-fork-shayan-deriv-shayan-feq116addtestfore-c47365.binary.sx?qa_server=red.binaryws.com&app_id=23831
- Original: https://deriv-app-git-fork-shayan-deriv-shayan-feq116addtestfore-c47365.binary.sx
App ID: 23831

Click here to copy & paste above information.

- **PR**: [https://github.com/binary-com/deriv-app/pull/8491](https://github.com/binary-com/deriv-app/pull/8491)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-shayan-deriv-shayan-feq116addtestfore-c47365.binary.sx?qa_server=red.binaryws.com&app_id=23831
    - **Original**: https://deriv-app-git-fork-shayan-deriv-shayan-feq116addtestfore-c47365.binary.sx
- **App ID**: `23831`

github-actions · 2023-05-07T08:24:30Z

🚨 Lighthouse report for the changes in this PR:

Category	Score
🔺 Performance	18
🟧 Accessibility	75
🟢 Best practices	92
🟧 SEO	85
🟢 PWA	90

Lighthouse ran with https://deriv-app-git-fork-shayan-deriv-shayan-feq116addtestfore-c47365.binary.sx/

codecov-commenter · 2023-05-07T21:48:09Z

Codecov Report

Merging #8491 (1254f64) into master (b51a956) will increase coverage by 0.19%.
The diff coverage is 55.55%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@            Coverage Diff             @@
##           master    #8491      +/-   ##
==========================================
+ Coverage   20.81%   21.01%   +0.19%     
==========================================
  Files        1561     1561              
  Lines       36119    36120       +1     
  Branches     7091     7093       +2     
==========================================
+ Hits         7518     7589      +71     
+ Misses      27859    27781      -78     
- Partials      742      750       +8

Impacted Files	Coverage Δ
packages/hooks/src/useTotalAccountBalance.ts	`70.00% <0.00%> (+70.00%)`	⬆️
packages/stores/src/mockStore.ts	`0.00% <0.00%> (ø)`
packages/stores/src/storeProvider.tsx	`88.88% <75.00%> (-11.12%)`	⬇️
packages/hooks/src/useCFDAccounts.ts	`100.00% <100.00%> (ø)`

... and 9 files with indirect coverage changes

packages/hooks/src/__tests__/usePlatformRealAccounts.spec.tsx

packages/hooks/src/__tests__/usePlatformDemoAccount.spec.tsx

packages/hooks/src/__tests__/usePlatformAccounts.spec.tsx

packages/hooks/src/__tests__/useTotalAssetCurrency.spec.tsx

packages/hooks/src/__tests__/useCFDAccounts.spec.tsx

packages/hooks/src/__tests__/useGetCfdAccounts.spec.tsx

Co-authored-by: Farzin Mirzaie <72082844+farzin-deriv@users.noreply.github.com>

…hooks

packages/hooks/src/__tests__/useCFDAccounts.spec.tsx

packages/hooks/src/useCFDAccounts.ts

…hooks

sonarcloud · 2023-05-10T05:07:32Z

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
29.7% Duplication

github-actions · 2023-05-10T05:27:54Z

⏳ Generating Lighthouse report...

* feat: adding new tests [WIP] * fix: updated exchange_store provider for test files[co-authored by farzin-deriv] * feat: new tests added [WIP] * feat: useTotalCurrency's test added * feat: test for useGetCfdAccounts added * fix: adding remaining tests [WIP] * feat: new tests added * feat: new test added * fix: fixing failed tests [WIP] * feat: all tsts added * Update packages/hooks/src/__tests__/usePlatformDemoAccount.spec.tsx Co-authored-by: Farzin Mirzaie <72082844+farzin-deriv@users.noreply.github.com> * Update packages/hooks/src/__tests__/usePlatformAccounts.spec.tsx Co-authored-by: Farzin Mirzaie <72082844+farzin-deriv@users.noreply.github.com> * Update packages/hooks/src/__tests__/usePlatformAccounts.spec.tsx Co-authored-by: Farzin Mirzaie <72082844+farzin-deriv@users.noreply.github.com> * Update packages/hooks/src/__tests__/useTotalAssetCurrency.spec.tsx Co-authored-by: Farzin Mirzaie <72082844+farzin-deriv@users.noreply.github.com> * Update packages/hooks/src/__tests__/useCFDAccounts.spec.tsx Co-authored-by: Farzin Mirzaie <72082844+farzin-deriv@users.noreply.github.com> * Update packages/hooks/src/__tests__/useCFDAccounts.spec.tsx Co-authored-by: Farzin Mirzaie <72082844+farzin-deriv@users.noreply.github.com> * Update packages/hooks/src/__tests__/useCFDAccounts.spec.tsx Co-authored-by: Farzin Mirzaie <72082844+farzin-deriv@users.noreply.github.com> * Update packages/hooks/src/__tests__/useCFDAccounts.spec.tsx Co-authored-by: Farzin Mirzaie <72082844+farzin-deriv@users.noreply.github.com> * fix: resolved pr comments * Update packages/hooks/src/__tests__/useTotalAssetCurrency.spec.tsx Co-authored-by: Farzin Mirzaie <72082844+farzin-deriv@users.noreply.github.com> * Update packages/hooks/src/__tests__/useTotalAssetCurrency.spec.tsx Co-authored-by: Farzin Mirzaie <72082844+farzin-deriv@users.noreply.github.com> * Update packages/hooks/src/__tests__/useTotalAssetCurrency.spec.tsx Co-authored-by: Farzin Mirzaie <72082844+farzin-deriv@users.noreply.github.com> * Update packages/hooks/src/__tests__/useTotalAssetCurrency.spec.tsx Co-authored-by: Farzin Mirzaie <72082844+farzin-deriv@users.noreply.github.com> * Update packages/hooks/src/__tests__/useTotalAssetCurrency.spec.tsx Co-authored-by: Farzin Mirzaie <72082844+farzin-deriv@users.noreply.github.com> * Update packages/hooks/src/__tests__/useTotalAssetCurrency.spec.tsx Co-authored-by: Farzin Mirzaie <72082844+farzin-deriv@users.noreply.github.com> * Update packages/hooks/src/__tests__/useTotalAssetCurrency.spec.tsx Co-authored-by: Farzin Mirzaie <72082844+farzin-deriv@users.noreply.github.com> * Update packages/hooks/src/__tests__/useTotalAssetCurrency.spec.tsx Co-authored-by: Farzin Mirzaie <72082844+farzin-deriv@users.noreply.github.com> * Update packages/hooks/src/__tests__/useCFDRealAccounts.spec.tsx Co-authored-by: Farzin Mirzaie <72082844+farzin-deriv@users.noreply.github.com> * Update packages/hooks/src/__tests__/useTotalAccountBalance.spec.tsx Co-authored-by: Farzin Mirzaie <72082844+farzin-deriv@users.noreply.github.com> * Update packages/hooks/src/__tests__/useCFDAllAccounts.spec.tsx Co-authored-by: Farzin Mirzaie <72082844+farzin-deriv@users.noreply.github.com> * Update packages/hooks/src/__tests__/useCFDAllAccounts.spec.tsx Co-authored-by: Farzin Mirzaie <72082844+farzin-deriv@users.noreply.github.com> * Update packages/hooks/src/__tests__/useCFDAllAccounts.spec.tsx Co-authored-by: Farzin Mirzaie <72082844+farzin-deriv@users.noreply.github.com> * Update packages/hooks/src/__tests__/useCFDDemoAccounts.spec.tsx Co-authored-by: Farzin Mirzaie <72082844+farzin-deriv@users.noreply.github.com> * Update packages/hooks/src/__tests__/useCFDDemoAccounts.spec.tsx Co-authored-by: Farzin Mirzaie <72082844+farzin-deriv@users.noreply.github.com> * Update packages/hooks/src/__tests__/useCFDDemoAccounts.spec.tsx Co-authored-by: Farzin Mirzaie <72082844+farzin-deriv@users.noreply.github.com> * Update packages/hooks/src/__tests__/useCFDRealAccounts.spec.tsx Co-authored-by: Farzin Mirzaie <72082844+farzin-deriv@users.noreply.github.com> * Update packages/hooks/src/__tests__/useCFDRealAccounts.spec.tsx Co-authored-by: Farzin Mirzaie <72082844+farzin-deriv@users.noreply.github.com> * fix: fixed ts error in useTotalAccountBalance hook * fix: resolved pr comment * chore: renamed hook --------- Co-authored-by: Farzin Mirzaie <72082844+farzin-deriv@users.noreply.github.com>

Shayan Khaleghparast added 9 commits April 28, 2023 19:25

feat: adding new tests [WIP]

6b0bfd1

fix: updated exchange_store provider for test files[co-authored by fa…

a5d5cee

…rzin-deriv]

Merge branch 'shayan/feq116/add_test_for_exchange_rates_hooks' of git…

5be1c6f

…hub.com:shayan-deriv/deriv-app; branch 'master' of github.com:binary-com/deriv-app into shayan/feq116/add_test_for_exchange_rates_hooks

feat: new tests added [WIP]

a76a9d4

feat: useTotalCurrency's test added

bcebab8

feat: test for useGetCfdAccounts added

a23fe81

fix: adding remaining tests [WIP]

4a10f43

Merge branch 'master' of github.com:binary-com/deriv-app into shayan/…

1d1e3ae

…feq116/add_test_for_exchange_rates_hooks

Merge branch 'master' of github.com:binary-com/deriv-app into shayan/…

310fcbc

…feq116/add_test_for_exchange_rates_hooks

vercel bot deployed to Preview May 7, 2023 08:23 View deployment

feat: new tests added

a03c915

vercel bot deployed to Preview May 7, 2023 09:06 View deployment

feat: new test added

83f2e71

vercel bot deployed to Preview May 7, 2023 09:27 View deployment

fix: fixing failed tests [WIP]

cc55e68

vercel bot deployed to Preview May 7, 2023 10:08 View deployment

feat: all tsts added

0655e75

shayan-deriv marked this pull request as ready for review May 7, 2023 21:29

vercel bot deployed to Preview May 7, 2023 21:39 View deployment

farzin-deriv reviewed May 8, 2023

View reviewed changes

shayan-deriv and others added 6 commits May 8, 2023 10:21

Update packages/hooks/src/__tests__/usePlatformDemoAccount.spec.tsx

58b8a65

Co-authored-by: Farzin Mirzaie <72082844+farzin-deriv@users.noreply.github.com>

Update packages/hooks/src/__tests__/usePlatformAccounts.spec.tsx

b21bb6a

Co-authored-by: Farzin Mirzaie <72082844+farzin-deriv@users.noreply.github.com>

Update packages/hooks/src/__tests__/usePlatformAccounts.spec.tsx

f3fb37e

Co-authored-by: Farzin Mirzaie <72082844+farzin-deriv@users.noreply.github.com>

Update packages/hooks/src/__tests__/useTotalAssetCurrency.spec.tsx

804a20b

Co-authored-by: Farzin Mirzaie <72082844+farzin-deriv@users.noreply.github.com>

Update packages/hooks/src/__tests__/useCFDAccounts.spec.tsx

19c30ed

Co-authored-by: Farzin Mirzaie <72082844+farzin-deriv@users.noreply.github.com>

Update packages/hooks/src/__tests__/useCFDAccounts.spec.tsx

07fdd7a

Co-authored-by: Farzin Mirzaie <72082844+farzin-deriv@users.noreply.github.com>

shayan-deriv and others added 13 commits May 8, 2023 12:01

Update packages/hooks/src/__tests__/useTotalAssetCurrency.spec.tsx

4e421d2

Co-authored-by: Farzin Mirzaie <72082844+farzin-deriv@users.noreply.github.com>

Update packages/hooks/src/__tests__/useTotalAssetCurrency.spec.tsx

52aeae5

Co-authored-by: Farzin Mirzaie <72082844+farzin-deriv@users.noreply.github.com>

Update packages/hooks/src/__tests__/useCFDRealAccounts.spec.tsx

5cf0016

Co-authored-by: Farzin Mirzaie <72082844+farzin-deriv@users.noreply.github.com>

Update packages/hooks/src/__tests__/useTotalAccountBalance.spec.tsx

b99b328

Co-authored-by: Farzin Mirzaie <72082844+farzin-deriv@users.noreply.github.com>

Update packages/hooks/src/__tests__/useCFDAllAccounts.spec.tsx

0a1eaae

Co-authored-by: Farzin Mirzaie <72082844+farzin-deriv@users.noreply.github.com>

Update packages/hooks/src/__tests__/useCFDAllAccounts.spec.tsx

8fe111e

Co-authored-by: Farzin Mirzaie <72082844+farzin-deriv@users.noreply.github.com>

Update packages/hooks/src/__tests__/useCFDAllAccounts.spec.tsx

eb1b1f6

Co-authored-by: Farzin Mirzaie <72082844+farzin-deriv@users.noreply.github.com>

Update packages/hooks/src/__tests__/useCFDDemoAccounts.spec.tsx

1df7e8a

Co-authored-by: Farzin Mirzaie <72082844+farzin-deriv@users.noreply.github.com>

Update packages/hooks/src/__tests__/useCFDDemoAccounts.spec.tsx

e230aa0

Co-authored-by: Farzin Mirzaie <72082844+farzin-deriv@users.noreply.github.com>

Update packages/hooks/src/__tests__/useCFDDemoAccounts.spec.tsx

65250c0

Co-authored-by: Farzin Mirzaie <72082844+farzin-deriv@users.noreply.github.com>

Update packages/hooks/src/__tests__/useCFDRealAccounts.spec.tsx

93c7e44

Co-authored-by: Farzin Mirzaie <72082844+farzin-deriv@users.noreply.github.com>

Update packages/hooks/src/__tests__/useCFDRealAccounts.spec.tsx

f2d01ce

Co-authored-by: Farzin Mirzaie <72082844+farzin-deriv@users.noreply.github.com>

Merge branch 'master' into shayan/feq116/add_test_for_exchange_rates_…

ab6b61a

…hooks

vercel bot deployed to Preview May 8, 2023 09:23 View deployment

fix: fixed ts error in useTotalAccountBalance hook

7721872

vercel bot deployed to Preview May 8, 2023 09:42 View deployment

fix: resolved pr comment

64c13c1

boring-cyborg bot added the AppStore label May 8, 2023

farzin-deriv reviewed May 8, 2023

View reviewed changes

vercel bot deployed to Preview May 8, 2023 10:17 View deployment

chore: renamed hook

fb52581

farzin-deriv approved these changes May 8, 2023

View reviewed changes

vercel bot deployed to Preview May 8, 2023 10:43 View deployment

Merge branch 'master' into shayan/feq116/add_test_for_exchange_rates_…

1254f64

…hooks

vercel bot deployed to Preview May 10, 2023 05:16 View deployment

sandeep-deriv merged commit b3a8935 into binary-com:master May 10, 2023

shayan-deriv deleted the shayan/feq116/add_test_for_exchange_rates_hooks branch January 12, 2024 04:36

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Shayan/feq116/add test for exchange rates hooks #8491

Shayan/feq116/add test for exchange rates hooks #8491

shayan-deriv commented May 7, 2023

vercel bot commented May 7, 2023 •

edited

Loading

github-actions bot commented May 7, 2023 •

edited

Loading

github-actions bot commented May 7, 2023 •

edited

Loading

codecov-commenter commented May 7, 2023 •

edited

Loading

sonarcloud bot commented May 10, 2023

github-actions bot commented May 10, 2023

Shayan/feq116/add test for exchange rates hooks #8491

Shayan/feq116/add test for exchange rates hooks #8491

Conversation

shayan-deriv commented May 7, 2023

Changes:

When you need to add unit test

When you need to add integration test

Test coverage checklist (for reviewer)

Type of change

vercel bot commented May 7, 2023 • edited Loading

github-actions bot commented May 7, 2023 • edited Loading

github-actions bot commented May 7, 2023 • edited Loading

codecov-commenter commented May 7, 2023 • edited Loading

Codecov Report

sonarcloud bot commented May 10, 2023

github-actions bot commented May 10, 2023

vercel bot commented May 7, 2023 •

edited

Loading

github-actions bot commented May 7, 2023 •

edited

Loading

github-actions bot commented May 7, 2023 •

edited

Loading

codecov-commenter commented May 7, 2023 •

edited

Loading