Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Farzin/94405/Deriv P2P tab is not loading for first time login in mobile #8513

Conversation

farzin-deriv
Copy link
Contributor

Changes:

Please include a summary of the change and which issue is fixed below:

  • ...

When you need to add unit test

  • If this change disrupt current flow
  • If this change is adding new flow

When you need to add integration test

  • If components from external libraries are being used to define the flow, e.g. @deriv/components
  • If it relies on a very specific set of props with no default behavior for the current component.

Test coverage checklist (for reviewer)

  • Ensure utility / function has a test case
  • Ensure all the tests are passing

Type of change

  • Bug fix
  • New feature
  • Update feature
  • Refactor code
  • Translation to code
  • Translation to crowdin
  • Script configuration
  • Improve performance
  • Style only
  • Dependency update
  • Documentation update
  • Release

@boring-cyborg boring-cyborg bot added the Core label May 9, 2023
@vercel
Copy link

vercel bot commented May 9, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
deriv-app ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 9, 2023 3:53am

@sonarcloud
Copy link

sonarcloud bot commented May 9, 2023

Please retry analysis of this Pull-Request directly on SonarCloud.

@farzin-deriv farzin-deriv marked this pull request as ready for review May 9, 2023 03:28
@github-actions
Copy link
Contributor

github-actions bot commented May 9, 2023

A production App ID was automatically generated for this PR. (log)

Click here to copy & paste above information.
- **PR**: [https://github.com/binary-com/deriv-app/pull/8513](https://github.com/binary-com/deriv-app/pull/8513)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-farzin-deriv-farzin-94405derivp2ptabi-c2b685.binary.sx?qa_server=red.binaryws.com&app_id=32758
    - **Original**: https://deriv-app-git-fork-farzin-deriv-farzin-94405derivp2ptabi-c2b685.binary.sx
- **App ID**: `32758`

@github-actions
Copy link
Contributor

github-actions bot commented May 9, 2023

A production App ID was automatically generated for this PR. (log)

Click here to copy & paste above information.
- **PR**: [https://github.com/binary-com/deriv-app/pull/8513](https://github.com/binary-com/deriv-app/pull/8513)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-farzin-deriv-farzin-94405derivp2ptabi-c2b685.binary.sx?qa_server=red.binaryws.com&app_id=32758
    - **Original**: https://deriv-app-git-fork-farzin-deriv-farzin-94405derivp2ptabi-c2b685.binary.sx
- **App ID**: `32758`

@github-actions
Copy link
Contributor

github-actions bot commented May 9, 2023

🚨 Lighthouse report for the changes in this PR:

Category Score
🔺 Performance 21
🟧 Accessibility 75
🟢 Best practices 92
🟧 SEO 85
🟢 PWA 90

Lighthouse ran with https://deriv-app-git-fork-farzin-deriv-farzin-94405derivp2ptabi-c2b685.binary.sx/

Copy link
Contributor

@ameerul-deriv ameerul-deriv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-commenter
Copy link

Codecov Report

Merging #8513 (e4abc97) into master (2bdbc5c) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##           master    #8513      +/-   ##
==========================================
- Coverage   20.81%   20.81%   -0.01%     
==========================================
  Files        1560     1561       +1     
  Lines       36115    36119       +4     
  Branches     7091     7091              
==========================================
  Hits         7518     7518              
- Misses      27855    27859       +4     
  Partials      742      742              
Impacted Files Coverage Δ
packages/core/src/App/app.jsx 0.00% <0.00%> (ø)

... and 1 file with indirect coverage changes

@sandeep-deriv sandeep-deriv merged commit fc43eb8 into binary-com:master May 9, 2023
@farzin-deriv farzin-deriv deleted the farzin/94405/deriv_p2p_tab_is_not_loading_for_first_time_login_in_mobile branch May 9, 2023 05:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants