Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ako/ add ability to track staging and production with different service names #8537

Conversation

ali-hosseini-deriv
Copy link
Member

Changes:

This is to separate service name on staging and production to have more accurate data on datadog

Screenshots:

Please provide some screenshots of the change.

@boring-cyborg boring-cyborg bot added the Core label May 10, 2023
@vercel
Copy link

vercel bot commented May 10, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
deriv-app 🛑 Canceled (Inspect) May 10, 2023 8:20am

@sonarcloud
Copy link

sonarcloud bot commented May 10, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
3.2% 3.2% Duplication

@codecov-commenter
Copy link

codecov-commenter commented May 10, 2023

Codecov Report

Merging #8537 (87f2f59) into master (57abe5f) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@            Coverage Diff             @@
##           master    #8537      +/-   ##
==========================================
- Coverage   20.80%   20.80%   -0.01%     
==========================================
  Files        1560     1560              
  Lines       36079    36094      +15     
  Branches     7080     7083       +3     
==========================================
  Hits         7508     7508              
- Misses      27829    27844      +15     
  Partials      742      742              
Impacted Files Coverage Δ
packages/core/build/constants.js 0.00% <ø> (ø)
packages/core/src/Utils/Datadog/index.ts 0.00% <0.00%> (ø)

@github-actions
Copy link
Contributor

github-actions bot commented May 10, 2023

Generating Lighthouse report...

@sandeep-deriv sandeep-deriv merged commit 385f36d into binary-com:master May 10, 2023
nijil-deriv pushed a commit to nijil-deriv/deriv-app that referenced this pull request May 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants