Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "thisyahlen/chore: add test coverage in asset-summary" #8552

Conversation

sandeep-deriv
Copy link
Contributor

Reverts #8329

@vercel
Copy link

vercel bot commented May 10, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
deriv-app ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 10, 2023 9:13am

@sonarcloud
Copy link

sonarcloud bot commented May 10, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@codecov-commenter
Copy link

Codecov Report

Merging #8552 (eee0ba9) into master (b3a8935) will decrease coverage by 0.44%.
The diff coverage is 78.94%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@            Coverage Diff             @@
##           master    #8552      +/-   ##
==========================================
- Coverage   20.99%   20.56%   -0.44%     
==========================================
  Files        1560     1634      +74     
  Lines       36082    36964     +882     
  Branches     7082     7361     +279     
==========================================
+ Hits         7575     7600      +25     
- Misses      27757    28612     +855     
- Partials      750      752       +2     
Impacted Files Coverage Δ
packages/stores/src/mockStore.ts 0.00% <ø> (ø)
...tore/src/components/elements/text/balance-text.tsx 90.00% <50.00%> (ø)
...ponents/containers/currency-switcher-container.tsx 82.35% <82.35%> (ø)

... and 72 files with indirect coverage changes

@github-actions
Copy link
Contributor

A production App ID was automatically generated for this PR. (log)

Click here to copy & paste above information.
- **PR**: [https://github.com/binary-com/deriv-app/pull/8552](https://github.com/binary-com/deriv-app/pull/8552)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-revert-8329-thisyahlen-wall-429asset-summa-5020d7.binary.sx?qa_server=red.binaryws.com&app_id=31898
    - **Original**: https://deriv-app-git-revert-8329-thisyahlen-wall-429asset-summa-5020d7.binary.sx
- **App ID**: `31898`

@github-actions
Copy link
Contributor

🚨 Lighthouse report for the changes in this PR:

Category Score
🔺 Performance 19
🟧 Accessibility 75
🟢 Best practices 92
🟧 SEO 85
🟢 PWA 90

Lighthouse ran with https://deriv-app-git-revert-8329-thisyahlen-wall-429asset-summa-5020d7.binary.sx/

@sandeep-deriv sandeep-deriv merged commit 5a26ad8 into master May 10, 2023
nijil-deriv pushed a commit to nijil-deriv/deriv-app that referenced this pull request May 24, 2023
@ali-hosseini-deriv ali-hosseini-deriv deleted the revert-8329-thisyahlen/WALL-429/asset-summary-test-coverage branch August 16, 2024 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants