Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ako/ Distinguish dd staging logs #8569

Conversation

ali-hosseini-deriv
Copy link
Member

Changes:

We will have different datadog environments based on production or staging values.

Screenshots:

Please provide some screenshots of the change.

@boring-cyborg boring-cyborg bot added the Core label May 11, 2023
@vercel
Copy link

vercel bot commented May 11, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
deriv-app ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 11, 2023 4:05am

@sonarcloud
Copy link

sonarcloud bot commented May 11, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
4.9% 4.9% Duplication

@github-actions
Copy link
Contributor

A production App ID was automatically generated for this PR. (log)

Click here to copy & paste above information.
- **PR**: [https://github.com/binary-com/deriv-app/pull/8569](https://github.com/binary-com/deriv-app/pull/8569)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-ali-hosseini-deriv-ako-feq-162disting-c4623d.binary.sx?qa_server=red.binaryws.com&app_id=24020
    - **Original**: https://deriv-app-git-fork-ali-hosseini-deriv-ako-feq-162disting-c4623d.binary.sx
- **App ID**: `24020`

@github-actions
Copy link
Contributor

🚨 Lighthouse report for the changes in this PR:

Category Score
🔺 Performance 18
🟧 Accessibility 75
🟢 Best practices 92
🟧 SEO 85
🟢 PWA 90

Lighthouse ran with https://deriv-app-git-fork-ali-hosseini-deriv-ako-feq-162disting-c4623d.binary.sx/

@codecov-commenter
Copy link

Codecov Report

Merging #8569 (c321c86) into master (57abe5f) will decrease coverage by 0.24%.
The diff coverage is 44.59%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@            Coverage Diff             @@
##           master    #8569      +/-   ##
==========================================
- Coverage   20.80%   20.57%   -0.24%     
==========================================
  Files        1560     1635      +75     
  Lines       36079    36993     +914     
  Branches     7080     7367     +287     
==========================================
+ Hits         7508     7610     +102     
- Misses      27829    28632     +803     
- Partials      742      751       +9     
Impacted Files Coverage Δ
.../src/Sections/Verification/Helpers/verification.js 0.00% <0.00%> (ø)
...tion/ProofOfAddress/proof-of-address-container.jsx 0.00% <0.00%> (ø)
...re/src/components/main-title-bar/asset-summary.tsx 0.00% <0.00%> (ø)
packages/core/build/constants.js 0.00% <ø> (ø)
packages/core/src/Stores/client-store.js 0.00% <0.00%> (ø)
packages/core/src/Utils/Datadog/index.ts 0.00% <0.00%> (ø)
packages/hooks/src/useTotalAccountBalance.ts 70.00% <0.00%> (+70.00%) ⬆️
packages/stores/src/mockStore.ts 0.00% <0.00%> (ø)
...ansactions-history/crypto-transactions-history.tsx 72.00% <25.00%> (-5.28%) ⬇️
...tore/src/components/elements/text/balance-text.tsx 90.00% <50.00%> (ø)
... and 7 more

... and 80 files with indirect coverage changes

@sandeep-deriv sandeep-deriv merged commit 4ba0537 into binary-com:master May 11, 2023
nijil-deriv pushed a commit to nijil-deriv/deriv-app that referenced this pull request May 24, 2023
* feat: add ability to track staging and production with different service names

* ci: fill env value based on the app environment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants