fix: renamed your ads are running to hide my ads #8576

nada-deriv · 2023-05-11T07:33:30Z

Changes:

Renamed your ads are running to hide my ads.

Screenshots:

Please provide some screenshots of the change.

vercel · 2023-05-11T07:33:34Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
deriv-app	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jul 5, 2023 11:25am

github-actions · 2023-05-11T07:58:02Z

A production App ID was automatically generated for this PR. (log)

PR: fix: renamed your ads are running to hide my ads #8576
URLs:
- w/ App ID + Server: https://deriv-app-git-fork-nada-deriv-nada-p2ps-609ads-are-runni-455f99.binary.sx?qa_server=red.binaryws.com&app_id=32511
- Original: https://deriv-app-git-fork-nada-deriv-nada-p2ps-609ads-are-runni-455f99.binary.sx
App ID: 32511

Click here to copy & paste above information.

- **PR**: [https://github.com/binary-com/deriv-app/pull/8576](https://github.com/binary-com/deriv-app/pull/8576)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-nada-deriv-nada-p2ps-609ads-are-runni-455f99.binary.sx?qa_server=red.binaryws.com&app_id=32511
    - **Original**: https://deriv-app-git-fork-nada-deriv-nada-p2ps-609ads-are-runni-455f99.binary.sx
- **App ID**: `32511`

codecov-commenter · 2023-05-11T07:58:24Z

Codecov Report

Merging #8576 (d2f46d3) into master (d5c38a0) will increase coverage by 20.00%.
The diff coverage is 0.00%.

❗ Current head d2f46d3 differs from pull request most recent head 0d76652. Consider uploading reports for the commit 0d76652 to get more accurate results

@@             Coverage Diff             @@
##           master    #8576       +/-   ##
===========================================
+ Coverage    0.05%   20.06%   +20.00%     
===========================================
  Files         117     1827     +1710     
  Lines        3425    41469    +38044     
  Branches      893     8243     +7350     
===========================================
+ Hits            2     8319     +8317     
- Misses       3423    32288    +28865     
- Partials        0      862      +862

Impacted Files	Coverage Δ
.../p2p/src/components/my-ads/my-ads-row-renderer.jsx	`0.00% <0.00%> (ø)`
packages/p2p/src/components/my-ads/toggle-ads.jsx	`0.00% <0.00%> (ø)`

... and 1818 files with indirect coverage changes

github-actions · 2023-05-11T07:58:32Z

🚨 Lighthouse report for the changes in this PR:

Category	Score
🔺 Performance	16
🟧 Accessibility	75
🟢 Best practices	92
🟧 SEO	85
🟢 PWA	90

Lighthouse ran with https://deriv-app-git-fork-nada-deriv-nada-p2ps-609ads-are-runni-455f99.binary.sx/

gitguardian · 2023-06-07T05:55:40Z

⚠️ GitGuardian has uncovered 2 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request

GitGuardian id	Secret	Commit	Filename
-	Generic High Entropy Secret	`e34e31b`	packages/account/src/Components/currency-selector/tests/currency-selector.spec.tsx	View secret
-	Generic High Entropy Secret	`e34e31b`	packages/account/src/Components/currency-selector/tests/currency-selector.spec.tsx	View secret

🛠 Guidelines to remediate hardcoded secrets

Understand the implications of revoking this secret by investigating where it is used in your code.
Replace and store your secrets safely. Learn here the best practices.
Revoke and rotate these secrets.
If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider

following these best practices for managing and storing secrets including API keys and other credentials
install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.

^{🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!}

ameerul-deriv

LGTM

packages/p2p/src/components/my-ads/toggle-ads.jsx

niloofar-deriv

LGTM 👍

ameerul-deriv · 2023-06-13T04:14:12Z

packages/p2p/src/components/my-ads/my-ads-row-renderer.jsx

-                            <Text color='profit-success' line_height='m' size='xxs'>
+                            <Text
+                                color={is_advert_listed ? 'profit-success' : 'less-prominent'}
+                                line_height='m'


nit: you can remove this line cause the default for line_height is m 👍 same with the others

Suggested change

line_height='m'

yes. there are other issues as well i found with this file. will do it as part of refactoring.

ameerul-deriv

LGTM

farhan-nurzi-deriv

LGTM 👍 . But any idea why the deployment is failed?

nada-deriv · 2023-06-13T06:17:08Z

the deployment failed due to the node issue. haven't updated it.

coveralls · 2023-07-05T07:50:29Z

coverage: 8.876% (+0.001%) from 8.875% when pulling 5d5d2df on nada-deriv:nada/P2PS-609/ads-are-running-rename into f48ed0d on binary-com:master.

ali-hosseini-deriv · 2023-07-05T10:12:31Z

👌 Pull request has been updated with the base branch by Paimon the Release Bot

sonarcloud · 2023-07-05T10:15:48Z

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
2.5% Duplication

ali-hosseini-deriv · 2023-07-05T11:28:36Z

✨ PR has been merged by Paimon the Release Bot

fix: renamed your ads are running to hide my ads

582ff90

boring-cyborg bot added the P2P label May 11, 2023

vercel bot deployed to Preview May 11, 2023 07:57 View deployment

farhan-nurzi-deriv previously approved these changes May 11, 2023

View reviewed changes

ameerul-deriv previously approved these changes May 11, 2023

View reviewed changes

niloofar-deriv previously approved these changes May 11, 2023

View reviewed changes

nada-deriv dismissed stale reviews from niloofar-deriv, ameerul-deriv, and farhan-nurzi-deriv via 931f10c June 7, 2023 05:55

nada-deriv requested a review from yashim-deriv as a code owner June 7, 2023 05:55

boring-cyborg bot added Account Bot labels Jun 7, 2023

vercel bot had a problem deploying to Preview June 7, 2023 06:03 Failure

nada-deriv force-pushed the nada/P2PS-609/ads-are-running-rename branch from 931f10c to 582ff90 Compare June 7, 2023 06:09

Merge branch 'master' into nada/P2PS-609/ads-are-running-rename

e34e31b

vercel bot had a problem deploying to Preview June 7, 2023 06:18 Failure

feat: inverted toggle behaviour

aee8fc9

vercel bot deployed to Preview June 7, 2023 07:08 View deployment

ameerul-deriv previously approved these changes Jun 7, 2023

View reviewed changes

niloofar-deriv reviewed Jun 7, 2023

View reviewed changes

packages/p2p/src/components/my-ads/toggle-ads.jsx Outdated Show resolved Hide resolved

fix: review comment

e50f1c5

nada-deriv dismissed ameerul-deriv’s stale review via e50f1c5 June 7, 2023 07:55

niloofar-deriv approved these changes Jun 7, 2023

View reviewed changes

vercel bot deployed to Preview June 7, 2023 08:07 View deployment

farhan-nurzi-deriv approved these changes Jun 7, 2023

View reviewed changes

Merge branch 'master' into nada/P2PS-609/ads-are-running-rename

bb2e614

vercel bot had a problem deploying to Preview June 9, 2023 12:46 Failure

Merge branch 'master' into nada/P2PS-609/ads-are-running-rename

8936cb5

vercel bot had a problem deploying to Preview June 9, 2023 13:43 Failure

fix: changed styles for disabled ads currency

c1e68b8

vercel bot deployed to Preview June 12, 2023 07:41 View deployment

fix: style fixes

d2f46d3

vercel bot had a problem deploying to Preview June 12, 2023 08:20 Failure

ameerul-deriv reviewed Jun 13, 2023

View reviewed changes

ameerul-deriv approved these changes Jun 13, 2023

View reviewed changes

farhan-nurzi-deriv approved these changes Jun 13, 2023

View reviewed changes

niloofar-deriv approved these changes Jun 14, 2023

View reviewed changes

Merge branch 'master' into nada/P2PS-609/ads-are-running-rename

5d5d2df

vercel bot deployed to Preview July 5, 2023 08:41 View deployment

Merge branch 'master' into nada/P2PS-609/ads-are-running-rename

0d76652

vercel bot deployed to Preview July 5, 2023 11:25 View deployment

ali-hosseini-deriv merged commit 194c114 into binary-com:master Jul 5, 2023
3 of 4 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: renamed your ads are running to hide my ads #8576

fix: renamed your ads are running to hide my ads #8576

nada-deriv commented May 11, 2023

vercel bot commented May 11, 2023 •

edited

Loading

github-actions bot commented May 11, 2023 •

edited

Loading

codecov-commenter commented May 11, 2023 •

edited by codecov bot

Loading

github-actions bot commented May 11, 2023 •

edited

Loading

gitguardian bot commented Jun 7, 2023 •

edited

Loading

ameerul-deriv left a comment

niloofar-deriv left a comment

ameerul-deriv Jun 13, 2023

nada-deriv Jun 13, 2023

ameerul-deriv left a comment

farhan-nurzi-deriv left a comment

nada-deriv commented Jun 13, 2023

coveralls commented Jul 5, 2023

ali-hosseini-deriv commented Jul 5, 2023

sonarcloud bot commented Jul 5, 2023

ali-hosseini-deriv commented Jul 5, 2023

fix: renamed your ads are running to hide my ads #8576

fix: renamed your ads are running to hide my ads #8576

Conversation

nada-deriv commented May 11, 2023

Changes:

Screenshots:

vercel bot commented May 11, 2023 • edited Loading

github-actions bot commented May 11, 2023 • edited Loading

codecov-commenter commented May 11, 2023 • edited by codecov bot Loading

Codecov Report

github-actions bot commented May 11, 2023 • edited Loading

gitguardian bot commented Jun 7, 2023 • edited Loading

⚠️ GitGuardian has uncovered 2 secrets following the scan of your pull request.

ameerul-deriv left a comment

Choose a reason for hiding this comment

niloofar-deriv left a comment

Choose a reason for hiding this comment

ameerul-deriv Jun 13, 2023

Choose a reason for hiding this comment

nada-deriv Jun 13, 2023

Choose a reason for hiding this comment

ameerul-deriv left a comment

Choose a reason for hiding this comment

farhan-nurzi-deriv left a comment

Choose a reason for hiding this comment

nada-deriv commented Jun 13, 2023

coveralls commented Jul 5, 2023

ali-hosseini-deriv commented Jul 5, 2023

sonarcloud bot commented Jul 5, 2023

ali-hosseini-deriv commented Jul 5, 2023

vercel bot commented May 11, 2023 •

edited

Loading

github-actions bot commented May 11, 2023 •

edited

Loading

codecov-commenter commented May 11, 2023 •

edited by codecov bot

Loading

github-actions bot commented May 11, 2023 •

edited

Loading

gitguardian bot commented Jun 7, 2023 •

edited

Loading