Henry/fix: navigate to accu trade type in reports page after purchasing a c… #8684
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
A production App ID was automatically generated for this PR. (log)
Click here to copy & paste above information. |
|
🚨 Lighthouse report for the changes in this PR:
Lighthouse ran with https://deriv-app-git-fork-henry-deriv-henry-95027not-navigating-15d23d.binary.sx/ |
|
Kudos, SonarCloud Quality Gate passed!
|
henry-deriv
changed the title
balakrishna-deriv
approved these changes
May 22, 2023
akmal-deriv
approved these changes
May 22, 2023
nijil-deriv
pushed a commit
to nijil-deriv/deriv-app
that referenced
this pull request
May 24, 2023
…ng a c… (binary-com#8684) * fix: navigate to accu trade type in reports page after purchasing a contract * fix: circle CI error * fix: codecov * fix: circle CI issue
ameerul-deriv
pushed a commit
to ameerul-deriv/deriv-app
that referenced
this pull request
May 25, 2023
…ng a c… (binary-com#8684) * fix: navigate to accu trade type in reports page after purchasing a contract * fix: circle CI error * fix: codecov * fix: circle CI issue
ali-hosseini-deriv
pushed a commit
that referenced
this pull request
Sep 18, 2023
* refactor: refactor p2p styles * refactor: refactor styles * fix: classname typo * fix: fix broken style * refactor: update based on pr comments * fix: failed tests * fix: import error * refactor: rename datatest id * refactor: remove unused styles and refactor text components * refactor: restructure the p2p package * refactor: update translations imports * refactor: update modal-manager import * fix: pr review comments * fix: fix some broken styles * fix: review comments * chore: change in failed test file and remove change from unrelated file * fix: review comments * Henry/fix: navigate to accu trade type in reports page after purchasing a c… (#8684) * fix: navigate to accu trade type in reports page after purchasing a contract * fix: circle CI error * fix: codecov * fix: circle CI issue * refactor: refactor dpep-blocked components * fix: failed test * fix: review comments * refactor: test descriptions changes * refactor: import localize from p2p i18n instead of shared translations package * fix: review components * chore: refactored temporarily barred hint component * refactor: rearrange imports to follow guidelines * refactor: standardise react imports * chore: refactored p2p-empty component * chore: added default value for has_tabs * feat: unit test added for page return component * refactor: recommended-by component * fix: updated index file * chore: added test cases for star rating * chore: changed describe * refactor: add new test cases to increase coverage * refactor: add comment in empty arrow function * refactor: refactor trade-badge component * fix: review comments fixed * refactor: remove prop-types import * refactor: update react import * refactor: refactor form-submit-error-message, table-error * refactor: nickname form * refactor: review comments * fix: tests * chore: refactored user avatar component * refactor: refactor toggle-container component * chore: added suggestions * refactor: delete the type and use propswithchildren * chore: refactored FloatingRate component * refactor: refactor block-user-empty component * refactor: online status component refactoring * refactor: review comments * refactor: add margin-top * refactor: udpated test description * refactor: change test cases descriptions * refactor: review comment * refactor: refactored verification component * chore: refactored recommend user component * chore: removed fireEvent, used userEvent * refactor: updated tests * refactor: review comment fix * refactor: added type checking for modal manager in test case * translations: 📚 sync translations with crowdin (#8881) Co-authored-by: DerivFE <80095553+DerivFE@users.noreply.github.com> * thisyahlen/fix: change algo for realAccountSignup (#8656) * fix: change algo for realAccountSignup * fix: refactor * redeploy: vercel * translations: 📚 sync translations with crowdin (#8885) Co-authored-by: DerivFE <80095553+DerivFE@users.noreply.github.com> * translations: 📚 sync translations with crowdin (#8890) Co-authored-by: DerivFE <80095553+DerivFE@users.noreply.github.com> * likhith/fix: 🐛 resolved required field error (#8886) * fix: 🐛 resolved required field error * feat: fixed issue with Citizen field * refactor: removed unused code * refactor: updated test * fix: code smells * fix: tests * refactor: reduce code complexity to remove code smell * refactor: updated return * refactor: udpated test * refactor: delete text component and use default button text styles instead * fix: raised subtasks * fix: advertiser buy/sell row * fix: style fix in edit/add payment method form in my profile * fix: notification issue * fix: block banned user bug * fix: issue for popup not showing when rate updated before selecting form * fix: removed console * fix: added todo * fix: added undefined check * fix: subtasks raised * fix: daily limit notification * fix: tests failed * fix: notification popup issue not shown in responsive * fix: filter button spacing * fix: failing tests * fix: get server hits bump error when in advertiser page and block it from BO * fix: revert unwanted changes from master * fix: remove unnecessary changes * fix: remove unnecessary changes * fix: tests --------- Co-authored-by: Farhan Ahmad Nurzi <farhan.nurzi@regentmarkets.com> Co-authored-by: henry-deriv <118344354+henry-deriv@users.noreply.github.com> Co-authored-by: ameerul hady <ameerul@deriv.com> Co-authored-by: nada-deriv <nada.ajinas@deriv.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: DerivFE <80095553+DerivFE@users.noreply.github.com> Co-authored-by: thisyahlen <104053934+thisyahlen-deriv@users.noreply.github.com> Co-authored-by: Likhith Kolayari <98398322+likhith-deriv@users.noreply.github.com>
farrah-deriv
added a commit
that referenced
this pull request
Dec 15, 2023
* refactor: refactor p2p styles * refactor: refactor styles * fix: classname typo * fix: fix broken style * refactor: update based on pr comments * fix: failed tests * fix: import error * refactor: rename datatest id * refactor: remove unused styles and refactor text components * refactor: restructure the p2p package * refactor: update translations imports * refactor: update modal-manager import * fix: pr review comments * fix: fix some broken styles * fix: review comments * chore: change in failed test file and remove change from unrelated file * fix: review comments * Henry/fix: navigate to accu trade type in reports page after purchasing a c… (#8684) * fix: navigate to accu trade type in reports page after purchasing a contract * fix: circle CI error * fix: codecov * fix: circle CI issue * refactor: refactor dpep-blocked components * fix: failed test * fix: review comments * refactor: test descriptions changes * refactor: import localize from p2p i18n instead of shared translations package * fix: review components * chore: refactored temporarily barred hint component * refactor: rearrange imports to follow guidelines * refactor: standardise react imports * chore: refactored p2p-empty component * chore: added default value for has_tabs * feat: unit test added for page return component * refactor: recommended-by component * fix: updated index file * chore: added test cases for star rating * chore: changed describe * refactor: add new test cases to increase coverage * refactor: add comment in empty arrow function * refactor: refactor trade-badge component * fix: review comments fixed * refactor: remove prop-types import * refactor: update react import * refactor: refactor form-submit-error-message, table-error * refactor: nickname form * refactor: review comments * fix: tests * chore: refactored user avatar component * refactor: refactor toggle-container component * chore: added suggestions * refactor: delete the type and use propswithchildren * chore: refactored FloatingRate component * refactor: refactor block-user-empty component * refactor: online status component refactoring * refactor: review comments * refactor: add margin-top * refactor: udpated test description * refactor: change test cases descriptions * refactor: review comment * refactor: refactored verification component * chore: refactored recommend user component * chore: removed fireEvent, used userEvent * refactor: updated tests * refactor: review comment fix * refactor: added type checking for modal manager in test case * translations: 📚 sync translations with crowdin (#8881) Co-authored-by: DerivFE <80095553+DerivFE@users.noreply.github.com> * thisyahlen/fix: change algo for realAccountSignup (#8656) * fix: change algo for realAccountSignup * fix: refactor * redeploy: vercel * translations: 📚 sync translations with crowdin (#8885) Co-authored-by: DerivFE <80095553+DerivFE@users.noreply.github.com> * translations: 📚 sync translations with crowdin (#8890) Co-authored-by: DerivFE <80095553+DerivFE@users.noreply.github.com> * likhith/fix: 🐛 resolved required field error (#8886) * fix: 🐛 resolved required field error * feat: fixed issue with Citizen field * refactor: removed unused code * refactor: updated test * fix: code smells * fix: tests * refactor: reduce code complexity to remove code smell * refactor: updated return * refactor: udpated test * chore: refactored MyProfileSeparatorContainer component * chore: changed imports * chore: refactor MyProfileHeader component * chore: refactored MyProfileForm component * chore: removed the role in div * chore: removed is_invisible and refactored the styling * Update packages/p2p/src/components/my-profile/my-profile-form/__test__/my-profile-form.spec.tsx Co-authored-by: Niloofar Sadeghi <93518187+niloofar-deriv@users.noreply.github.com> * Update packages/p2p/src/components/my-profile/my-profile-form/__test__/my-profile-form.spec.tsx Co-authored-by: Niloofar Sadeghi <93518187+niloofar-deriv@users.noreply.github.com> * chore: refactored components to typescript and added tests, removed my-profile-balance-modal out * chore: refactored daily-limit-modal, details-table and balance-modal * chore: refactored and added tests for my-profile-name, privacy, stats-table * chore: added test cases for my-profile-stats, updated test cases * chore: refactored out dry code and destructured the observables from my profile * chore: fixed import * chore: renamed test folder to tests * chore: renamed test folder to tests * refactor: delete text component and use default button text styles instead * chore: refactored filter-modal, row,table-error * chore: updated test cases, refactored rest of components * chore: refactored and added tests for block-user and user-table * chore: removed async * chore: moved reactions to store and added suggestions * chore: removed unused imports * chore: Refactored payment-method components * chore: refactored remaining components under payment-methods * chore: added suggestions * chore: rearranged values * chore: refactored remaining components * chore: added check for selected_payment_method when cancelling or returning * chore: added check for selected_payment_method * chore: fixed import order * chore: fixed showing < in stats * fix: raised subtasks * fix: advertiser buy/sell row * chore: fixed test cases * chore: fixed imports and styles * chore: added responsive functions for text and icon size * chore: added test case to my-profile to check if component is loading * fix: style fix in edit/add payment method form in my profile * fix: notification issue * fix: block banned user bug * fix: issue for popup not showing when rate updated before selecting form * fix: removed console * fix: added todo * fix: added undefined check * fix: subtasks raised * fix: daily limit notification * fix: tests failed * chore: fixed conflicts and changed eslint error for length toBe for tests * fix: notification popup issue not shown in responsive * fix: filter button spacing * fix: failing tests * chore: refactored test cases, components and styles * fix: get server hits bump error when in advertiser page and block it from BO * fix: revert unwanted changes from master * fix: remove unnecessary changes * fix: remove unnecessary changes * fix: tests * chore: fixed failing test cases * fix: initial values not showing while editing payment method * fix: unwanted changes * fix: dropdown list not hovering on top of card * chore: added test cases for new util files * fix: failing test cases * chore: removed AutoSizer, added ScrollWrapper to replace it, added suggestions * chore: added suggestions and replaced isMobile, isDesktop with is_mobile or is_desktop * fix: code smells * fix: failing test cases * fix: cropped input label, missing tab header on mobile, duplicated star rating label * fix: failing test cases --------- Co-authored-by: Farhan Ahmad Nurzi <farhan.nurzi@regentmarkets.com> Co-authored-by: Farrah Mae Ochoa <82315152+farrah-deriv@users.noreply.github.com> Co-authored-by: henry-deriv <118344354+henry-deriv@users.noreply.github.com> Co-authored-by: Farrah Mae Ochoa <farrah@deriv.com> Co-authored-by: nada-deriv <nada.ajinas@deriv.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: DerivFE <80095553+DerivFE@users.noreply.github.com> Co-authored-by: thisyahlen <104053934+thisyahlen-deriv@users.noreply.github.com> Co-authored-by: Likhith Kolayari <98398322+likhith-deriv@users.noreply.github.com> Co-authored-by: Niloofar Sadeghi <93518187+niloofar-deriv@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ontract
Changes:
Please provide a summary of the change.
Screenshots:
Please provide some screenshots of the change.