Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sergei / wall - 734 / Change logo to new branding #8752

Merged

Conversation

sergei-deriv
Copy link
Contributor

Changes:

Account signup background change to new branding

Screenshots:

Please provide some screenshots of the change.

@vercel
Copy link

vercel bot commented May 25, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
deriv-app ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 25, 2023 8:56pm

@github-actions
Copy link
Contributor

github-actions bot commented May 25, 2023

A production App ID was automatically generated for this PR. (log)

Click here to copy & paste above information.
- **PR**: [https://github.com/binary-com/deriv-app/pull/8752](https://github.com/binary-com/deriv-app/pull/8752)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-sergei-deriv-sergei-wall-734change-logo.binary.sx?qa_server=red.binaryws.com&app_id=32459
    - **Original**: https://deriv-app-git-fork-sergei-deriv-sergei-wall-734change-logo.binary.sx
- **App ID**: `32459`

@github-actions
Copy link
Contributor

github-actions bot commented May 25, 2023

🚨 Lighthouse report for the changes in this PR:

Category Score
🔺 Performance 19
🟧 Accessibility 75
🟢 Best practices 92
🟧 SEO 85
🟢 PWA 90

Lighthouse ran with https://deriv-app-git-fork-sergei-deriv-sergei-wall-734change-logo.binary.sx/

@codecov-commenter
Copy link

codecov-commenter commented May 25, 2023

Codecov Report

Merging #8752 (c74d9de) into master (9f6a90b) will not change coverage.
The diff coverage is n/a.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@           Coverage Diff           @@
##           master    #8752   +/-   ##
=======================================
  Coverage   39.63%   39.63%           
=======================================
  Files         212      212           
  Lines        4494     4494           
  Branches     1237     1237           
=======================================
  Hits         1781     1781           
  Misses       2482     2482           
  Partials      231      231           

kate-deriv
kate-deriv previously approved these changes May 25, 2023
eduard-deriv
eduard-deriv previously approved these changes May 25, 2023
@sergei-deriv sergei-deriv dismissed stale reviews from eduard-deriv and kate-deriv via c74d9de May 25, 2023 20:42
@sonarcloud
Copy link

sonarcloud bot commented May 25, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
2.9% 2.9% Duplication

@amina-deriv amina-deriv merged commit 3fb35ad into binary-com:master May 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants