Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

thisyahlen/fix: translation on refresh bug #8778

Conversation

thisyahlen-deriv
Copy link
Contributor

Changes:

Please provide a summary of the change.

Screenshots:

Please provide some screenshots of the change.

@vercel
Copy link

vercel bot commented May 29, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
deriv-app ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 1, 2023 4:10am

@github-actions
Copy link
Contributor

github-actions bot commented May 29, 2023

A production App ID was automatically generated for this PR. (log)

Click here to copy & paste above information.
- **PR**: [https://github.com/binary-com/deriv-app/pull/8778](https://github.com/binary-com/deriv-app/pull/8778)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-thisyahlen-deriv-thisyahlen-wall-773t-380593.binary.sx?qa_server=red.binaryws.com&app_id=32679
    - **Original**: https://deriv-app-git-fork-thisyahlen-deriv-thisyahlen-wall-773t-380593.binary.sx
- **App ID**: `32679`

@github-actions
Copy link
Contributor

github-actions bot commented May 29, 2023

🚨 Lighthouse report for the changes in this PR:

Category Score
🔺 Performance 20
🟧 Accessibility 75
🟢 Best practices 92
🟧 SEO 85
🟢 PWA 90

Lighthouse ran with https://deriv-app-git-fork-thisyahlen-deriv-thisyahlen-wall-773t-380593.binary.sx/

@codecov
Copy link

codecov bot commented Jun 1, 2023

Codecov Report

Merging #8778 (24c1c1c) into master (d103837) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #8778   +/-   ##
=======================================
  Coverage   40.11%   40.11%           
=======================================
  Files         212      212           
  Lines        4510     4510           
  Branches     1242     1242           
=======================================
  Hits         1809     1809           
  Misses       2469     2469           
  Partials      232      232           

@sonarcloud
Copy link

sonarcloud bot commented Jun 1, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants