Ameerul /P2PS-721 Move the registration to the My Profile tab on the website to ensure consistency across Mobile App and Website #8915

ameerul-deriv · 2023-06-07T02:42:21Z

Changes:

Show My Profile tab when the user is not a registered p2p user
Show Verification Component in My Profile Tab when the user is not registered
Removed tests that had checked if the my profile tab was hidden in app-content.spec.js

Please provide a summary of the change.

Screenshots:

Please provide some screenshots of the change.

vercel · 2023-06-07T02:55:20Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
deriv-app	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Oct 3, 2023 4:06am

github-actions · 2023-06-07T03:07:16Z

A production App ID was automatically generated for this PR. (log)

PR: Ameerul /P2PS-721 Move the registration to the My Profile tab on the website to ensure consistency across Mobile App and Website #8915
URLs:
- w/ App ID + Server: https://deriv-app-git-fork-ameerul-deriv-p2ps-721-move-registrat-6bf3b4.binary.sx?qa_server=red.binaryws.com&app_id=23853
- Original: https://deriv-app-git-fork-ameerul-deriv-p2ps-721-move-registrat-6bf3b4.binary.sx
App ID: 23853

Click here to copy & paste above information.

- **PR**: [https://github.com/binary-com/deriv-app/pull/8915](https://github.com/binary-com/deriv-app/pull/8915)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-ameerul-deriv-p2ps-721-move-registrat-6bf3b4.binary.sx?qa_server=red.binaryws.com&app_id=23853
    - **Original**: https://deriv-app-git-fork-ameerul-deriv-p2ps-721-move-registrat-6bf3b4.binary.sx
- **App ID**: `23853`

github-actions · 2023-06-07T03:07:38Z

🚨 Lighthouse report for the changes in this PR:

Category	Score
🔺 Performance	20
🟧 Accessibility	75
🟢 Best practices	92
🟧 SEO	85
🟢 PWA	90

Lighthouse ran with https://deriv-app-git-fork-ameerul-deriv-p2ps-721-move-registrat-6bf3b4.binary.sx/

sonarcloud · 2023-06-07T03:11:48Z

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
2.5% Duplication

niloofar-deriv

LGTM 👍

codecov · 2023-06-07T08:31:56Z

Codecov Report

Merging #8915 (90d3e63) into master (d5c38a0) will increase coverage by 19.92%.
Report is 562 commits behind head on master.
The diff coverage is 0.00%.

❗ Current head 90d3e63 differs from pull request most recent head 27e1e4c. Consider uploading reports for the commit 27e1e4c to get more accurate results

@@             Coverage Diff             @@
##           master    #8915       +/-   ##
===========================================
+ Coverage    0.05%   19.98%   +19.92%     
===========================================
  Files         117     1817     +1700     
  Lines        3425    41154    +37729     
  Branches      893     8175     +7282     
===========================================
+ Hits            2     8226     +8224     
- Misses       3423    32085    +28662     
- Partials        0      843      +843

Files	Coverage Δ
packages/p2p/src/components/app-content.jsx	`68.18% <ø> (ø)`
...kages/p2p/src/components/my-profile/my-profile.jsx	`0.00% <0.00%> (ø)`

... and 1808 files with indirect coverage changes

github-actions · 2023-08-08T00:21:49Z

This PR is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 5 days.

…:ameerul-deriv/deriv-app into P2PS-721-move-registration-to-my-profile

github-actions · 2023-08-10T07:11:53Z

⏳ Generating Lighthouse report...

coveralls · 2023-08-10T08:03:04Z

coverage: 9.791% (+0.01%) from 9.778% when pulling 2118086 on ameerul-deriv:P2PS-721-move-registration-to-my-profile into 381d126 on binary-com:master.

…iser to remove loading

…1-move-registration-to-my-profile

sonarcloud · 2023-08-30T06:22:57Z

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
2.9% Duplication

gitguardian · 2023-10-03T02:18:27Z

⚠️ GitGuardian has uncovered 1 secret following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secret in your pull request

GitGuardian id	Secret	Commit	Filename
-	Generic High Entropy Secret	`9f88d2e`	nx.json	View secret

🛠 Guidelines to remediate hardcoded secrets

Understand the implications of revoking this secret by investigating where it is used in your code.
Replace and store your secret safely. Learn here the best practices.
Revoke and rotate this secret.
If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider

following these best practices for managing and storing secrets including API keys and other credentials
install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.

^{🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!}

…1-move-registration-to-my-profile

sonarcloud · 2023-10-03T03:51:09Z

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
9.1% Duplication

…website to ensure consistency across Mobile App and Website (#8915) * chore: moved verification to my profile when user is not registered * chore: added test case for verification * chore: fixed failing tests * chore: added check if user has poi_status when they are not an advertiser to remove loading * chore: fixed failing my-profile test * chore: changed verfication default from my_ads to my_profile * fix: verification import * fix: failing test cases

chore: moved verification to my profile when user is not registered

b290442

boring-cyborg bot added the P2P label Jun 7, 2023

vercel bot deployed to Preview June 7, 2023 02:55 View deployment

Merge branch 'master' into P2PS-721-move-registration-to-my-profile

90d3e63

vercel bot deployed to Preview June 7, 2023 03:24 View deployment

niloofar-deriv approved these changes Jun 7, 2023

View reviewed changes

farhan-nurzi-deriv approved these changes Jun 7, 2023

View reviewed changes

nada-deriv approved these changes Jun 8, 2023

View reviewed changes

github-actions bot added the Stale label Aug 8, 2023

ameerul-deriv added 2 commits August 10, 2023 15:10

chore: fixed merge conflicts

932cd61

Merge branch 'P2PS-721-move-registration-to-my-profile' of github.com…

39ad817

…:ameerul-deriv/deriv-app into P2PS-721-move-registration-to-my-profile

ameerul-deriv requested review from farrah-deriv and nijil-deriv as code owners August 10, 2023 07:11

ameerul-deriv added 2 commits August 10, 2023 15:14

chore: added test case for verification

742630b

chore: fixed failing tests

2118086

vercel bot deployed to Preview August 10, 2023 08:03 View deployment

github-actions bot removed the Stale label Aug 11, 2023

chore: added check if user has poi_status when they are not an advert…

7355930

…iser to remove loading

vercel bot deployed to Preview August 16, 2023 07:51 View deployment

farrah-deriv previously approved these changes Aug 18, 2023

View reviewed changes

farhan-nurzi-deriv approved these changes Aug 18, 2023

View reviewed changes

niloofar-deriv approved these changes Aug 18, 2023

View reviewed changes

Merge branch 'master' of github.com:binary-com/deriv-app into P2PS-72…

1ce33a1

…1-move-registration-to-my-profile

vercel bot deployed to Preview August 30, 2023 02:50 View deployment

chore: fixed failing my-profile test

66e720f

ameerul-deriv dismissed farrah-deriv’s stale review via 66e720f August 30, 2023 03:08

vercel bot deployed to Preview August 30, 2023 03:26 View deployment

chore: changed verfication default from my_ads to my_profile

e1a34db

vercel bot deployed to Preview August 30, 2023 06:53 View deployment

farrah-deriv previously approved these changes Sep 14, 2023

View reviewed changes

chore: fix merge conflicts with master

9f88d2e

ameerul-deriv dismissed farrah-deriv’s stale review via 9f88d2e October 3, 2023 02:17

ameerul-deriv had a problem deploying to Preview October 3, 2023 02:19 — with GitHub Actions Failure

fix: verification import

d5380c3

ameerul-deriv deployed to Preview October 3, 2023 02:58 — with GitHub Actions View deployment

Merge branch 'master' of github.com:binary-com/deriv-app into P2PS-72…

0e5d027

…1-move-registration-to-my-profile

ameerul-deriv deployed to Preview October 3, 2023 03:23 — with GitHub Actions View deployment

fix: failing test cases

27e1e4c

ameerul-deriv deployed to Preview October 3, 2023 03:48 — with GitHub Actions View deployment

farrah-deriv approved these changes Oct 4, 2023

View reviewed changes

sandeep-deriv merged commit 15d930b into binary-com:master Oct 4, 2023
6 of 7 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Ameerul /P2PS-721 Move the registration to the My Profile tab on the website to ensure consistency across Mobile App and Website #8915

Ameerul /P2PS-721 Move the registration to the My Profile tab on the website to ensure consistency across Mobile App and Website #8915

ameerul-deriv commented Jun 7, 2023

vercel bot commented Jun 7, 2023 •

edited

Loading

github-actions bot commented Jun 7, 2023 •

edited

Loading

github-actions bot commented Jun 7, 2023 •

edited

Loading

sonarcloud bot commented Jun 7, 2023

niloofar-deriv left a comment

codecov bot commented Jun 7, 2023 •

edited

Loading

github-actions bot commented Aug 8, 2023

github-actions bot commented Aug 10, 2023 •

edited

Loading

coveralls commented Aug 10, 2023

sonarcloud bot commented Aug 30, 2023

gitguardian bot commented Oct 3, 2023 •

edited

Loading

sonarcloud bot commented Oct 3, 2023

Ameerul /P2PS-721 Move the registration to the My Profile tab on the website to ensure consistency across Mobile App and Website #8915

Ameerul /P2PS-721 Move the registration to the My Profile tab on the website to ensure consistency across Mobile App and Website #8915

Conversation

ameerul-deriv commented Jun 7, 2023

Changes:

Screenshots:

vercel bot commented Jun 7, 2023 • edited Loading

github-actions bot commented Jun 7, 2023 • edited Loading

github-actions bot commented Jun 7, 2023 • edited Loading

sonarcloud bot commented Jun 7, 2023

niloofar-deriv left a comment

Choose a reason for hiding this comment

codecov bot commented Jun 7, 2023 • edited Loading

Codecov Report

github-actions bot commented Aug 8, 2023

github-actions bot commented Aug 10, 2023 • edited Loading

coveralls commented Aug 10, 2023

sonarcloud bot commented Aug 30, 2023

gitguardian bot commented Oct 3, 2023 • edited Loading

⚠️ GitGuardian has uncovered 1 secret following the scan of your pull request.

sonarcloud bot commented Oct 3, 2023

vercel bot commented Jun 7, 2023 •

edited

Loading

github-actions bot commented Jun 7, 2023 •

edited

Loading

github-actions bot commented Jun 7, 2023 •

edited

Loading

codecov bot commented Jun 7, 2023 •

edited

Loading

github-actions bot commented Aug 10, 2023 •

edited

Loading

gitguardian bot commented Oct 3, 2023 •

edited

Loading