Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rupato/358/rerender-previous-active-tab-on-reload #8992

Conversation

rupato-deriv
Copy link
Contributor

No description provided.

@vercel
Copy link

vercel bot commented Jun 12, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
deriv-app ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 10, 2023 10:30am

@rupato-deriv rupato-deriv changed the title fix: previous-active-route Rupato/358/fix: previous-active-route Jun 12, 2023
@rupato-deriv rupato-deriv changed the title Rupato/358/fix: previous-active-route Rupato/358/rerender-previous-active-route Jun 12, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Jun 12, 2023

A production App ID was automatically generated for this PR. (log)

Click here to copy & paste above information.
- **PR**: [https://github.com/binary-com/deriv-app/pull/8992](https://github.com/binary-com/deriv-app/pull/8992)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-rupato-deriv-rupato-358reload-previou-419772.binary.sx?qa_server=red.binaryws.com&app_id=32920
    - **Original**: https://deriv-app-git-fork-rupato-deriv-rupato-358reload-previou-419772.binary.sx
- **App ID**: `32920`

@github-actions
Copy link
Contributor

github-actions bot commented Jun 12, 2023

🚨 Lighthouse report for the changes in this PR:

Category Score
🔺 Performance 19
🟧 Accessibility 75
🟢 Best practices 92
🟧 SEO 85
🟢 PWA 90

Lighthouse ran with https://deriv-app-git-fork-rupato-deriv-rupato-358reload-previou-419772.binary.sx/

@rupato-deriv rupato-deriv changed the title Rupato/358/rerender-previous-active-route Rupato/358/rerender-previous-active-tab Jun 12, 2023
@rupato-deriv rupato-deriv changed the title Rupato/358/rerender-previous-active-tab Rupato/358/rerender-previous-active-tab-on-reload Jun 12, 2023
@codecov
Copy link

codecov bot commented Jun 12, 2023

Codecov Report

Merging #8992 (934db65) into master (d5c38a0) will increase coverage by 19.98%.
The diff coverage is 0.00%.

❗ Current head 934db65 differs from pull request most recent head 037006f. Consider uploading reports for the commit 037006f to get more accurate results

@@             Coverage Diff             @@
##           master    #8992       +/-   ##
===========================================
+ Coverage    0.05%   20.04%   +19.98%     
===========================================
  Files         117     1827     +1710     
  Lines        3425    41490    +38065     
  Branches      893     8254     +7361     
===========================================
+ Hits            2     8318     +8316     
- Misses       3423    32310    +28887     
- Partials        0      862      +862     
Impacted Files Coverage Δ
.../bot-web-ui/src/components/dashboard/dashboard.tsx 0.00% <0.00%> (ø)
packages/core/src/Stores/ui-store.js 0.00% <0.00%> (ø)

... and 1818 files with indirect coverage changes

@sonarcloud
Copy link

sonarcloud bot commented Jul 10, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
1.6% 1.6% Duplication

@coveralls
Copy link

Coverage Status

coverage: 8.804% (-0.003%) from 8.807% when pulling 037006f on rupato-deriv:Rupato/358/reload--previous-tab-on-refresh into 55d23ae on binary-com:master.

@ali-hosseini-deriv ali-hosseini-deriv merged commit 0e54b66 into binary-com:master Jul 11, 2023
3 checks passed
@ali-hosseini-deriv
Copy link
Member

✨ PR has been merged by Paimon the Release Bot

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants