Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change resource_class to large #9073

Merged
merged 1 commit into from
Jun 21, 2023
Merged

Change resource_class to large #9073

merged 1 commit into from
Jun 21, 2023

Conversation

thibault-deriv
Copy link
Contributor

Changes:

  • Change resource_class to large for jobs possibly running on user CircleCI

Some users report issues running builds after they set up CircleCI on their forks:
Resource class docker for xlarge is not available for your project, or is not a valid resource class. This message will often appear if the pricing plan for this project does not support docker use.

While it seems a configuration issue (not all users impacted, some had the issue and it's fixed now), better to use resource_class: large so we won't have this issue anymore. We can still add again xlarge later.

According to CircleCI resource classes, the large resource class should be available to everyone and faster than what was the default 1 month ago (it was often resolving to medium)

circle-ci-plan-resource-class

I changed the resource class only for job running on pull request (others can run but it's more rare and would fail for othe reasons)

@vercel
Copy link

vercel bot commented Jun 20, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
deriv-app ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 20, 2023 4:55pm

@sonarcloud
Copy link

sonarcloud bot commented Jun 20, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@github-actions
Copy link
Contributor

A production App ID was automatically generated for this PR. (log)

Click here to copy & paste above information.
- **PR**: [https://github.com/binary-com/deriv-app/pull/9073](https://github.com/binary-com/deriv-app/pull/9073)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-thibault-deriv-resource-class-large.binary.sx?qa_server=red.binaryws.com&app_id=32461
    - **Original**: https://deriv-app-git-fork-thibault-deriv-resource-class-large.binary.sx
- **App ID**: `32461`

@github-actions
Copy link
Contributor

🚨 Lighthouse report for the changes in this PR:

Category Score
🔺 Performance 21
🟧 Accessibility 75
🟢 Best practices 92
🟧 SEO 85
🟢 PWA 90

Lighthouse ran with https://deriv-app-git-fork-thibault-deriv-resource-class-large.binary.sx/

@codecov
Copy link

codecov bot commented Jun 20, 2023

Codecov Report

Merging #9073 (87aea79) into master (9d9b9d5) will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff           @@
##           master   #9073   +/-   ##
======================================
  Coverage    0.05%   0.05%           
======================================
  Files         117     117           
  Lines        3422    3422           
  Branches      891     891           
======================================
  Hits            2       2           
  Misses       3420    3420           

@matin-deriv matin-deriv merged commit 243b35d into binary-com:master Jun 21, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants