Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kate / WEBREL-40 / Test coverage: MarketUnavailableModal + UnsupportedContractModal in Trader package #9074

Merged

Conversation

kate-deriv
Copy link
Contributor

Changes:

  • Add unit tests for market-unavailable.jsx and unsupported-contract-modal.jsx

Screenshots:

Please provide some screenshots of the change.

@boring-cyborg boring-cyborg bot added the Trader label Jun 21, 2023
@vercel
Copy link

vercel bot commented Jun 21, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
deriv-app ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 7, 2023 0:32am

@github-actions
Copy link
Contributor

github-actions bot commented Jun 21, 2023

A production App ID was automatically generated for this PR. (log)

Click here to copy & paste above information.
- **PR**: [https://github.com/binary-com/deriv-app/pull/9074](https://github.com/binary-com/deriv-app/pull/9074)
- **URLs**:
    - **w/ App ID + Server**: https://vercel.live/open-feedback/deriv-app-git-fork-kate-deriv-kate-webrel-40testmodalfiles.binary.sx?qa_server=red.binaryws.com&app_id=31496
    - **Original**: https://vercel.live/open-feedback/deriv-app-git-fork-kate-deriv-kate-webrel-40testmodalfiles.binary.sx
- **App ID**: `31496`

@codecov
Copy link

codecov bot commented Jun 21, 2023

Codecov Report

Merging #9074 (c287018) into master (d5c38a0) will increase coverage by 0.00%.
Report is 170 commits behind head on master.
The diff coverage is n/a.

❗ Current head c287018 differs from pull request most recent head 7fb80d1. Consider uploading reports for the commit 7fb80d1 to get more accurate results

@@          Coverage Diff           @@
##           master   #9074   +/-   ##
======================================
  Coverage    0.05%   0.05%           
======================================
  Files         117     117           
  Lines        3425    3422    -3     
  Branches      893     891    -2     
======================================
  Hits            2       2           
+ Misses       3423    3420    -3     

see 1 file with indirect coverage changes

@github-actions
Copy link
Contributor

github-actions bot commented Jun 21, 2023

🚨 Lighthouse report for the changes in this PR:

Category Score
🔺 Performance 20
🟧 Accessibility 75
🟢 Best practices 92
🟧 SEO 85
🟢 PWA 90

Lighthouse ran with https://deriv-app-git-fork-kate-deriv-kate-webrel-40testmodalfiles.binary.sx/

Copy link
Contributor

@henry-deriv henry-deriv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

farzin-deriv
farzin-deriv previously approved these changes Jun 21, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Jun 21, 2023

Generating Lighthouse report...

maryia-deriv
maryia-deriv previously approved these changes Jun 21, 2023
@coveralls
Copy link

coveralls commented Jul 7, 2023

Coverage Status

coverage: 8.89% (+0.006%) from 8.884% when pulling a77053e on kate-deriv:kate/WEBREL-40/test_modal_files into 0553c82 on binary-com:master.

@sonarcloud
Copy link

sonarcloud bot commented Aug 7, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@sandeep-deriv sandeep-deriv merged commit 5b6816b into binary-com:master Aug 10, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants