Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Amina/fix: hide placeholder in input fields #9224

Conversation

amina-deriv
Copy link
Contributor

Changes:

Please provide a summary of the change.

Screenshots:

Please provide some screenshots of the change.

@vercel
Copy link

vercel bot commented Jul 4, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
deriv-app ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 4, 2023 0:34am

@coveralls
Copy link

coveralls commented Jul 4, 2023

Coverage Status

coverage: 8.876%. remained the same when pulling c796ad3 on amina-deriv:amina/wall-1120/remove_placeholder_on_focus into d497719 on binary-com:master.

@github-actions
Copy link
Contributor

github-actions bot commented Jul 4, 2023

A production App ID was automatically generated for this PR. (log)

Click here to copy & paste above information.
- **PR**: [https://github.com/binary-com/deriv-app/pull/9224](https://github.com/binary-com/deriv-app/pull/9224)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-amina-deriv-amina-wall-1120removeplac-e3ed1f.binary.sx?qa_server=red.binaryws.com&app_id=24048
    - **Original**: https://deriv-app-git-fork-amina-deriv-amina-wall-1120removeplac-e3ed1f.binary.sx
- **App ID**: `24048`

@github-actions
Copy link
Contributor

github-actions bot commented Jul 4, 2023

🚨 Lighthouse report for the changes in this PR:

Category Score
🔺 Performance 20
🟧 Accessibility 75
🟢 Best practices 92
🟧 SEO 85
🟢 PWA 90

Lighthouse ran with https://deriv-app-git-fork-amina-deriv-amina-wall-1120removeplac-e3ed1f.binary.sx/

@boring-cyborg boring-cyborg bot added the Account label Jul 4, 2023
@sonarcloud
Copy link

sonarcloud bot commented Jul 4, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
2.2% 2.2% Duplication

@github-actions
Copy link
Contributor

github-actions bot commented Jul 4, 2023

Generating Lighthouse report...

@amina-deriv amina-deriv marked this pull request as ready for review July 4, 2023 13:12
@ali-hosseini-deriv ali-hosseini-deriv merged commit 8be80c9 into binary-com:master Jul 10, 2023
4 checks passed
@ali-hosseini-deriv
Copy link
Member

✨ PR has been merged by Paimon the Release Bot

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants