Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hamza/update the broker name in mt5 trade modal #9498

Conversation

hamza-deriv
Copy link
Contributor

Changes:

Please provide a summary of the change.
Update MT5 broker name in deriv.app to new name: "Deriv Holdings (Guernsey) Limited"

Screenshots:

Please provide some screenshots of the change.

@vercel
Copy link

vercel bot commented Jul 31, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
deriv-app ✅ Ready (Inspect) Visit Preview Jul 31, 2023 3:57am

@sonarcloud
Copy link

sonarcloud bot commented Jul 31, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@github-actions
Copy link
Contributor

A production App ID was automatically generated for this PR. (log)

Click here to copy & paste above information.
- **PR**: [https://github.com/binary-com/deriv-app/pull/9498](https://github.com/binary-com/deriv-app/pull/9498)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-hamza-deriv-hamza-prodqa-1248broker-n-cfbff6.binary.sx?qa_server=red.binaryws.com&app_id=32926
    - **Original**: https://deriv-app-git-fork-hamza-deriv-hamza-prodqa-1248broker-n-cfbff6.binary.sx
- **App ID**: `32926`

@github-actions
Copy link
Contributor

🚨 Lighthouse report for the changes in this PR:

Category Score
🔺 Performance 17
🟧 Accessibility 75
🟢 Best practices 92
🟧 SEO 85
🟢 PWA 90

Lighthouse ran with https://deriv-app-git-fork-hamza-deriv-hamza-prodqa-1248broker-n-cfbff6.binary.sx/

@coveralls
Copy link

Coverage Status

coverage: 8.871%. remained the same when pulling 7e5050b on hamza-deriv:hamza/PRODQA-1248/Broker-name-update into e17e9d9 on binary-com:master.

@sandeep-deriv sandeep-deriv merged commit e1ea94c into binary-com:master Jul 31, 2023
3 checks passed
matin-deriv pushed a commit to matin-deriv/deriv-app that referenced this pull request Aug 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants