Jim/WEBREL-890/p2p-chat-messages-are-disappearing-when-shifting-the-tabs-and-chat-page-is-breaking #9537
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
A production App ID was automatically generated for this PR. (log)
Click here to copy & paste above information. |
|
🚨 Lighthouse report for the changes in this PR:
Lighthouse ran with https://deriv-app-git-fork-jim-deriv-jim-webrel-890p2p-chat-mess-74192b.binary.sx/ |
maryia-deriv
approved these changes
Aug 2, 2023
niloofar-deriv
approved these changes
Aug 2, 2023
…reaction to fire immediately
maryia-deriv
approved these changes
Aug 2, 2023
farrah-deriv
previously approved these changes
Aug 2, 2023
nada-deriv
approved these changes
Aug 2, 2023
…REL-890/p2p-chat-messages-are-disappearing-when-shifting-the-tabs-and-chat-page-is-breaking
…s-are-disappearing-when-shifting-the-tabs-and-chat-page-is-breaking
jim-deriv
requested review from
nijil-deriv,
balakrishna-deriv and
yashim-deriv
as code owners
…s-are-disappearing-when-shifting-the-tabs-and-chat-page-is-breaking
farrah-deriv
reviewed
Aug 3, 2023
|
Kudos, SonarCloud Quality Gate passed!
|
ameerul-deriv
approved these changes
Aug 3, 2023
farrah-deriv
approved these changes
Aug 3, 2023
|
⏳ Generating Lighthouse report... |
matin-deriv
pushed a commit
to matin-deriv/deriv-app
that referenced
this pull request
Aug 8, 2023
…abs-and-chat-page-is-breaking (binary-com#9537) * fix: display chat messages when the active_chat_channel is truthy * ci: trigger build * chore: clear active chat channel when back button is cleared and set reaction to fire immediately * chore: remove unused when * chore: update sendbird to v4.9.5 * chore: show loader when loading previous messages * refactor: restore console warns based on code reviews
jim-deriv
deleted the
Jim/WEBREL-890/p2p-chat-messages-are-disappearing-when-shifting-the-tabs-and-chat-page-is-breaking
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
reactiontowhen, so that theinitialiseOrderMessagesis called when the user navigates back to the p2p chat page.Screenshots: