FarhanNurzi/P2PS-1329/Advertisers ads are duplicating in other advertiser profile after manual refresh #9569

farhan-nurzi-deriv · 2023-08-04T04:46:50Z

Changes:

setting counterparty_id in advertiser-page.jsx instead of in app.jsx
fetch payment methods list when mounting my-profile/payment-methods component
use counterparty_id if advertiser_details_id is not available to block the user

Screenshots:

Please provide some screenshots of the change.

vercel · 2023-08-04T04:46:54Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Updated (UTC)
deriv-app	✅ Ready (Inspect)	Visit Preview	Oct 16, 2023 5:30am

github-actions · 2023-08-04T05:03:11Z

A production App ID was automatically generated for this PR. (log)

PR: FarhanNurzi/P2PS-1329/Advertisers ads are duplicating in other advertiser profile after manual refresh #9569
URLs:
- w/ App ID + Server: https://deriv-app-git-fork-farhan-nurzi-deriv-p2ps-1329-issues-w-a5c1e3.binary.sx?qa_server=red.binaryws.com&app_id=32226
- Original: https://deriv-app-git-fork-farhan-nurzi-deriv-p2ps-1329-issues-w-a5c1e3.binary.sx
App ID: 32226

Click here to copy & paste above information.

- **PR**: [https://github.com/binary-com/deriv-app/pull/9569](https://github.com/binary-com/deriv-app/pull/9569)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-farhan-nurzi-deriv-p2ps-1329-issues-w-a5c1e3.binary.sx?qa_server=red.binaryws.com&app_id=32226
    - **Original**: https://deriv-app-git-fork-farhan-nurzi-deriv-p2ps-1329-issues-w-a5c1e3.binary.sx
- **App ID**: `32226`

github-actions · 2023-08-04T05:03:42Z

🚨 Lighthouse report for the changes in this PR:

Category	Score
🔺 Performance	15
🟧 Accessibility	75
🟢 Best practices	92
🟧 SEO	85
🟢 PWA	90

Lighthouse ran with https://deriv-app-git-fork-farhan-nurzi-deriv-p2ps-1329-issues-w-a5c1e3.binary.sx/

coveralls · 2023-08-04T05:23:29Z

coverage: 25.601% (+0.04%) from 25.559% when pulling 036d752 on farhan-nurzi-deriv:P2PS-1329/issues-when-refreshing-the-page into 29ee48f on binary-com:master.

ameerul-deriv · 2023-08-04T07:07:31Z

packages/p2p/src/components/my-profile/payment-methods/__tests__/payment-methods.spec.tsx

+    SendbirdChat: jest.fn().mockReturnValue({}),
+}));
+
+jest.mock('@sendbird/chat/message', () => ({


why are we mocking the sendbird chat here? is it causing issues?

Yeah it causing issue because of Jim's PR #9378. @jim-deriv can we maybe find a solution for this? we put this in many test files.

Hi @farhan-nurzi-deriv , @ameerul-deriv, If you guys think a global mock is the best way to go, please go for it, my initial view was that the global mock will create mocks for everything, even when they're not needed. But if that makes your work easier, then please do so. But bare in mind that this is the same pattern we use for @deriv/* packages that we mock, we don't do global mocks (not saying that it's the best, but it's what we currently do, so you guys should feel free to innovate).

farhan-nurzi-deriv · 2023-08-04T07:30:30Z

packages/p2p/jest.config.js

@@ -29,4 +29,5 @@ module.exports = {
        '<rootDir>/coverage/lcov-report',
        '<rootDir>/dist',
    ],
+    transformIgnorePatterns: ['/node_modules/(?!@sendbird/chat).+\\.js$'],


To fix @sendbird/chat error when running jest

sonarcloud · 2023-08-04T09:08:34Z

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.7% Duplication

… P2PS-1329/issues-when-refreshing-the-page

gitguardian · 2023-10-04T08:06:34Z

⚠️ GitGuardian has uncovered 1 secret following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secret in your pull request

GitGuardian id	Secret	Commit	Filename
-	Generic High Entropy Secret	`c6bd7f1`	nx.json	View secret

🛠 Guidelines to remediate hardcoded secrets

Understand the implications of revoking this secret by investigating where it is used in your code.
Replace and store your secret safely. Learn here the best practices.
Revoke and rotate this secret.
If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider

following these best practices for managing and storing secrets including API keys and other credentials
install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.

^{🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!}

… P2PS-1329/issues-when-refreshing-the-page

sonarcloud · 2023-10-16T05:20:53Z

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
5.3% Duplication

fix: fix issues when refreshing advertiser and my-profile page

4f08b29

farhan-nurzi-deriv requested review from farrah-deriv and nijil-deriv as code owners August 4, 2023 04:46

boring-cyborg bot added the P2P label Aug 4, 2023

vercel bot deployed to Preview August 4, 2023 05:02 View deployment

ameerul-deriv reviewed Aug 4, 2023

View reviewed changes

farhan-nurzi-deriv commented Aug 4, 2023

View reviewed changes

fix: sendbird error in test files

d967bf5

farhan-nurzi-deriv force-pushed the P2PS-1329/issues-when-refreshing-the-page branch from e291129 to d967bf5 Compare August 4, 2023 07:33

ameerul-deriv approved these changes Aug 4, 2023

View reviewed changes

ameerul-deriv mentioned this pull request Aug 4, 2023

fix: registration flow in buy/sell tab #9573

Merged

nada-deriv approved these changes Aug 4, 2023

View reviewed changes

vercel bot deployed to Preview August 4, 2023 08:10 View deployment

jim-deriv previously approved these changes Aug 4, 2023

View reviewed changes

refactor: prevent destructuring error when response is undefined

116a07d

farhan-nurzi-deriv dismissed jim-deriv’s stale review via 116a07d August 4, 2023 09:04

jim-deriv previously approved these changes Aug 4, 2023

View reviewed changes

vercel bot deployed to Preview August 4, 2023 09:33 View deployment

niloofar-deriv approved these changes Aug 4, 2023

View reviewed changes

Merge branch 'master' of https://github.com/binary-com/deriv-app into…

7e36879

… P2PS-1329/issues-when-refreshing-the-page

farhan-nurzi-deriv dismissed jim-deriv’s stale review via 7e36879 September 22, 2023 08:38

vercel bot deployed to Preview September 22, 2023 09:06 View deployment

fix: failed tests

bc5e329

vercel bot deployed to Preview September 27, 2023 04:42 View deployment

farhan-nurzi-deriv deployed to Preview October 4, 2023 08:03 — with GitHub Actions View deployment

farhan-nurzi-deriv temporarily deployed to Preview October 4, 2023 08:06 — with GitHub Actions Inactive

Farhan-slurrp added 2 commits October 4, 2023 16:15

fix: block overlay doesnt show the advertiser name

345cede

Merge branch 'master' of https://github.com/binary-com/deriv-app into…

c6bd7f1

… P2PS-1329/issues-when-refreshing-the-page

farhan-nurzi-deriv force-pushed the P2PS-1329/issues-when-refreshing-the-page branch from 4d08c20 to c6bd7f1 Compare October 4, 2023 08:16

farhan-nurzi-deriv deployed to Preview October 4, 2023 08:16 — with GitHub Actions View deployment

chore: empty commit

8094bf5

farhan-nurzi-deriv deployed to Preview October 4, 2023 08:46 — with GitHub Actions View deployment

farrah-deriv previously approved these changes Oct 4, 2023

View reviewed changes

ameerul-deriv approved these changes Oct 5, 2023

View reviewed changes

Merge branch 'master' of https://github.com/binary-com/deriv-app into…

3568950

… P2PS-1329/issues-when-refreshing-the-page

farhan-nurzi-deriv dismissed farrah-deriv’s stale review via 3568950 October 12, 2023 02:21

farhan-nurzi-deriv deployed to Preview October 12, 2023 02:22 — with GitHub Actions Active

chore: epmty commit

1720962

farhan-nurzi-deriv deployed to Preview October 12, 2023 06:38 — with GitHub Actions View deployment

Merge branch 'master' of https://github.com/binary-com/deriv-app into…

036d752

… P2PS-1329/issues-when-refreshing-the-page

farhan-nurzi-deriv deployed to Preview October 16, 2023 05:16 — with GitHub Actions View deployment

farrah-deriv approved these changes Oct 16, 2023

View reviewed changes

hirad-deriv merged commit a52c4e9 into binary-com:master Oct 17, 2023
5 of 6 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

FarhanNurzi/P2PS-1329/Advertisers ads are duplicating in other advertiser profile after manual refresh #9569

FarhanNurzi/P2PS-1329/Advertisers ads are duplicating in other advertiser profile after manual refresh #9569

farhan-nurzi-deriv commented Aug 4, 2023

vercel bot commented Aug 4, 2023 •

edited

Loading

github-actions bot commented Aug 4, 2023 •

edited

Loading

github-actions bot commented Aug 4, 2023 •

edited

Loading

coveralls commented Aug 4, 2023 •

edited

Loading

ameerul-deriv Aug 4, 2023

farhan-nurzi-deriv Aug 4, 2023

jim-deriv Aug 4, 2023

farhan-nurzi-deriv Aug 4, 2023

sonarcloud bot commented Aug 4, 2023

gitguardian bot commented Oct 4, 2023 •

edited

Loading

sonarcloud bot commented Oct 16, 2023

FarhanNurzi/P2PS-1329/Advertisers ads are duplicating in other advertiser profile after manual refresh #9569

FarhanNurzi/P2PS-1329/Advertisers ads are duplicating in other advertiser profile after manual refresh #9569

Conversation

farhan-nurzi-deriv commented Aug 4, 2023

Changes:

Screenshots:

vercel bot commented Aug 4, 2023 • edited Loading

github-actions bot commented Aug 4, 2023 • edited Loading

github-actions bot commented Aug 4, 2023 • edited Loading

coveralls commented Aug 4, 2023 • edited Loading

ameerul-deriv Aug 4, 2023

Choose a reason for hiding this comment

farhan-nurzi-deriv Aug 4, 2023

Choose a reason for hiding this comment

jim-deriv Aug 4, 2023

Choose a reason for hiding this comment

farhan-nurzi-deriv Aug 4, 2023

Choose a reason for hiding this comment

sonarcloud bot commented Aug 4, 2023

gitguardian bot commented Oct 4, 2023 • edited Loading

⚠️ GitGuardian has uncovered 1 secret following the scan of your pull request.

sonarcloud bot commented Oct 16, 2023

vercel bot commented Aug 4, 2023 •

edited

Loading

github-actions bot commented Aug 4, 2023 •

edited

Loading

github-actions bot commented Aug 4, 2023 •

edited

Loading

coveralls commented Aug 4, 2023 •

edited

Loading

gitguardian bot commented Oct 4, 2023 •

edited

Loading