Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

thisyahlen/chore: add useTradingPlatformAccounts to deriv api package #9807

Conversation

thisyahlen-deriv
Copy link
Contributor

Changes:

Please provide a summary of the change.

Screenshots:

Please provide some screenshots of the change.

@vercel
Copy link

vercel bot commented Aug 24, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
deriv-app ✅ Ready (Inspect) Visit Preview Aug 24, 2023 8:21am

@github-actions
Copy link
Contributor

github-actions bot commented Aug 24, 2023

A production App ID was automatically generated for this PR. (log)

Click here to copy & paste above information.
- **PR**: [https://github.com/binary-com/deriv-app/pull/9807](https://github.com/binary-com/deriv-app/pull/9807)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-thisyahlen-deriv-thisyahlen-wall-1608-0af439.binary.sx?qa_server=red.binaryws.com&app_id=32922
    - **Original**: https://deriv-app-git-fork-thisyahlen-deriv-thisyahlen-wall-1608-0af439.binary.sx
- **App ID**: `32922`

@github-actions
Copy link
Contributor

github-actions bot commented Aug 24, 2023

🚨 Lighthouse report for the changes in this PR:

Category Score
🔺 Performance 21
🟧 Accessibility 75
🟢 Best practices 92
🟧 SEO 85
🟢 PWA 90

Lighthouse ran with https://deriv-app-git-fork-thisyahlen-deriv-thisyahlen-wall-1608-0af439.binary.sx/

@coveralls
Copy link

Coverage Status

coverage: 10.045% (-0.003%) from 10.048% when pulling ef573b0 on thisyahlen-deriv:thisyahlen/WALL-1608/useTradingPlatformAccounts into 278eacd on binary-com:master.

yashim-deriv
yashim-deriv previously approved these changes Aug 24, 2023
@sonarcloud
Copy link

sonarcloud bot commented Aug 24, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@yashim-deriv yashim-deriv merged commit 4a9119a into binary-com:master Aug 24, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants