This repository has been archived by the owner on Sep 26, 2024. It is now read-only.
[CRO] Amir/CRO-456/Remove country restriction inside the codebase for A/B test #7132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amir-deriv
requested review from
habib-deriv,
prince-deriv,
mitra-deriv and
fasihali-deriv
as code owners
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
|
Preview Link: https://amir-cro-456-country.deriv-com-preview-links.pages.dev
|
|
Running Lighthouse audit... |
|
❌ Smoke test run (5) failed. See logs for details: Visit Action |
ali-hosseini-deriv
approved these changes
Feb 22, 2024
NikitK-deriv
approved these changes
Feb 22, 2024
jim-deriv
approved these changes
Feb 22, 2024
agrim-deriv
pushed a commit
to agrim-deriv/deriv-com
that referenced
this pull request
Feb 26, 2024
agrim-deriv
pushed a commit
to agrim-deriv/deriv-com
that referenced
this pull request
Feb 26, 2024
prince-deriv
added a commit
that referenced
this pull request
Mar 14, 2024
* Hasan/Pr 00 flicker regression 1 (#7134) * chore: test workflow * fix: footer disclaimer issue * chore: test workflow * fix: footer disclaimer * feat: testing flickering (#7139) * feat: testing flickering * feat: udpate use auth check --------- Co-authored-by: Wojciech Brygola <wojciech@regentmarkets.com> * agrim/DPROD-1855/image changes (#7069) * fix: replacing blurred images * revert: reverted unordered code * fix: replacing blurry images * fix: capital letter for i in step index * fix: capital letter for i * chore: adding the derivx images and replacing blurred ones * chore: remove country restriction inside the codebase (#7132) * Konstantinos/DPROD-3217/Update payment methods (#7047) * feat: update payment methods * feat: update string * auto-pull-translation * translation: 📚 sync translations from crowdin feature branch * auto-pull-translation * feat: empty commit * feat: fix comma and currency * fix: equitel values * fix: equitel values * fix: logos * fix: mobile payments values request for change again * feat: update values --------- Co-authored-by: DerivFE <80095553+DerivFE@users.noreply.github.com> * Agrim/DPROD-3441/Set disclaimer on trade specifications (#7095) * text: disclaimer on trade specifications * auto-pull-translation * fix: resolve conflict * fix: fixing the error * fix: resolve conflicts * auto-pull-translation * fix: resolve conflict * fix: fixing the error * fix: resolve conflict * auto-pull-translation * fix: resolve conflict * fix: fixing the error * fix: resolve conflict * auto-pull-translation * fix: resolve conflict * fix: fixing the error * hasan/DPROD-3322/Created actions for row and eu build (#7157) * chore: test workflow * chore: added preview workflow for row and eu * chore: fixed preview workflow for row and eu * chore: added group * Update .github/actions/npm_install_from_cache/action.yml Co-authored-by: Ali(Ako) Hosseini <ali.hosseini@deriv.com> * Update .github/actions/npm_install_from_cache/action.yml Co-authored-by: Ali(Ako) Hosseini <ali.hosseini@deriv.com> * Update .github/workflows/generate-preview-link-row.yml Co-authored-by: Ali(Ako) Hosseini <ali.hosseini@deriv.com> * Update .github/workflows/generate-preview-link-eu.yml Co-authored-by: Ali(Ako) Hosseini <ali.hosseini@deriv.com> * Update .github/workflows/generate-preview-link-row.yml Co-authored-by: Ali(Ako) Hosseini <ali.hosseini@deriv.com> * Update .github/workflows/generate-preview-link-row.yml Co-authored-by: Ali(Ako) Hosseini <ali.hosseini@deriv.com> * Update .github/workflows/generate-preview-link-eu.yml Co-authored-by: Ali(Ako) Hosseini <ali.hosseini@deriv.com> * Update .github/workflows/generate-preview-link-row.yml Co-authored-by: Ali(Ako) Hosseini <ali.hosseini@deriv.com> --------- Co-authored-by: Ali(Ako) Hosseini <ali.hosseini@deriv.com> * Pr 00 workflow fix (#7173) * chore: test workflow * chore: added shell to action * chore: removed generate-preview-link-row-eu * Pr 00 workflow fix 3 (#7178) * chore: test workflow * chore: fixed preview url issue * chore: removed row eu workflow * Pr 00 workflow fix 4 (#7182) * chore: test workflow * chore: removed * chore: test * chore: test * chore: fixed preview link workflow * Agrim/DPROD-3557/Translation 3557 footer change (#7158) * text: updating footer text * text: updating the text in the footer for EU and CPA * text: terms and conditions edit of text * text: edit the text * text: formatting the text * fix: changes in the text links * fix: fixing t&c, risk disclosure, secure links * auto-pull-translation * auto-pull-translation * fix: modifications in footer * auto-pull-translation * auto-pull-translation * auto-pull-translation * auto-pull-translation * fix: changes in the text links * auto-pull-translation * auto-pull-translation * auto-pull-translation * auto-pull-translation * auto-pull-translation * auto-pull-translation * fix: to redeploy and trigger build * auto-pull-translation * fix: to redeploy and trigger build * auto-pull-translation * auto-pull-translation * auto-pull-translation * translation: 📚 sync translations from crowdin feature branch * Agrim/DPROD-3441/Set disclaimer on trade specifications (#7095) * text: disclaimer on trade specifications * auto-pull-translation * fix: resolve conflict * fix: fixing the error * fix: resolve conflicts * auto-pull-translation * fix: resolve conflict * fix: fixing the error * fix: resolve conflict * auto-pull-translation * fix: resolve conflict * fix: fixing the error * fix: resolve conflict * auto-pull-translation * fix: resolve conflict * fix: fixing the error * text: updating footer text * auto-pull-translation * auto-pull-translation * auto-pull-translation * auto-pull-translation * auto-pull-translation * auto-pull-translation * auto-pull-translation * auto-pull-translation * auto-pull-translation * auto-pull-translation * auto-pull-translation * auto-pull-translation * fix: to redeploy and trigger build * auto-pull-translation * fix: to redeploy and trigger build * auto-pull-translation * auto-pull-translation * auto-pull-translation * translation: 📚 sync translations from crowdin feature branch * fix: resolve conflict * fix: resolve conflict * auto-pull-translation * auto-pull-translation * auto-pull-translation * auto-pull-translation * auto-pull-translation * auto-pull-translation * auto-pull-translation * auto-pull-translation * auto-pull-translation * auto-pull-translation * auto-pull-translation * auto-pull-translation * fix: to redeploy and trigger build * auto-pull-translation * fix: to redeploy and trigger build * auto-pull-translation * auto-pull-translation * auto-pull-translation * fix: resolve conflict * auto-pull-translation * auto-pull-translation * auto-pull-translation * auto-pull-translation * auto-pull-translation * auto-pull-translation * auto-pull-translation * auto-pull-translation * auto-pull-translation * auto-pull-translation * auto-pull-translation * auto-pull-translation * fix: to redeploy and trigger build * auto-pull-translation * fix: to redeploy and trigger build * auto-pull-translation * auto-pull-translation * auto-pull-translation * translation: 📚 sync translations from crowdin feature branch * fix: resolve conflict * auto-pull-translation * translation: 📚 sync translations from crowdin feature branch --------- Co-authored-by: DerivFE <80095553+DerivFE@users.noreply.github.com> Co-authored-by: prince-deriv <prince@deriv.com> * Agrim/DPROD-3025/Replace the spanish row pdf's with english to spanish pdf's (#7128) * fix: replacing the spanish row pdf's with english to spanish pdf's * fix: remove spaces from pdf name * behnaz/DPROD-3359/Feb trading data (#7060) * chorn: fx row * chorn: derived row * chorn: derived coma row * chorn: derived add quet row * chorn: derived add quet2 row * chorn: stock row * chorn: stock GBP row * chorn: etfs row * chorn: etfs remove extra 1 row * chorn: crypto row * chorn: crypto base row * chorn: comod row * chorn: comod EU * chorn: fx EU * chorn: derived EU * chorn: stock EU * chorn: etfs EU * chorn: crypto EU * mayuran/DPROD-2759/ws_improvements (#7070) * fix: wip * fix: dummy initial * fix: check socket * fix: added conditionsa * fix: ws call * fix: ws reconnect * fix: check api manager * chore: trigger vercel * fix: ws socket calls * fix: session storage * fix: window added * fix: addded window * fix: remove unwanted code * fix: check * fix: kogs * fix: ready state * fix: code clear * fix: added logs * fix: minor issue in reconnect * fix: loading changed logic * fix: remove session storage * Revert "fix: remove session storage" This reverts commit abb84c3. * fix: remove session storage * fix: improvement of use WS * fix: remove console logs (#7201) * Update smoketests.yml - change e2e skip term (#7194) * Update smoketests.yml - change e2e skip term If the term 'skipsm' is specified in the branch name then skip the e2e tests (used to be 'quill'). This is because the dev knows they are making radical change which will need the tests to be modified at a later date. * Update smoketests.yml - Modified to use DRAFT param Skip smoket test if the PR is in Draft mode. * Update generate-preview-link.yml - Add DRAFT param (#7198) We need to store a new param to GH storage, DRAFT. So that the smoketest.yml can use it to ignore a test run. * Fasih/DPROD-3590/integrate firebase feature flag for third party items (#7149) * feat: implement json which contain items name * feat: adding flag on third party packages * feat: implemented flag on trade platfrom apps * feat: removed unsued code * feat: made some items value false * feat: enabled all items * feat: add condition for derivgo footer badge * feat: updated keys * feat: interated api and hook * feat: updated hook with importing function * feat: updated hook and filtered footer icon data * feat: remvoed hotjar and gtm from flags * feat: removed unused code * feat: made every item true * feat: updated other layout files * feat: updated the condition --------- Co-authored-by: fasihali-deriv <muhammad.fasih@deriv.com> Co-authored-by: Muhammad Fasih Ali Naqvi <muhammadfasih@Muhammad-Fasihs-Mac-X7KDC4NKQ0-Standard.local> * chore: update multiple build action yml (#7210) * chore: update multiple build action yml * chore: update action with To DO * Update smoketests.yml - Mod to draft param (#7217) * Update smoketests.yml - Mod to draft param The draft param wasn't being interpretted correctly. * Update smoketests.yml * chore: updated the config url (#7223) Co-authored-by: Muhammad Fasih Ali Naqvi <muhammadfasih@Muhammad-Fasihs-Mac-X7KDC4NKQ0-Standard.local> * chore: update icon file (#7151) * behnaz/MARK-1066/phone-8d (#7185) * chore: phone 8 d * chore: add the phone length * chore: decrease padding in tablet (#7152) * Agrim/DPROD-2993/Translation 2993 meta changes dtrader (#7168) * fix: changing name and description of dTrader seo * auto-pull-translation * auto-pull-translation * auto-pull-translation * fix: meta attributes * auto-pull-translation * translation: 📚 sync translations from crowdin feature branch * auto-pull-translation * auto-pull-translation * auto-pull-translation * fix: empty commit * auto-pull-translation * translation: 📚 sync translations from crowdin feature branch * fix: empty commit * fix: empty commit --------- Co-authored-by: DerivFE <80095553+DerivFE@users.noreply.github.com> Co-authored-by: Agrim Jain <agrimjain@Agrim-Jains-Mac-FQ22G9XXP9-Standard.local> * Aswathy/DPROD-3448/Deriv Academy new Sign Up flow (#7090) * feat: new signup page * fix: redirection of login page * feat: academy app id redirection for login * fix: window error issue * fix: window error * fix: app id connection and login page * fix: changed the url flow for academy signup flow * fix: passowrd changes * fix: validation for password * fix: password feature button * fix: added the token auth * fix: added authorized token * fix: background color issue * fix: redirection of url to thinkific * fix: authorize the api call * fix: redirection of language to english only * fix: for handling the response for the country * fix: flickering logo issue * fix: flickering logo issue with use state * fix: flickering logo * fix: created the academy nav logo * fix: logo fix flicker * fix: password page * fix: country selection and disabling button * fix: redirection issue * fix: logo issue * fix: translations issue * fix: logo issue * fix: changed the logo * fix: minimized the logo size * fix: dropdown issues * fix: sonar cloud issues * fix: issues in the design * fix: dropdown is reverted to old one * fix: dropdown issues * fix: removed the button width for residence page * fix: focus blur * fix: added the dropdown search changes * fix: changed the css file * fix: renamed the css file * fix: percy issues * fix: percy run issue * fix: renamed the password files * fix: sonarcloud issues * Agrim/DPROD-3466/fix: color intensity hero (#7141) * fix: color intensity hero * fix: color intensity 2 * fix: improve resolution of image * fix: fix the photo resolution * fix: webp to png fix * fix: changing the image to optimize performance * fix: changing the image to optimize performance * fix: update the image * fix: update photo * fix: resolution fix of image * fix: make the relevant changes to the image * fix: fixing the styling * fix: making required changes * fix: empty commit * fix: empty commit --------- Co-authored-by: Agrim Jain <agrimjain@Agrim-Jains-Mac-FQ22G9XXP9-Standard.local> * Agrim/DPROD-3532/fix: changed the award (#7121) * fix: changed the award * fix: changed award and fix the sizing issue * auto-pull-translation * translation: 📚 sync translations from crowdin feature branch * auto-pull-translation * auto-pull-translation * auto-pull-translation * translation: 📚 sync translations from crowdin feature branch * auto-pull-translation * translation: 📚 sync translations from crowdin feature branch * fix: empty commit * fix: empty commit * fix: empty commit * fix: empty commit --------- Co-authored-by: DerivFE <80095553+DerivFE@users.noreply.github.com> Co-authored-by: Agrim Jain <agrimjain@Agrim-Jains-Mac-FQ22G9XXP9-Standard.local> * fix: minified error (#7255) * feat: adding ctrader to carousel (#7235) Co-authored-by: Agrim Jain <agrimjain@Agrim-Jains-Mac-FQ22G9XXP9-Standard.local> * behnaz/MARK-1003/lead to deriv.com (#7086) * chore: url lead to deriv.com * chore: url lead to affiliate-ib * chore: remove the extra space * fix: initial contact us page (#7226) * Agrim/DPROD-3654/Translation 3654 translation for the footer with links (#7247) * fix: incorrect links in the ROW footer * fix: fixes in the text * fix: fixing the cpa issue * fix: capital letters on the links * auto-pull-translation * auto-pull-translation * translation: 📚 sync translations from crowdin feature branch * fix: empty commit * auto-pull-translation * translation: 📚 sync translations from crowdin feature branch * fix: empty commit * fix: empty commit * fix: empty commit * fix: deleting telgram from cpa --------- Co-authored-by: Agrim Jain <agrimjain@Agrim-Jains-Mac-FQ22G9XXP9-Standard.local> Co-authored-by: DerivFE <80095553+DerivFE@users.noreply.github.com> * Hasan/DPROD-3530/platform overlap issue (#7234) * chore: fixed platform swiper overflow issue * chore: fixed platform overlay for tr lang * chore: fixed swiper pagination in responsive device * chore: fixed link css issue * empty: 🚀 to redeploy and trigger build * chore: fixed rtl and font size issue * chore: fixed spacing for tr * chore: fixed pagination spacing * chore: fixed learn more link * chore: fixed learn more link font size * chore: fixed learn more link font size * empty: 🚀 to redeploy and trigger build --------- Co-authored-by: aswathy-deriv <aswathy@deriv.com> * mayuran/DPROD-3373/Update 'Deal cancellation' (#6985) * fix: translation change * chore: trigger vercel * fix: change * fix: message * fix: text issue multiplier * fix: revert * chore: trigger vercel * chore: trigger vercel * auto-pull-translation * translation: 📚 sync translations from crowdin feature branch * chore: trigger vercel * fix: deal cancelation * auto-pull-translation * translation: 📚 sync translations from crowdin feature branch * chore: trigger vercel * fix: row word * fix: stop out text * fix: step out text * auto-pull-translation * translation: 📚 sync translations from crowdin feature branch * chore: trigger vercel --------- Co-authored-by: DerivFE <80095553+DerivFE@users.noreply.github.com> * mayuran/DPROD-3544/accumulator-update (#7208) * feat: option revamp * feat: change description * auto-pull-translation * auto-pull-translation * translation: 📚 sync translations from crowdin feature branch * fix: translations trigger empty commit * fix: translations on questions * fix: translation for button * auto-pull-translation * translation: 📚 sync translations from crowdin feature branch * fix: review comments * fix: slider for mobile * feat: master merge * fix: initial accumulator page * fix: image issue * fix: image change * auto-pull-translation * translation: 📚 sync translations from crowdin feature branch * fix: remove script * chore: trigger vercel * fix: img * fix: trade hub button * fix: remove unwanted code * fix: sub tasks * fix: id added * fix: packages updated * fix: try * fix: try float * fix: float * fix: float * chore: trigger vercel * fix: floating in options * auto-pull-translation * auto-pull-translation * translation: 📚 sync translations from crowdin feature branch * auto-pull-translation * translation: 📚 sync translations from crowdin feature branch * chore: trigger vercel * fix: tab padding * auto-pull-translation * translation: 📚 sync translations from crowdin feature branch * fix: redirection * fix: gap * fix: font sixe * fix: options layout * fix: text color * fix: color --------- Co-authored-by: “konstantinosG-deriv” <konstantinos.gkagiannis@regentmarkets.com> Co-authored-by: DerivFE <80095553+DerivFE@users.noreply.github.com> * patch fix (#7291) * fix: digital options * fix: breadcrumbs * chore: extract unextracted strings (#7298) * Stp 468 amir/cro 468/signup page ab test content (#7290) * feat: add ab test on signup content * chore: rename component name * chore: update translation literal in messages.json file * auto-pull-translation * chore: sync translations * auto-pull-translation * auto-pull-translation * auto-pull-translation * auto-pull-translation * chore: sync translations from crowdin * auto-pull-translation * auto-pull-translation * chore: sync translations from crowdin * chore: removed dashboard from p2p and deriv go also updated config (#7233) Co-authored-by: Muhammad Fasih Ali Naqvi <muhammadfasih@Muhammad-Fasihs-Mac-X7KDC4NKQ0-Standard.local> * fix: fixed new tab issue (#7256) Co-authored-by: Lipika Sethi <lipikasethi@Lipika-Sethis-MacBook-Pro-T4NHLX94FY-Standard.local> --------- Co-authored-by: Hasan Mobarak <126637868+hasan-deriv@users.noreply.github.com> Co-authored-by: Wojciech Brygola <141034155+wojciech-deriv@users.noreply.github.com> Co-authored-by: Wojciech Brygola <wojciech@regentmarkets.com> Co-authored-by: Agrim Jain <157685219+agrim-deriv@users.noreply.github.com> Co-authored-by: amir ali <129206554+amir-deriv@users.noreply.github.com> Co-authored-by: konstantinosG-deriv <konstantinos.gkagiannis@regentmarkets.com> Co-authored-by: DerivFE <80095553+DerivFE@users.noreply.github.com> Co-authored-by: Ali(Ako) Hosseini <ali.hosseini@deriv.com> Co-authored-by: prince-deriv <prince@deriv.com> Co-authored-by: behnaz <behnaz@regentmarkets.com> Co-authored-by: mayuran-deriv <129507167+mayuran-deriv@users.noreply.github.com> Co-authored-by: markodonnell-deriv <144238191+markodonnell-deriv@users.noreply.github.com> Co-authored-by: fasihali-deriv <121229483+fasihali-deriv@users.noreply.github.com> Co-authored-by: fasihali-deriv <muhammad.fasih@deriv.com> Co-authored-by: Muhammad Fasih Ali Naqvi <muhammadfasih@Muhammad-Fasihs-Mac-X7KDC4NKQ0-Standard.local> Co-authored-by: Habib Deriv <88178645+habib-deriv@users.noreply.github.com> Co-authored-by: Agrim Jain <agrimjain@Agrim-Jains-Mac-FQ22G9XXP9-Standard.local> Co-authored-by: Aswathy-Deriv <96725617+aswathy-deriv@users.noreply.github.com> Co-authored-by: aswathy-deriv <aswathy@deriv.com> Co-authored-by: prince-deriv <82309725+prince-deriv@users.noreply.github.com> Co-authored-by: lipika-deriv <66935423+lipika-deriv@users.noreply.github.com> Co-authored-by: Lipika Sethi <lipikasethi@Lipika-Sethis-MacBook-Pro-T4NHLX94FY-Standard.local>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
Type of change