Fix performance regression introduced by syncable_voice #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Great catch! I added a new benchmark to capture perf of SID synth clocking and got the same result as you, a 41.48% speedup. This is a massive speedup, I truly don't understand why std implementation would be so bad in the case of small arrays but I'll take a handcrafted version with these types of results any day. :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Every call to syncable_voice and syncable_voice_mut uses a predictable index, so these calls can be optimized well, in theory. However, rustc doesn't optimize rotate_left calls. Therefore, use a handwritten rotate3 function (for arrays of size 3) instead.
This change does speed up the complete SID emulation (Synth::clock and Synth::output, without resampling) by 45%. @binaryfields, it would be nice if you could verify this.