Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Capture upload_only_when_stable from kwargs #25

Merged
merged 4 commits into from
Aug 2, 2019

Conversation

uilianries
Copy link
Member

Signed-off-by: Uilian Ries <uilianries@gmail.com>
@uilianries uilianries requested review from SSE4 and Croydon July 31, 2019 19:02
Signed-off-by: Uilian Ries <uilianries@gmail.com>
Signed-off-by: Uilian Ries <uilianries@gmail.com>
@uilianries
Copy link
Member Author

these error were caused because something changed in CPT. I need to investigate, maybe is a bug there

Signed-off-by: Uilian Ries <uilianries@gmail.com>
@codecov-io
Copy link

Codecov Report

Merging #25 into master will increase coverage by 0.18%.
The diff coverage is 96.36%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #25      +/-   ##
==========================================
+ Coverage   98.23%   98.42%   +0.18%     
==========================================
  Files           8        8              
  Lines         170      190      +20     
==========================================
+ Hits          167      187      +20     
  Misses          3        3
Impacted Files Coverage Δ
bincrafters/build_template_default.py 100% <ø> (ø) ⬆️
bincrafters/__init__.py 100% <100%> (ø) ⬆️
bincrafters/build_shared.py 97.98% <96.29%> (+0.31%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e164003...a5b9792. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants