-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Resolve issue #8 #9
Conversation
Hey - thanks for the PR! I don't think that we want the solution to be downgrading jupyterlab to < 1.0...that's a dependency we probably need to keep close to latest. I'm a bit surprised that it doesn't work though - have you asked around in the jupyter-latex repository? Maybe this is a bug? |
I fully agree, but no other versions combination would work w/ repo2docker (fails at extension installation step). I didn't ask at jupyter-latex, because I believe this is a repo2docker (base image / conda) issue rather than jupyter-latex, as I had it working fine w/ jpuyterlab>=1.2,<2.0 in own Docker image. (Also note that: jupyter-latex Python requirements for binder are even lower.) As it seems to be something a bit harder to tackle upstream the toolchain I hoped I could leave it here, at least sharing my discoveries/fixes via this PR. |
hmmm - well if it's a repo2docker issue then we should be able to resolve it with the right config files. All repo2docker is doing is starting with a super minimal base enviornment, and then just installing things on top of it, so we should be able to get wherever we need to that way. Considering that the jupyter-latex environment is pinned to lab <1.0, perhaps it only works with lab <1.0? If that's the case then I'm fine merging this in as-is. |
I'm positive that My bet is on issues w/ conda(?) installing first |
Some updates:
|
hmmmm - is it worth raising this issue to the attention of the jupyterlab folks then? Unfortunately it means that I am not very well-qualified to debug since I'm not a great javascript person :-/ |
Me neither, but also I was wrong - it is Possibly related (unresolved) issue: jupyterlab/jupyterlab-latex#135 , but different error message and concerns only ver. 2.0, not 1.0. |
hmmmm...I am not sure what's the right path forward there :-/ |
I would propose:
The viable alternatively IMVHO is to reject this PR and:
|
Thanks for the thoughtful explanation - Wanna open up an issue that describes the problem you mentioned above, and then I'll give this a merge? |
Done: #10 |
great - thanks so much for following up on this one 👍 |
Closes #8
Changes incl: