-
-
Notifications
You must be signed in to change notification settings - Fork 697
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Can Firebase and Cache be disabled via the JSON payload? #1119
Comments
I'm pretty sure those parameters are not parsed in a JSON body (see Line 1811 in 9d3fc20
You can try including them, and if they're not supported, ntfy will reject the request as "invalid JSON". You can also turn on debug logs on the server and see if things are written to the cache or forwarded to firebase |
That's the right code, thank you! So this looks like adding them via headers in addition to the JSON message payload should work.
I did send messages against ntfy.sh with |
Sorry, I missed this question. Yes, you can definitely combine JSON body and HTTP headers. I just did a quick test, and a JSON body with |
Thanks for confirming! Now the question would be: should firebase and cache be added to the JSON functionality? Looking at the code, this seems straightforward to implement, and I would create a PR for this. |
I'm not sure. I don't know what @binwiederhier's preferences are regarding fields in the JSON body vs fields in HTTP headers |
I've implemented it and opened a PR as an exercise :) Feel free to close it, if the feature is not desired. Though, I believe, since the JSON API is intended as a workaround for apps that make it difficult or impossible to define http headers, that this change just completes the API. Lines 1082 to 1084 in 9d3fc20
|
❓ Question
The documentation explains how to disable firebase or message caching via http request headers.
But these are not listed in the corresponding table on publishing via JSON.
Is this just missing from the documentation or not implemented?
If not implemented, could the JSON payload be paired with the request headers?
Is there a simple way to test this? The message payload does not seem to include any hint about how these properties were set.
The text was updated successfully, but these errors were encountered: