Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix pfx dedup and add tests #233

Merged
merged 1 commit into from
Oct 29, 2019
Merged

Fix pfx dedup and add tests #233

merged 1 commit into from
Oct 29, 2019

Conversation

taktv6
Copy link
Member

@taktv6 taktv6 commented Oct 29, 2019

No description provided.

@taktv6 taktv6 requested a review from czerwonk October 29, 2019 15:44
@codecov-io
Copy link

Codecov Report

Merging #233 into master will increase coverage by 0.33%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #233      +/-   ##
==========================================
+ Coverage   57.53%   57.87%   +0.33%     
==========================================
  Files         141      141              
  Lines        7701     7701              
==========================================
+ Hits         4431     4457      +26     
+ Misses       3093     3066      -27     
- Partials      177      178       +1
Impacted Files Coverage Δ
net/prefix.go 85.15% <0%> (+3.12%) ⬆️
net/ip.go 100% <0%> (+2.85%) ⬆️
net/ip_cache.go 100% <0%> (+64.28%) ⬆️
net/prefix_cache.go 100% <0%> (+64.28%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5496009...09b6466. Read the comment docs.

Copy link
Member

@czerwonk czerwonk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@czerwonk czerwonk merged commit 9a2f84b into master Oct 29, 2019
@taktv6 taktv6 deleted the fix/pfxcache branch October 31, 2019 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants