Move contributing ASNs to VRF & add check for all Cluster IDs in the same VRF #396
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BarbarossaTM
added
type:improvement
BarbarossaTM
commented
Nov 26, 2022
BarbarossaTM
force-pushed
the
max/contributingclusterId
branch
from
8c01d4d
to
e6a64b9
Compare
Codecov Report
@@ Coverage Diff @@
## master #396 +/- ##
==========================================
- Coverage 55.14% 55.14% -0.01%
==========================================
Files 147 147
Lines 7672 7675 +3
==========================================
+ Hits 4231 4232 +1
- Misses 3245 3247 +2
Partials 196 196
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
BarbarossaTM
force-pushed
the
max/contributingclusterId
branch
3 times, most recently
from
0f2a126
to
c0a359a
Compare
BarbarossaTM
changed the title
taktv6
reviewed
Nov 28, 2022
BarbarossaTM
force-pushed
the
max/contributingclusterId
branch
from
40277c5
to
3a493ad
Compare
Signed-off-by: Maximilian Wilhelm <max@sdn.clinic>
To make sure we don't have any Cluster list loops we need to check all the Cluster IDs used by all sessions within a VRF as in theory there could be multiple iBGP sessions with different cluster IDs set. Signed-off-by: Maximilian Wilhelm <max@sdn.clinic>
BarbarossaTM
force-pushed
the
max/contributingclusterId
branch
from
3a493ad
to
c6d048e
Compare
taktv6
approved these changes
Jan 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.