Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BGP: Make TCP listener VRF aware #407

Merged
merged 1 commit into from
Jan 9, 2023
Merged

Conversation

taktv6
Copy link
Member

@taktv6 taktv6 commented Jan 6, 2023

root@debian:/home/takt# ./bio-rd 
INFO[0000] Reloading configuration                      
INFO[0000] Listener manager: Starting TCP listener on [::]:179 in VRF main 
INFO[0000] Listener manager: Starting TCP listener on 0.0.0.0:179 in VRF main 

root@debian:/home/takt# ss -tlpen | grep 179
LISTEN 0      128          0.0.0.0:179        0.0.0.0:*    users:(("bio-rd",pid=527,fd=12)) ino:13294 sk:2a cgroup:/user.slice/user-1000.slice/session-3.scope <->         
LISTEN 0      128             [::]:179           [::]:*    users:(("bio-rd",pid=527,fd=11)) ino:13293 sk:2e cgroup:/user.slice/user-1000.slice/session-3.scope v6only:1 <->

@taktv6 taktv6 changed the title WIP: BGP: Make TCP listener VRF aware BGP: Make TCP listener VRF aware Jan 6, 2023
@BarbarossaTM BarbarossaTM added the type:feature a new feature request label Jan 6, 2023
routerID uint32
metrics *metricsService
listenAddrsByVRF map[string][]string
listenersByVRF map[string][]*TCPListener
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess this needs synchronization. To be addressed by me.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@taktv6 taktv6 changed the title BGP: Make TCP listener VRF aware WIP: BGP: Make TCP listener VRF aware Jan 7, 2023
@codecov-commenter
Copy link

codecov-commenter commented Jan 7, 2023

Codecov Report

Merging #407 (4dbf9fb) into master (8269abc) will increase coverage by 0.17%.
The diff coverage is 41.07%.

@@            Coverage Diff             @@
##           master     #407      +/-   ##
==========================================
+ Coverage   55.13%   55.31%   +0.17%     
==========================================
  Files         147      146       -1     
  Lines        7674     7669       -5     
==========================================
+ Hits         4231     4242      +11     
+ Misses       3247     3229      -18     
- Partials      196      198       +2     
Flag Coverage Δ
unittests 55.31% <41.07%> (+0.17%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
protocols/bgp/server/fsm.go 27.17% <0.00%> (ø)
routingtable/vrf/vrf_registry.go 67.56% <ø> (ø)
protocols/bgp/server/server.go 18.69% <20.00%> (+1.41%) ⬆️
protocols/bgp/server/bgp_api.go 58.62% <53.84%> (-4.54%) ⬇️
protocols/bgp/server/peer_manager.go 91.66% <77.77%> (-8.34%) ⬇️
protocols/bgp/server/peer.go 3.07% <100.00%> (+0.99%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@taktv6 taktv6 changed the title WIP: BGP: Make TCP listener VRF aware BGP: Make TCP listener VRF aware Jan 7, 2023
@taktv6 taktv6 force-pushed the takt/vrf_aware_listner branch 5 times, most recently from b8592d3 to 4dbf9fb Compare January 8, 2023 10:56
net/tcp/listener_manager.go Show resolved Hide resolved
net/tcp/listener_manager.go Outdated Show resolved Hide resolved
Copy link
Member

@BarbarossaTM BarbarossaTM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@BarbarossaTM BarbarossaTM merged commit 133fb10 into master Jan 9, 2023
@BarbarossaTM BarbarossaTM deleted the takt/vrf_aware_listner branch January 9, 2023 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:feature a new feature request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants