-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BGP: Make TCP listener VRF aware #407
Conversation
taktv6
commented
Jan 6, 2023
•
edited
Loading
edited
a6eece1
to
059948d
Compare
protocols/bgp/server/server.go
Outdated
routerID uint32 | ||
metrics *metricsService | ||
listenAddrsByVRF map[string][]string | ||
listenersByVRF map[string][]*TCPListener |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess this needs synchronization. To be addressed by me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
059948d
to
8848101
Compare
Codecov Report
@@ Coverage Diff @@
## master #407 +/- ##
==========================================
+ Coverage 55.13% 55.31% +0.17%
==========================================
Files 147 146 -1
Lines 7674 7669 -5
==========================================
+ Hits 4231 4242 +11
+ Misses 3247 3229 -18
- Partials 196 198 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
8848101
to
42db4da
Compare
b8592d3
to
4dbf9fb
Compare
4dbf9fb
to
e44abd3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM