Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generalize set next-hop filter action to work for all protocols #410

Merged

Conversation

BarbarossaTM
Copy link
Member

No description provided.

Signed-off-by: Maximilian Wilhelm <max@sdn.clinic>
@BarbarossaTM BarbarossaTM added type:improvement Add robustness/improvements type:feature-prep Preparations for a new feature labels Jan 14, 2023
@BarbarossaTM BarbarossaTM self-assigned this Jan 14, 2023
@codecov-commenter
Copy link

Codecov Report

Merging #410 (878fc1d) into master (5ad5232) will increase coverage by 0.08%.
The diff coverage is 90.47%.

@@            Coverage Diff             @@
##           master     #410      +/-   ##
==========================================
+ Coverage   55.23%   55.31%   +0.08%     
==========================================
  Files         146      146              
  Lines        7686     7705      +19     
==========================================
+ Hits         4245     4262      +17     
- Misses       3240     3241       +1     
- Partials      201      202       +1     
Flag Coverage Δ
unittests 55.31% <90.47%> (+0.08%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
route/bgp_path.go 49.48% <33.33%> (-0.13%) ⬇️
route/path.go 87.34% <100.00%> (+1.13%) ⬆️
route/static.go 69.23% <100.00%> (+4.01%) ⬆️
routingtable/filter/actions/set_nexthop_action.go 58.33% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@BarbarossaTM BarbarossaTM merged commit 15e330c into bio-routing:master Jan 14, 2023
@BarbarossaTM BarbarossaTM deleted the max/policySetNextHopGeneric branch January 14, 2023 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:feature-prep Preparations for a new feature type:improvement Add robustness/improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants