Multiple fixes for policy filters and add support to filter by protocol #413
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BarbarossaTM
added
type:bug-fix
BarbarossaTM
force-pushed
the
max/filterfixes
branch
from
a85ede2
to
d2863aa
Compare
Codecov Report
@@ Coverage Diff @@
## master #413 +/- ##
==========================================
- Coverage 55.31% 55.25% -0.06%
==========================================
Files 146 146
Lines 7705 7722 +17
==========================================
+ Hits 4262 4267 +5
- Misses 3241 3252 +11
- Partials 202 203 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
BarbarossaTM
force-pushed
the
max/filterfixes
branch
from
d2863aa
to
3a5ebde
Compare
BGPPath.Copy() previously did not copy the BGP path attributes associated with a BGPPath leading to changes made to BGP attributes further down the propagation chain overwriting path attributes in routing tables higher up the chain. Signed-off-by: Maximilian Wilhelm <max@sdn.clinic>
Filters did not work correctly when setting path attributes, and any changes to the paths were be lost. Signed-off-by: Maximilian Wilhelm <max@sdn.clinic>
Signed-off-by: Maximilian Wilhelm <max@sdn.clinic>
Signed-off-by: Maximilian Wilhelm <max@sdn.clinic>
Signed-off-by: Maximilian Wilhelm <max@sdn.clinic>
BarbarossaTM
force-pushed
the
max/filterfixes
branch
from
3a5ebde
to
1c5c70a
Compare
taktv6
approved these changes
Jan 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.