Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BMP Receiver: Close Connection Explicitly and with log message #417

Merged
merged 1 commit into from
Jan 19, 2023

Conversation

margau
Copy link
Contributor

@margau margau commented Jan 19, 2023

It was not clear why a connection was not properly accepted after the connection came from the wrong source.
This PR changes the behaviour by explicitly closing the BMP TCP Connection and adding a log output.

@codecov-commenter
Copy link

Codecov Report

Merging #417 (9a7d889) into master (ecd3fda) will decrease coverage by 0.07%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master     #417      +/-   ##
==========================================
- Coverage   54.53%   54.47%   -0.07%     
==========================================
  Files         147      147              
  Lines        7879     7885       +6     
==========================================
- Hits         4297     4295       -2     
- Misses       3377     3384       +7     
- Partials      205      206       +1     
Flag Coverage Δ
unittests 54.47% <0.00%> (-0.07%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
protocols/bgp/server/bmp_receiver.go 9.45% <0.00%> (-0.30%) ⬇️
protocols/device/server.go 78.72% <0.00%> (-4.26%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@taktv6 taktv6 merged commit e47d554 into bio-routing:master Jan 19, 2023
@taktv6
Copy link
Member

taktv6 commented Jan 19, 2023

Looks good. Thanks for your contribution!

@margau margau deleted the improve-bmp-serve branch January 20, 2023 07:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants