RIS-Mirror: Refactoring #434
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
taktv6
force-pushed
the
takt/ris-mirror
branch
2 times, most recently
from
6b9cea0
to
c18bf44
Compare
taktv6
force-pushed
the
takt/ris-mirror
branch
from
c18bf44
to
35f6199
Compare
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## master #434 +/- ##
=======================================
Coverage 54.03% 54.03%
=======================================
Files 147 147
Lines 7963 7963
=======================================
Hits 4303 4303
Misses 3455 3455
Partials 205 205
Flags with carried forward coverage won't be shown. Click here to find out more. 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was unclear in the RIS mirror which member of the
Routerobject is authoritative regarding the VRFs.The idea is to make the local map authoritative on existing VRFs. The
vrf.VRFRegistryis only used to pass it to the metrics package to provide metrics.