Subdirect #15
Merged
Subdirect #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
covracer
force-pushed
the
subdirect
branch
4 times, most recently
from
97ccbc6 to
1bb9759
Compare
darpham
reviewed
Nov 7, 2024
darpham
reviewed
Nov 7, 2024
covracer
force-pushed
the
subdirect
branch
4 times, most recently
from
c0ed434 to
baba85b
Compare
jamesbraza
approved these changes
Nov 7, 2024
| - run: pip install --upgrade pip uv | ||
| env: | ||
| PIP_PROGRESS_BAR: 'off' | ||
| - run: | |
There was a problem hiding this comment.
I moved to setup-uv, if you are curious
- uses: astral-sh/setup-uv@v3
with:
enable-cache: true
- run: uv python pin ${{ matrix.python-version }}
- run: uv sync --python-preference=only-managedThere was a problem hiding this comment.
I've been seeing uv sync and uv.lock in the docs. I'll have to try them out.
| @@ -15,8 +15,33 @@ dynamic = ['version'] | |||
| name = 'allowedflare' | |||
| readme = 'README.md' | |||
|
|
|||
| [project.optional-dependencies] | |||
| precommit = [ | |||
There was a problem hiding this comment.
Doesn't pre-commit handle its deps itself? Or is this to enable local usage of all pre-commit tools
There was a problem hiding this comment.
This is for system/local installation of tools like codespell which pre-commit will use.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background and Links
allowedflare.LoginView, are problematic because they depend on Django setupChanges and Testing
allowedflare.allowedflaretoallowedflare.corefor brevitydemodj/settings.py'\.'requirements.intopyproject.tomlbecause of issues with thedjangorestframework-stubs[compatible-mypy]extra seemingly forcing the oldest version to be chosen; the UV docs say "Note extras are not supported with the requirements.in format."