Nadia, OpenTofu, cdk8s #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamesbraza
reviewed
Sep 30, 2024
helicopyter.py
Outdated
| from cdktf import App, TerraformElement, TerraformStack | ||
| from constructs import Construct, Node | ||
| from tap import Tap | ||
|
|
||
|
|
||
| class HeliChart(Chart): | ||
| def __init__(self, cona: str) -> None: | ||
| super().__init__(App(outdir='.'), cona) |
There was a problem hiding this comment.
Imo this will give us relative pathing issues, depending on where one invokes python
Can you do something like pathlib.Path(__file__).parent
There was a problem hiding this comment.
I might not need to specify it. It was mindlessly copied over from cdktf, where it was specified to stop the library from creating an unused directory.
covracer
force-pushed
the
more-opentofu-nadia
branch
from
4e4d113
to
496fde0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Follow up